Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1631113 > unrolled thread

Re: [PATCH v2 0/2] module: Add module name to modinfo

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 0/2] module: Add module name to modinfo Jessica Yu <jeyu@redhat.com> - 2017-04-26 04:40 +0200
    Re: [PATCH v2 0/2] module: Add module name to modinfo Kees Cook <keescook@chromium.org> - 2017-04-26 06:50 +0200

#1631113 — Re: [PATCH v2 0/2] module: Add module name to modinfo

+++ Kees Cook [21/04/17 15:35 -0700]:
>The mod structure is accessed for the "name" field prior to validating
>sanity in check_modstruct_version(). This becomes very obvious once
>struct layout randomization is happening, so instead add the module
>name to modinfo and use that until the mod struct has been sanity-checked.
>
>-Kees
>
>v2:
>- adjusted for more odd name load failure cases; jeyu

Hi Kees!

These patches look fine to me, would you mind if I held on to them
until after the upcoming merge window? (Since we're at -rc8, and I'd
still like for them to sit in -next for a while)

Thanks,

Jessica

[toc] | [next] | [standalone]

#1631144

On Tue, Apr 25, 2017 at 7:32 PM, Jessica Yu <jeyu@redhat.com> wrote:
> +++ Kees Cook [21/04/17 15:35 -0700]:
>
>> The mod structure is accessed for the "name" field prior to validating
>> sanity in check_modstruct_version(). This becomes very obvious once
>> struct layout randomization is happening, so instead add the module
>> name to modinfo and use that until the mod struct has been sanity-checked.
>>
>> -Kees
>>
>> v2:
>> - adjusted for more odd name load failure cases; jeyu
>
>
> Hi Kees!
>
> These patches look fine to me, would you mind if I held on to them
> until after the upcoming merge window? (Since we're at -rc8, and I'd
> still like for them to sit in -next for a while)

Sure thing; I'm in no rush. :)

Thanks!

-Kees

-- 
Kees Cook
Pixel Security

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web