Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1630231 > unrolled thread

Re: [PATCH v2 2/2] module: Add module name to modinfo

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 2/2] module: Add module name to modinfo Jon Masters <jcm@jonmasters.org> - 2017-04-25 09:10 +0200
    Re: [PATCH v2 2/2] module: Add module name to modinfo Jessica Yu <jeyu@redhat.com> - 2017-04-26 05:00 +0200

#1630231 — Re: [PATCH v2 2/2] module: Add module name to modinfo

Nevermind. Missread the patch as doing something different on first pass.

-- 
Computer Architect | Sent from my 64-bit #ARM Powered phone

> On Apr 25, 2017, at 03:00, Jon Masters <jcm@jonmasters.org> wrote:
> 
>> On 04/21/2017 06:35 PM, Kees Cook wrote:
>> 
>> Accessing the mod structure (e.g. for mod->name) prior to having completed
>> check_modstruct_version() can result in writing garbage to the error logs
>> if the layout of the mod structure loaded from disk doesn't match the
>> running kernel's mod structure layout. This kind of mismatch will become
>> much more likely if a kernel is built with different randomization seed
>> for the struct layout randomization plugin.
>> 
>> Instead, add and use a new modinfo string for logging the module name.
> 
> +Lucas - probably something that the modinfo kmod utility should track.
> 
> Jon.
> 

[toc] | [next] | [standalone]

#1631120

+++ Jon Masters [25/04/17 03:04 -0400]:
>Nevermind. Missread the patch as doing something different on first pass.

It's good to give the kmod folks a heads up anyway (as name would be
visible in modinfo), thanks Jon!

>> On Apr 25, 2017, at 03:00, Jon Masters <jcm@jonmasters.org> wrote:
>>
>>> On 04/21/2017 06:35 PM, Kees Cook wrote:
>>>
>>> Accessing the mod structure (e.g. for mod->name) prior to having completed
>>> check_modstruct_version() can result in writing garbage to the error logs
>>> if the layout of the mod structure loaded from disk doesn't match the
>>> running kernel's mod structure layout. This kind of mismatch will become
>>> much more likely if a kernel is built with different randomization seed
>>> for the struct layout randomization plugin.
>>>
>>> Instead, add and use a new modinfo string for logging the module name.
>>
>> +Lucas - probably something that the modinfo kmod utility should track.
>>
>> Jon.
>>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web