Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1630209 > unrolled thread

Re: [PATCH v3] Staging: most: use __func__ instead of the function name

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Chandra Annamaneni <chandra627@gmail.com> - 2017-04-25 08:30 +0200
    Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Greg KH <greg@kroah.com> - 2017-04-25 20:40 +0200
      Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Chandra Annamaneni <chandra627@gmail.com> - 2017-04-26 04:30 +0200
        Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Joe Perches <joe@perches.com> - 2017-04-26 05:00 +0200

#1630209 — Re: [PATCH v3] Staging: most: use __func__ instead of the function name

    Change video.c to use %s, __func__ instead of function names.
    Warnings flagged by checkpatch.pl
    
    Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>

diff --git a/drivers/staging/most/aim-v4l2/video.c 
b/drivers/staging/most/aim-v4l2/video.c
index e074841..59e861e 100644
--- a/drivers/staging/most/aim-v4l2/video.c
+++ b/drivers/staging/most/aim-v4l2/video.c
@@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
        struct most_video_dev *mdev = video_drvdata(filp);
        struct aim_fh *fh;
 
-       v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
+       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
 
        switch (vdev->vfl_type) {
        case VFL_TYPE_GRABBER:
@@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp)
        struct most_video_dev *mdev = fh->mdev;
        struct mbo *mbo, *tmp;
 
-       v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n");
+       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
 
        /*
         * We need to put MBOs back before we call most_stop_channel()
@@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file, void *priv, 
v4l2_std_id *norm)
        struct aim_fh *fh = priv;
        struct most_video_dev *mdev = fh->mdev;
 
-       v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n");
+       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
 
        *norm = V4L2_STD_UNKNOWN;
        return 0;
@@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file, void 
*priv, unsigned int index)
        struct aim_fh *fh = priv;
        struct most_video_dev *mdev = fh->mdev;
 
-       v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n", index);
+       v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index);
 
        if (index >= V4L2_AIM_MAX_INPUT)
                return -EINVAL;
@@ -441,7 +441,7 @@ static int aim_register_videodev(struct most_video_dev 
*mdev)
 {
        int ret;
 
-       v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n");
+       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);


On Fri, 21 Apr 2017, Greg KH wrote:

> On Fri, Apr 21, 2017 at 11:06:54AM -0700, Chandra Annamaneni wrote:
> > 
> > Sorry about the top posting.
> > 
> > I did ask about it on the 9th of April and the reply was that the email
> > was 'acked'. Since I did not get a further email, I assumed it was lost.
> > Perhaps I misunderstood.
> 
> I really do not know, sorry.  If you didn't get an automated email from
> my system that it was applied, rebased it against the latest
> staging-next branch and resend it.
> 
> thanks,
> 
> greg k-h
> 

[toc] | [next] | [standalone]

#1630888

On Mon, Apr 24, 2017 at 11:20:22PM -0700, Chandra Annamaneni wrote:
> 
>     Change video.c to use %s, __func__ instead of function names.
>     Warnings flagged by checkpatch.pl
>     
>     Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>

Why is this indented?  Why is your subject a "Re:"?

[toc] | [prev] | [next] | [standalone]

#1631111

I assumed the email should be a reply to the previous email so it appears 
in the thread. As to the leading spaces, it was a problem with my mail 
client.

Ill resend the patch.

--
Chandra


On Tue, 25 Apr 2017, Greg KH wrote:

> On Mon, Apr 24, 2017 at 11:20:22PM -0700, Chandra Annamaneni wrote:
> > 
> >     Change video.c to use %s, __func__ instead of function names.
> >     Warnings flagged by checkpatch.pl
> >     
> >     Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
> 
> Why is this indented?  Why is your subject a "Re:"?
> 
> 

[toc] | [prev] | [next] | [standalone]

#1631121

On Tue, 2017-04-25 at 19:28 -0700, Chandra Annamaneni wrote:
> I assumed the email should be a reply to the previous email so it appears 
> in the thread. As to the leading spaces, it was a problem with my mail 
> client.
> 
> Ill resend the patch.

Did you read my suggestion to just delete these lines instead?

> --
> Chandra
> 
> 
> On Tue, 25 Apr 2017, Greg KH wrote:
> 
> > On Mon, Apr 24, 2017 at 11:20:22PM -0700, Chandra Annamaneni wrote:
> > > 
> > >     Change video.c to use %s, __func__ instead of function names.
> > >     Warnings flagged by checkpatch.pl
> > >     
> > >     Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
> > 
> > Why is this indented?  Why is your subject a "Re:"?
> > 
> > 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web