Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1630366 > unrolled thread
| Started by | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| First post | 2017-04-25 12:30 +0200 |
| Last post | 2017-04-26 03:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 3/4] zram: make deduplication feature optional Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-25 12:30 +0200
Re: [PATCH v3 3/4] zram: make deduplication feature optional Joonsoo Kim <js1304@gmail.com> - 2017-04-26 03:00 +0200
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Date | 2017-04-25 12:30 +0200 |
| Subject | Re: [PATCH v3 3/4] zram: make deduplication feature optional |
| Message-ID | <tA5Tk-3rD-3@gated-at.bofh.it> |
Hello,
On (04/21/17 10:14), js1304@gmail.com wrote:
[..]
> int zram_dedup_init(struct zram *zram, size_t num_pages);
> void zram_dedup_fini(struct zram *zram);
> +#else
> +
> +static inline u64 zram_dedup_dup_size(struct zram *zram) { return 0; }
> +static inline u64 zram_dedup_meta_size(struct zram *zram) { return 0; }
> +
> +static inline void zram_dedup_insert(struct zram *zram, struct zram_entry *new,
> + u32 checksum) { }
> +static inline struct zram_entry *zram_dedup_find(struct zram *zram,
> + struct page *page, u32 *checksum) { return NULL; }
> +
> +static inline void zram_dedup_init_entry(struct zram *zram,
> + struct zram_entry *entry, unsigned long handle,
> + unsigned int len) { }
> +static inline bool zram_dedup_put_entry(struct zram *zram,
> + struct zram_entry *entry) { return true; }
> +
> +static inline int zram_dedup_init(struct zram *zram,
> + size_t num_pages) { return 0; }
> +static inline void zram_dedup_fini(struct zram *zram) { }
> +
> +#endif
doesn't compile on CONFIG_ZRAM=m config.
-ss
[toc] | [next] | [standalone]
| From | Joonsoo Kim <js1304@gmail.com> |
|---|---|
| Date | 2017-04-26 03:00 +0200 |
| Message-ID | <tAjtf-3t4-11@gated-at.bofh.it> |
| In reply to | #1630366 |
2017-04-25 19:24 GMT+09:00 Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com>:
> Hello,
>
> On (04/21/17 10:14), js1304@gmail.com wrote:
> [..]
>> int zram_dedup_init(struct zram *zram, size_t num_pages);
>> void zram_dedup_fini(struct zram *zram);
>> +#else
>> +
>> +static inline u64 zram_dedup_dup_size(struct zram *zram) { return 0; }
>> +static inline u64 zram_dedup_meta_size(struct zram *zram) { return 0; }
>> +
>> +static inline void zram_dedup_insert(struct zram *zram, struct zram_entry *new,
>> + u32 checksum) { }
>> +static inline struct zram_entry *zram_dedup_find(struct zram *zram,
>> + struct page *page, u32 *checksum) { return NULL; }
>> +
>> +static inline void zram_dedup_init_entry(struct zram *zram,
>> + struct zram_entry *entry, unsigned long handle,
>> + unsigned int len) { }
>> +static inline bool zram_dedup_put_entry(struct zram *zram,
>> + struct zram_entry *entry) { return true; }
>> +
>> +static inline int zram_dedup_init(struct zram *zram,
>> + size_t num_pages) { return 0; }
>> +static inline void zram_dedup_fini(struct zram *zram) { }
>> +
>> +#endif
>
> doesn't compile on CONFIG_ZRAM=m config.
Hello,
Good catch!
I fixed it and sent update version, v4.
Thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web