Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1630952 > unrolled thread

[PATCH] usb: musb: don't mark of_dev_auxdata as initdata

Back to article view | Back to linux.kernel

Contents

  [PATCH] usb: musb: don't mark of_dev_auxdata as initdata Arnd Bergmann <arnd@arndb.de> - 2017-04-25 22:10 +0200
    Re: [PATCH] usb: musb: don't mark of_dev_auxdata as initdata Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-26 12:00 +0200

#1630952 — [PATCH] usb: musb: don't mark of_dev_auxdata as initdata

The probe function is not __init since it can be called for deferred
probing or when unbinding/rebinding the device, and therefore it must
not reference objects in __initdata, as pointed out by this link
time warning:

WARNING: drivers/usb/musb/da8xx.o(.text+0x9d4): Section mismatch in reference from the function da8xx_probe() to the (unknown reference) .init.data:(unknown)

This removes the annotation.

Reported-by: Olof's autobuilder <olof@lixom.net>
Fixes: d6299b6efbf6 ("usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/usb/musb/da8xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index 5a8a031485ea..df88123274ca 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -513,7 +513,7 @@ static const struct musb_hdrc_config da8xx_config = {
 	.multipoint = 1,
 };
 
-static struct of_dev_auxdata da8xx_auxdata_lookup[] __initdata = {
+static struct of_dev_auxdata da8xx_auxdata_lookup[] = {
 	OF_DEV_AUXDATA("ti,da830-cppi41", 0x01e01000, "cppi41-dmaengine",
 		       NULL),
 	{}
-- 
2.9.0

[toc] | [next] | [standalone]

#1631327

On Tue, Apr 25, 2017 at 10:04:53PM +0200, Arnd Bergmann wrote:
> The probe function is not __init since it can be called for deferred
> probing or when unbinding/rebinding the device, and therefore it must
> not reference objects in __initdata, as pointed out by this link
> time warning:
> 
> WARNING: drivers/usb/musb/da8xx.o(.text+0x9d4): Section mismatch in reference from the function da8xx_probe() to the (unknown reference) .init.data:(unknown)
> 
> This removes the annotation.
> 
> Reported-by: Olof's autobuilder <olof@lixom.net>
> Fixes: d6299b6efbf6 ("usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Now applied as I think Bin is offline for a bit.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web