Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632043 > unrolled thread
| Started by | Ankit Kumar <ankit@linux.vnet.ibm.com> |
|---|---|
| First post | 2017-04-27 13:40 +0200 |
| Last post | 2017-04-28 05:00 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] Enabled pstore write for powerpc Ankit Kumar <ankit@linux.vnet.ibm.com> - 2017-04-27 13:40 +0200
Re: [PATCH] Enabled pstore write for powerpc Anton Blanchard <anton@samba.org> - 2017-04-27 22:30 +0200
Re: [PATCH] Enabled pstore write for powerpc Kees Cook <keescook@chromium.org> - 2017-04-27 23:40 +0200
Re: [PATCH] Enabled pstore write for powerpc Michael Ellerman <mpe@ellerman.id.au> - 2017-04-28 05:00 +0200
| From | Ankit Kumar <ankit@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-04-27 13:40 +0200 |
| Subject | [PATCH] Enabled pstore write for powerpc |
| Message-ID | <tAPWa-8ku-15@gated-at.bofh.it> |
After commit c950fd6f201a kernel registers pstore write based on flag set.
Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG) is not set for
powerpc architecture. On panic, kernel doesn't write message to
/fs/pstore/dmesg*(Entry doesn't gets created at all).
This patch enables pstore write for powerpc architecture by setting
PSTORE_FLAGS_DMESG flag.
Fixes:c950fd6f201a pstore: Split pstore fragile flags
Signed-off-by: Ankit Kumar <ankit@linux.vnet.ibm.com>
---
arch/powerpc/kernel/nvram_64.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c
index d5e2b83..021db31 100644
--- a/arch/powerpc/kernel/nvram_64.c
+++ b/arch/powerpc/kernel/nvram_64.c
@@ -561,6 +561,7 @@ static ssize_t nvram_pstore_read(u64 *id, enum pstore_type_id *type,
static struct pstore_info nvram_pstore_info = {
.owner = THIS_MODULE,
.name = "nvram",
+ .flags = PSTORE_FLAGS_DMESG,
.open = nvram_pstore_open,
.read = nvram_pstore_read,
.write = nvram_pstore_write,
--
2.7.4
[toc] | [next] | [standalone]
| From | Anton Blanchard <anton@samba.org> |
|---|---|
| Date | 2017-04-27 22:30 +0200 |
| Message-ID | <tAYd4-5Fs-17@gated-at.bofh.it> |
| In reply to | #1632043 |
Hi Ankit,
> After commit c950fd6f201a kernel registers pstore write based on flag
> set. Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG)
> is not set for powerpc architecture. On panic, kernel doesn't write
> message to /fs/pstore/dmesg*(Entry doesn't gets created at all).
>
> This patch enables pstore write for powerpc architecture by setting
> PSTORE_FLAGS_DMESG flag.
>
> Fixes:c950fd6f201a pstore: Split pstore fragile flags
Ouch! We've used pstore to shoot customer bugs, so we should also mark
this for stable. Looks like 4.9 onwards?
Anton
> Signed-off-by: Ankit Kumar <ankit@linux.vnet.ibm.com>
> ---
>
> arch/powerpc/kernel/nvram_64.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kernel/nvram_64.c
> b/arch/powerpc/kernel/nvram_64.c index d5e2b83..021db31 100644
> --- a/arch/powerpc/kernel/nvram_64.c
> +++ b/arch/powerpc/kernel/nvram_64.c
> @@ -561,6 +561,7 @@ static ssize_t nvram_pstore_read(u64 *id, enum
> pstore_type_id *type, static struct pstore_info nvram_pstore_info = {
> .owner = THIS_MODULE,
> .name = "nvram",
> + .flags = PSTORE_FLAGS_DMESG,
> .open = nvram_pstore_open,
> .read = nvram_pstore_read,
> .write = nvram_pstore_write,
[toc] | [prev] | [next] | [standalone]
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2017-04-27 23:40 +0200 |
| Message-ID | <tAZiN-6s4-7@gated-at.bofh.it> |
| In reply to | #1632043 |
On Thu, Apr 27, 2017 at 4:33 AM, Ankit Kumar <ankit@linux.vnet.ibm.com> wrote:
> After commit c950fd6f201a kernel registers pstore write based on flag set.
> Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG) is not set for
> powerpc architecture. On panic, kernel doesn't write message to
> /fs/pstore/dmesg*(Entry doesn't gets created at all).
>
> This patch enables pstore write for powerpc architecture by setting
> PSTORE_FLAGS_DMESG flag.
>
> Fixes:c950fd6f201a pstore: Split pstore fragile flags
> Signed-off-by: Ankit Kumar <ankit@linux.vnet.ibm.com>
Argh, thanks! I thought I'd caught all of these. I'll include this for -stable.
-Kees
> ---
>
> arch/powerpc/kernel/nvram_64.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c
> index d5e2b83..021db31 100644
> --- a/arch/powerpc/kernel/nvram_64.c
> +++ b/arch/powerpc/kernel/nvram_64.c
> @@ -561,6 +561,7 @@ static ssize_t nvram_pstore_read(u64 *id, enum pstore_type_id *type,
> static struct pstore_info nvram_pstore_info = {
> .owner = THIS_MODULE,
> .name = "nvram",
> + .flags = PSTORE_FLAGS_DMESG,
> .open = nvram_pstore_open,
> .read = nvram_pstore_read,
> .write = nvram_pstore_write,
> --
> 2.7.4
>
--
Kees Cook
Pixel Security
[toc] | [prev] | [next] | [standalone]
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Date | 2017-04-28 05:00 +0200 |
| Message-ID | <tB4it-1kM-7@gated-at.bofh.it> |
| In reply to | #1632385 |
Kees Cook <keescook@chromium.org> writes: > On Thu, Apr 27, 2017 at 4:33 AM, Ankit Kumar <ankit@linux.vnet.ibm.com> wrote: >> After commit c950fd6f201a kernel registers pstore write based on flag set. >> Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG) is not set for >> powerpc architecture. On panic, kernel doesn't write message to >> /fs/pstore/dmesg*(Entry doesn't gets created at all). >> >> This patch enables pstore write for powerpc architecture by setting >> PSTORE_FLAGS_DMESG flag. >> >> Fixes:c950fd6f201a pstore: Split pstore fragile flags >> Signed-off-by: Ankit Kumar <ankit@linux.vnet.ibm.com> > > Argh, thanks! I thought I'd caught all of these. I'll include this for -stable. I see you've picked it up, thanks. cheers
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web