Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632174 > unrolled thread
| Started by | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| First post | 2017-04-27 17:30 +0200 |
| Last post | 2017-04-30 11:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH -next] irqchip/mbigen: Fix return value check in mbigen_device_probe() Wei Yongjun <weiyj.lk@gmail.com> - 2017-04-27 17:30 +0200
[tip:irq/core] irqchip/mbigen: Fix return value check in mbigen_device_probe() tip-bot for Wei Yongjun <tipbot@zytor.com> - 2017-04-30 11:50 +0200
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2017-04-27 17:30 +0200 |
| Subject | [PATCH -next] irqchip/mbigen: Fix return value check in mbigen_device_probe() |
| Message-ID | <tATwJ-2t3-5@gated-at.bofh.it> |
From: Wei Yongjun <weiyongjun1@huawei.com>
In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). Use devm_ioremap_resource() instead of devm_ioremap()
to fix the IS_ERR() test issue.
Fixes: 76e1f77f9c26 ("irqchip/mbigen: Introduce mbigen_of_create_domain()")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/irqchip/irq-mbigen.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
index 061cdb8..d2306c8 100644
--- a/drivers/irqchip/irq-mbigen.c
+++ b/drivers/irqchip/irq-mbigen.c
@@ -337,8 +337,7 @@ static int mbigen_device_probe(struct platform_device *pdev)
mgn_chip->pdev = pdev;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- mgn_chip->base = devm_ioremap(&pdev->dev, res->start,
- resource_size(res));
+ mgn_chip->base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(mgn_chip->base))
return PTR_ERR(mgn_chip->base);
[toc] | [next] | [standalone]
| From | tip-bot for Wei Yongjun <tipbot@zytor.com> |
|---|---|
| Date | 2017-04-30 11:50 +0200 |
| Subject | [tip:irq/core] irqchip/mbigen: Fix return value check in mbigen_device_probe() |
| Message-ID | <tBTEm-1xV-9@gated-at.bofh.it> |
| In reply to | #1632174 |
Commit-ID: 216646e4d82e847791f0ba66c439dedd36cb119f
Gitweb: http://git.kernel.org/tip/216646e4d82e847791f0ba66c439dedd36cb119f
Author: Wei Yongjun <weiyongjun1@huawei.com>
AuthorDate: Thu, 27 Apr 2017 15:21:13 +0000
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 30 Apr 2017 11:21:16 +0200
irqchip/mbigen: Fix return value check in mbigen_device_probe()
In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). Use devm_ioremap_resource() instead of devm_ioremap()
to fix the IS_ERR() test issue.
Fixes: 76e1f77f9c26 ("irqchip/mbigen: Introduce mbigen_of_create_domain()")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/20170427152113.31147-1-weiyj.lk@gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-mbigen.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
index 061cdb8..d2306c8 100644
--- a/drivers/irqchip/irq-mbigen.c
+++ b/drivers/irqchip/irq-mbigen.c
@@ -337,8 +337,7 @@ static int mbigen_device_probe(struct platform_device *pdev)
mgn_chip->pdev = pdev;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- mgn_chip->base = devm_ioremap(&pdev->dev, res->start,
- resource_size(res));
+ mgn_chip->base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(mgn_chip->base))
return PTR_ERR(mgn_chip->base);
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web