Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632153 > unrolled thread
| Started by | Geoff Lansberry <geoff@kuvee.com> |
|---|---|
| First post | 2017-04-27 16:50 +0200 |
| Last post | 2017-04-27 19:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v3] NFC: trf7970a: Correct register settings for 27MHz clock Geoff Lansberry <geoff@kuvee.com> - 2017-04-27 16:50 +0200
Re: [PATCH v3] NFC: trf7970a: Correct register settings for 27MHz clock Mark Greer <mgreer@animalcreek.com> - 2017-04-27 19:20 +0200
| From | Geoff Lansberry <geoff@kuvee.com> |
|---|---|
| Date | 2017-04-27 16:50 +0200 |
| Subject | [PATCH v3] NFC: trf7970a: Correct register settings for 27MHz clock |
| Message-ID | <tASU2-1Wr-17@gated-at.bofh.it> |
In prior commits the selected clock frequency does not propagate
correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL
register.
Signed-off-by: Geoff Lansberry <geoff@kuvee.com>
---
drivers/nfc/trf7970a.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
index 6ed5d7e..f7fee7d 100644
--- a/drivers/nfc/trf7970a.c
+++ b/drivers/nfc/trf7970a.c
@@ -2067,6 +2067,13 @@ static int trf7970a_probe(struct spi_device *spi)
return -EINVAL;
}
+ if (clk_freq == TRF7970A_27MHZ_CLOCK_FREQUENCY) {
+ trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_27MHZ;
+ dev_dbg(trf->dev, "trf7970a configured for 27MHz crystal\n");
+ } else {
+ trf->modulator_sys_clk_ctrl = 0;
+ }
+
ret = devm_request_threaded_irq(trf->dev, spi->irq, NULL,
trf7970a_irq,
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
--
2.7.4
[toc] | [next] | [standalone]
| From | Mark Greer <mgreer@animalcreek.com> |
|---|---|
| Date | 2017-04-27 19:20 +0200 |
| Subject | Re: [PATCH v3] NFC: trf7970a: Correct register settings for 27MHz clock |
| Message-ID | <tAVfb-3DH-9@gated-at.bofh.it> |
| In reply to | #1632153 |
On Thu, Apr 27, 2017 at 10:41:59AM -0400, Geoff Lansberry wrote:
> In prior commits the selected clock frequency does not propagate
> correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL
^^^^^^^
s/the the/to the/
> register.
>
> Signed-off-by: Geoff Lansberry <geoff@kuvee.com>
> ---
> drivers/nfc/trf7970a.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
> index 6ed5d7e..f7fee7d 100644
> --- a/drivers/nfc/trf7970a.c
> +++ b/drivers/nfc/trf7970a.c
> @@ -2067,6 +2067,13 @@ static int trf7970a_probe(struct spi_device *spi)
> return -EINVAL;
> }
>
> + if (clk_freq == TRF7970A_27MHZ_CLOCK_FREQUENCY) {
> + trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_27MHZ;
> + dev_dbg(trf->dev, "trf7970a configured for 27MHz crystal\n");
> + } else {
> + trf->modulator_sys_clk_ctrl = 0;
> + }
> +
> ret = devm_request_threaded_irq(trf->dev, spi->irq, NULL,
> trf7970a_irq,
> IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> --
> 2.7.4
With the suggested fix above:
Acked-by: Mark Greer <mgreer@animalcreek.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web