Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632113 > unrolled thread
| Started by | David Howells <dhowells@redhat.com> |
|---|---|
| First post | 2017-04-27 16:00 +0200 |
| Last post | 2017-04-28 17:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage David Howells <dhowells@redhat.com> - 2017-04-27 16:00 +0200
Re: [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com> - 2017-04-27 21:10 +0200
Re: [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage David Howells <dhowells@redhat.com> - 2017-04-28 17:50 +0200
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2017-04-27 16:00 +0200 |
| Subject | Re: [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage |
| Message-ID | <tAS7D-1ly-7@gated-at.bofh.it> |
Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com> wrote: > + /* TODO: update CRC */ Is this bit missing? David
[toc] | [next] | [standalone]
| From | Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-04-27 21:10 +0200 |
| Subject | Re: [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage |
| Message-ID | <tAWXE-4TO-13@gated-at.bofh.it> |
| In reply to | #1632113 |
> On Apr 27, 2017, at 9:54 AM, David Howells <dhowells@redhat.com> wrote: > > Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com> wrote: > >> + /* TODO: update CRC */ > > Is this bit missing? I didn't add it, since I wasn't sure it was still used with secure boot. The CRC code is implemented in multiple places, but not exposed to the tools/scripts. Should I make the crc32() in tools/pcmcia/crc32hash.c non-static, maybe? Mehmet
[toc] | [prev] | [next] | [standalone]
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2017-04-28 17:50 +0200 |
| Message-ID | <tBgjD-Uv-15@gated-at.bofh.it> |
| In reply to | #1632338 |
Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com> wrote: > >> + /* TODO: update CRC */ > > > > Is this bit missing? > > I didn't add it, since I wasn't sure it was still used with secure boot. I'm not sure why secure boot would skip it if normal boot does it. You'll have to trawl the boot wrapper and kernel arch setup code to answer that one. > The CRC code is implemented in multiple places, but not exposed to the > tools/scripts. Should I make the crc32() in tools/pcmcia/crc32hash.c > non-static, maybe? Making it non-static won't help since it's a standalone program. You could just shift it to scripts or something. David
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web