Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1631818 > unrolled thread

linux-next: build warning after merge of the sound-asoc tree

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2017-04-27 03:30 +0200
Last post2017-04-27 04:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  linux-next: build warning after merge of the sound-asoc tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-27 03:30 +0200
    Re: linux-next: build warning after merge of the sound-asoc tree Vinod Koul <vinod.koul@intel.com> - 2017-04-27 04:30 +0200

#1631818 — linux-next: build warning after merge of the sound-asoc tree

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2017-04-27 03:30 +0200
Subjectlinux-next: build warning after merge of the sound-asoc tree
Message-ID<tAGpP-1Uc-3@gated-at.bofh.it>
Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init':
sound/soc/intel/skylake/bxt-sst.c:567:14: warning: 'skl' may be used uninitialized in this function [-Wmaybe-uninitialized]
   dev_err(skl->dev, "%s: no device\n", __func__);
              ^

Introduced by commit

  9fe9c7119283 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function")

This looks like an actual bug ...

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]


#1631830

FromVinod Koul <vinod.koul@intel.com>
Date2017-04-27 04:30 +0200
Message-ID<tAHlT-2zN-3@gated-at.bofh.it>
In reply to#1631818
On Thu, Apr 27, 2017 at 11:29:20AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init':
> sound/soc/intel/skylake/bxt-sst.c:567:14: warning: 'skl' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    dev_err(skl->dev, "%s: no device\n", __func__);
>               ^
> 

Yeah looks like that is the case, fortunately fix is quite simple, I will
send out soon

Thanks for reporting

> Introduced by commit
> 
>   9fe9c7119283 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function")
> 
> This looks like an actual bug ...
> 
> -- 
> Cheers,
> Stephen Rothwell

-- 
~Vinod

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web