Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629800 > unrolled thread

[PATCH] scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static

Back to article view | Back to linux.kernel

Contents

  [PATCH] scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static Colin King <colin.king@canonical.com> - 2017-04-24 19:10 +0200
    Re: [PATCH] scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-25 09:10 +0200
    Re: [PATCH] scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-04-25 19:00 +0200

#1629800 — [PATCH] scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static

From: Colin Ian King <colin.king@canonical.com>

These module parameter variables don't need global scope, make them static

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/fcoe/fcoe.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index ab7bc1505e0b..90939f66bc0d 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -63,11 +63,11 @@ unsigned int fcoe_debug_logging;
 module_param_named(debug_logging, fcoe_debug_logging, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(debug_logging, "a bit mask of logging levels");
 
-unsigned int fcoe_e_d_tov = 2 * 1000;
+static unsigned int fcoe_e_d_tov = 2 * 1000;
 module_param_named(e_d_tov, fcoe_e_d_tov, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(e_d_tov, "E_D_TOV in ms, default 2000");
 
-unsigned int fcoe_r_a_tov = 2 * 2 * 1000;
+static unsigned int fcoe_r_a_tov = 2 * 2 * 1000;
 module_param_named(r_a_tov, fcoe_r_a_tov, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(r_a_tov, "R_A_TOV in ms, default 4000");
 
-- 
2.11.0

[toc] | [next] | [standalone]

#1630237

On Mon, Apr 24, 2017 at 06:04:18PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> These module parameter variables don't need global scope, make them static
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---

Looks good,
Acked-by: Johannes Thumshirn <jth@kernel.org>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[toc] | [prev] | [next] | [standalone]

#1630793

Colin,

> These module parameter variables don't need global scope, make them
> static

Applied to 4.12/scsi-queue. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web