Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577540 > unrolled thread

[PATCH] staging: rtl8192u: Removing multiple blank lines

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: rtl8192u: Removing multiple blank lines simran singhal <singhalsimran0@gmail.com> - 2017-02-09 13:40 +0100
    Re: [PATCH] staging: rtl8192u: Removing multiple blank lines Greg KH <gregkh@linuxfoundation.org> - 2017-02-10 15:10 +0100
      Re: [PATCH] staging: rtl8192u: Removing multiple blank lines SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-02-11 05:10 +0100
        Re: [PATCH] staging: rtl8192u: Removing multiple blank lines Greg KH <gregkh@linuxfoundation.org> - 2017-02-11 08:10 +0100

#1577540 — [PATCH] staging: rtl8192u: Removing multiple blank lines

This patch fixes the checkpatch warning by removing multiple blank
lines.
CHECK: Please don't use multiple blank lines

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
index 2dc25cc..0ddd5ac 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
@@ -90,7 +90,6 @@ static void *ieee80211_ccmp_init(int key_idx)
 	return NULL;
 }
 
-
 static void ieee80211_ccmp_deinit(void *priv)
 {
 	struct ieee80211_ccmp_data *_priv = priv;
@@ -100,7 +99,6 @@ static void ieee80211_ccmp_deinit(void *priv)
 	kfree(priv);
 }
 
-
 static inline void xor_block(u8 *b, u8 *a, size_t len)
 {
 	int i;
@@ -109,8 +107,6 @@ static inline void xor_block(u8 *b, u8 *a, size_t len)
 		b[i] ^= a[i];
 }
 
-
-
 static void ccmp_init_blocks(struct crypto_tfm *tfm,
 			     struct rtl_80211_hdr_4addr *hdr,
 			     u8 *pn, size_t dlen, u8 *b0, u8 *auth,
@@ -189,8 +185,6 @@ static void ccmp_init_blocks(struct crypto_tfm *tfm,
 	ieee80211_ccmp_aes_encrypt(tfm, b0, s0);
 }
 
-
-
 static int ieee80211_ccmp_encrypt(struct sk_buff *skb, int hdr_len, void *priv)
 {
 	struct ieee80211_ccmp_data *key = priv;
@@ -227,7 +221,6 @@ static int ieee80211_ccmp_encrypt(struct sk_buff *skb, int hdr_len, void *priv)
 	*pos++ = key->tx_pn[1];
 	*pos++ = key->tx_pn[0];
 
-
 	hdr = (struct rtl_80211_hdr_4addr *) skb->data;
 	if (!tcb_desc->bHwSec) {
 		int blocks, last, len;
@@ -264,7 +257,6 @@ static int ieee80211_ccmp_encrypt(struct sk_buff *skb, int hdr_len, void *priv)
 	return 0;
 }
 
-
 static int ieee80211_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
 {
 	struct ieee80211_ccmp_data *key = priv;
@@ -327,7 +319,6 @@ static int ieee80211_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
 		u8 *a = key->rx_a;
 		int i, blocks, last, len;
 
-
 		ccmp_init_blocks(key->tfm, hdr, pn, data_len, b0, a, b);
 		xor_block(mic, b, CCMP_MIC_LEN);
 
@@ -366,7 +357,6 @@ static int ieee80211_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
 	return keyidx;
 }
 
-
 static int ieee80211_ccmp_set_key(void *key, int len, u8 *seq, void *priv)
 {
 	struct ieee80211_ccmp_data *data = priv;
@@ -397,7 +387,6 @@ static int ieee80211_ccmp_set_key(void *key, int len, u8 *seq, void *priv)
 	return 0;
 }
 
-
 static int ieee80211_ccmp_get_key(void *key, int len, u8 *seq, void *priv)
 {
 	struct ieee80211_ccmp_data *data = priv;
@@ -421,7 +410,6 @@ static int ieee80211_ccmp_get_key(void *key, int len, u8 *seq, void *priv)
 	return CCMP_TK_LEN;
 }
 
-
 static char *ieee80211_ccmp_print_stats(char *p, void *priv)
 {
 	struct ieee80211_ccmp_data *ccmp = priv;
-- 
2.7.4

[toc] | [next] | [standalone]

#1578474

On Thu, Feb 09, 2017 at 06:02:12PM +0530, simran singhal wrote:
> This patch fixes the checkpatch warning by removing multiple blank
> lines.
> CHECK: Please don't use multiple blank lines
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 12 ------------
>  1 file changed, 12 deletions(-)

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You sent multiple patches, yet no indication of which ones should be
  applied in which order.  Greg could just guess, but if you are
  receiving this email, he guessed wrong and the patches didn't apply.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for a description of how
  to do this so that Greg has a chance to apply these correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[toc] | [prev] | [next] | [standalone]

#1578930

Multiple patches ...?
Can you please clarify what all patches you are including in "Multiple Patches".

And the Order you should go for is the order in which I submitted them.

On Sat, Feb 11, 2017 at 7:48 AM, SIMRAN SINGHAL
<singhalsimran0@gmail.com> wrote:
> Multiple patches ...?
> Can you please clarify what all patches you are including in "Multiple
> Patches".
>
> And the Order you should go for is the order in which I submitted them.
>
> On Feb 10, 2017 19:34, "Greg KH" <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Feb 09, 2017 at 06:02:12PM +0530, simran singhal wrote:
>> This patch fixes the checkpatch warning by removing multiple blank
>> lines.
>> CHECK: Please don't use multiple blank lines
>>
>> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
>> ---
>>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 12
>> ------------
>>  1 file changed, 12 deletions(-)
>
> Hi,
>
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> a patch that has triggered this response.  He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created.  Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
>
> You are receiving this message because of the following common error(s)
> as indicated below:
>
> - You sent multiple patches, yet no indication of which ones should be
>   applied in which order.  Greg could just guess, but if you are
>   receiving this email, he guessed wrong and the patches didn't apply.
>   Please read the section entitled "The canonical patch format" in the
>   kernel file, Documentation/SubmittingPatches for a description of how
>   to do this so that Greg has a chance to apply these correctly.
>
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
>
> thanks,
>
> greg k-h's patch email bot
>
>

[toc] | [prev] | [next] | [standalone]

#1578944

On Sat, Feb 11, 2017 at 09:34:12AM +0530, SIMRAN SINGHAL wrote:
> Multiple patches ...?

You sent me lots of patches, how am I supposed to know which one to
apply in what order?

> Can you please clarify what all patches you are including in "Multiple Patches".

Everything you have sent me.

> And the Order you should go for is the order in which I submitted them.

Email does not guarantee "in order" delivery at all.  And how do you
know how my emails are sorted?  That is why you are supposed to number
your patches.  Please read Documentation/SubmittingPatches for how to do
this properly.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web