Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1578935 > unrolled thread

Mistake in include IS_ENABLED(CONFIG_LIVEPATCH)

Back to article view | Back to linux.kernel

Contents

  Mistake in include IS_ENABLED(CONFIG_LIVEPATCH) Denys Fedoryshchenko <nuclearcat@nuclearcat.com> - 2017-02-11 06:20 +0100
    Re: Mistake in include IS_ENABLED(CONFIG_LIVEPATCH) Jiri Kosina <jikos@kernel.org> - 2017-02-11 09:00 +0100

#1578935 — Mistake in include IS_ENABLED(CONFIG_LIVEPATCH)

Hello,

I noticed that sample of livepatch is not working in 4.9.9, because in 
include,
linux/livepatch.h
it is:
#if IS_ENABLED(CONFIG_LIVEPATCH)

while config option is:
CONFIG_HAVE_LIVEPATCH=y

After editing livepatch.h sample module compiles fine

Probably that's just a typo?

[toc] | [next] | [standalone]

#1578952

On Sat, 11 Feb 2017, Denys Fedoryshchenko wrote:

> I noticed that sample of livepatch is not working in 4.9.9, because in
> include,
> linux/livepatch.h
> it is:
> #if IS_ENABLED(CONFIG_LIVEPATCH)
> 
> while config option is:
> CONFIG_HAVE_LIVEPATCH=y
> 
> After editing livepatch.h sample module compiles fine
> 
> Probably that's just a typo?

There are two config variables. CONFIG_HAVE_LIVEPATCH is set by those 
architectures for which livepatching implementation exists.

CONFIG_LIVEPATCH is the actual config option turning the support in kernel 
on/off.

What you are seeing is that if you have kernel configuration that has 
livepatching (CONFIG_LIVEPATCH) turned off, the sample module doesn't 
compile for it either. I'd say it's not unexpected behavior.

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web