Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1578846 > unrolled thread

[PATCH] Staging: media: bcm2048: Fixed an error

Back to article view | Back to linux.kernel

Contents

  [PATCH] Staging: media: bcm2048: Fixed an error Ran Algawi <ran.algawi@gmail.com> - 2017-02-10 23:50 +0100
    Re: [PATCH] Staging: media: bcm2048: Fixed an error Greg KH <gregkh@linuxfoundation.org> - 2017-02-12 13:20 +0100
      Re: [PATCH] Staging: media: bcm2048: Fixed an error Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-12 22:30 +0100
      Re: [PATCH] Staging: media: bcm2048: Fixed an error Ran Algawi <ran.algawi@gmail.com> - 2017-02-12 22:30 +0100

#1578846 — [PATCH] Staging: media: bcm2048: Fixed an error

Fixed an error where the system was given a code in the form of decimal
instead of octal.

Signed-off-by: Ran Algawi <ran.algawi@gmail.com>
---
 drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 37bd439..d605c41 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -300,7 +300,7 @@ struct bcm2048_device {
 };
 
 static int radio_nr = -1;	/* radio device minor (-1 ==> auto assign) */
-module_param(radio_nr, int, 0);
+module_param(radio_nr, int, 0000);
 MODULE_PARM_DESC(radio_nr,
 		 "Minor number for radio device (-1 ==> auto assign)");
 
-- 
2.7.4

[toc] | [next] | [standalone]

#1579205

On Sat, Feb 11, 2017 at 12:41:29AM +0200, Ran Algawi wrote:
> Fixed an error where the system was given a code in the form of decimal
> instead of octal.

It's not really an "error", right?  Please be more descriptive of
exactly what is going on here (hint, it's a coding style warning...)

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1579290

On Sun, Feb 12, 2017 at 11:12:42PM +0200, Ran Algawi wrote:
> Hello Greg,
> First, I appreciate you taking the time to educate me. I used the checkpatch
> script on the file I fixed and he reported the line as an error. Do you
> consider all checkpatch warnings/error/checks as coding style fixes?

The ones that refer to coding style issues, yes, that is what they are.
Sometimes the script points out other things that should be changed,
like octal values which is not an error in this case, but rather a
clarification.

And please turn html off in your email client, it gets rejected by the
mailing lists :)

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1579291

Hello Greg,
I apperaciate you taking the time to educate me.
Do you consider all checkpatch errors/warnnings/checks as code style
fixes?
With regards,
Ran A.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web