Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577567 > unrolled thread

[PATCH] mm: testcases for RODATA: fix config dependency

Back to article view | Back to linux.kernel

Contents

  [PATCH] mm: testcases for RODATA: fix config dependency Jinbum Park <jinb.park7@gmail.com> - 2017-02-09 14:30 +0100
    Re: [PATCH] mm: testcases for RODATA: fix config dependency Kees Cook <keescook@chromium.org> - 2017-02-11 00:40 +0100

#1577567 — [PATCH] mm: testcases for RODATA: fix config dependency

Since DEBUG_RODATA has renamed to STRICT_KERNEL_RWX,
Fix the config dependency.

Reported-by: Valentin Rothberg <valentinrothberg@gmail.com>
Signed-off-by: Jinbum Park <jinb.park7@gmail.com>
---
 mm/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
index 3e5eada..3c88b7e 100644
--- a/mm/Kconfig.debug
+++ b/mm/Kconfig.debug
@@ -93,7 +93,7 @@ config DEBUG_PAGE_REF
 
 config DEBUG_RODATA_TEST
     bool "Testcase for the marking rodata read-only"
-    depends on DEBUG_RODATA
+    depends on STRICT_KERNEL_RWX
     ---help---
       This option enables a testcase for the setting rodata read-only.
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1578858

On Thu, Feb 9, 2017 at 5:16 AM, Jinbum Park <jinb.park7@gmail.com> wrote:
> Since DEBUG_RODATA has renamed to STRICT_KERNEL_RWX,
> Fix the config dependency.
>
> Reported-by: Valentin Rothberg <valentinrothberg@gmail.com>
> Signed-off-by: Jinbum Park <jinb.park7@gmail.com>
> ---
>  mm/Kconfig.debug | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
> index 3e5eada..3c88b7e 100644
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> @@ -93,7 +93,7 @@ config DEBUG_PAGE_REF
>
>  config DEBUG_RODATA_TEST
>      bool "Testcase for the marking rodata read-only"
> -    depends on DEBUG_RODATA
> +    depends on STRICT_KERNEL_RWX
>      ---help---
>        This option enables a testcase for the setting rodata read-only.

Great, thanks!

Acked-by: Kees Cook <keescook@chromium.org>

Andrew, do you want to take this patch, since it applies on top of
"mm: add arch-independent testcases for RODATA", or do you want me to
take both patches into my KSPP tree which has the DEBUG_RODATA ->
STRICT_KERNEL_RWX renaming series?

-Kees

-- 
Kees Cook
Pixel Security

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web