Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1576696 > unrolled thread
| Started by | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| First post | 2017-02-08 17:40 +0100 |
| Last post | 2017-02-10 20:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH -next] mtd: aspeed: remove redundant dev_err call in aspeed_smc_probe() Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-08 17:40 +0100
Re: [PATCH -next] mtd: aspeed: remove redundant dev_err call in aspeed_smc_probe() Marek Vasut <marek.vasut@gmail.com> - 2017-02-09 10:00 +0100
Re: [PATCH -next] mtd: aspeed: remove redundant dev_err call in aspeed_smc_probe() Brian Norris <computersforpeace@gmail.com> - 2017-02-10 20:30 +0100
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2017-02-08 17:40 +0100 |
| Subject | [PATCH -next] mtd: aspeed: remove redundant dev_err call in aspeed_smc_probe() |
| Message-ID | <t8DrI-2DS-21@gated-at.bofh.it> |
From: Wei Yongjun <weiyongjun1@huawei.com>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mtd/spi-nor/aspeed-smc.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
index 7c86099..56051d3 100644
--- a/drivers/mtd/spi-nor/aspeed-smc.c
+++ b/drivers/mtd/spi-nor/aspeed-smc.c
@@ -723,17 +723,13 @@ static int aspeed_smc_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
controller->regs = devm_ioremap_resource(dev, res);
- if (IS_ERR(controller->regs)) {
- dev_err(dev, "Cannot remap controller address.\n");
+ if (IS_ERR(controller->regs))
return PTR_ERR(controller->regs);
- }
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
controller->ahb_base = devm_ioremap_resource(dev, res);
- if (IS_ERR(controller->ahb_base)) {
- dev_err(dev, "Cannot remap controller address.\n");
+ if (IS_ERR(controller->ahb_base))
return PTR_ERR(controller->ahb_base);
- }
ret = aspeed_smc_setup_flash(controller, np, res);
if (ret)
[toc] | [next] | [standalone]
| From | Marek Vasut <marek.vasut@gmail.com> |
|---|---|
| Date | 2017-02-09 10:00 +0100 |
| Subject | Re: [PATCH -next] mtd: aspeed: remove redundant dev_err call in aspeed_smc_probe() |
| Message-ID | <t8SK5-3XY-1@gated-at.bofh.it> |
| In reply to | #1576696 |
On 02/08/2017 05:23 PM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> drivers/mtd/spi-nor/aspeed-smc.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
> index 7c86099..56051d3 100644
> --- a/drivers/mtd/spi-nor/aspeed-smc.c
> +++ b/drivers/mtd/spi-nor/aspeed-smc.c
> @@ -723,17 +723,13 @@ static int aspeed_smc_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> controller->regs = devm_ioremap_resource(dev, res);
> - if (IS_ERR(controller->regs)) {
> - dev_err(dev, "Cannot remap controller address.\n");
> + if (IS_ERR(controller->regs))
> return PTR_ERR(controller->regs);
> - }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> controller->ahb_base = devm_ioremap_resource(dev, res);
> - if (IS_ERR(controller->ahb_base)) {
> - dev_err(dev, "Cannot remap controller address.\n");
> + if (IS_ERR(controller->ahb_base))
> return PTR_ERR(controller->ahb_base);
> - }
>
> ret = aspeed_smc_setup_flash(controller, np, res);
> if (ret)
>
>
>
--
Best regards,
Marek Vasut
[toc] | [prev] | [next] | [standalone]
| From | Brian Norris <computersforpeace@gmail.com> |
|---|---|
| Date | 2017-02-10 20:30 +0100 |
| Subject | Re: [PATCH -next] mtd: aspeed: remove redundant dev_err call in aspeed_smc_probe() |
| Message-ID | <t9p3j-7EV-5@gated-at.bofh.it> |
| In reply to | #1577381 |
On Thu, Feb 09, 2017 at 09:50:23AM +0100, Marek Vasut wrote: > On 02/08/2017 05:23 PM, Wei Yongjun wrote: > > From: Wei Yongjun <weiyongjun1@huawei.com> > > > > There is a error message within devm_ioremap_resource > > already, so remove the dev_err call to avoid redundant > > error message. > > > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > Reviewed-by: Marek Vasut <marek.vasut@gmail.com> The driver is new for 4.11, so I'll just take this now, directly. Applied to l2-mtd.git.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web