Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1577633 > unrolled thread
| Started by | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| First post | 2017-02-09 15:20 +0100 |
| Last post | 2017-02-10 20:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] net: ethernet: ti: netcp_core: remove netif_trans_update Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2017-02-09 15:20 +0100
Re: [PATCH] net: ethernet: ti: netcp_core: remove netif_trans_update David Miller <davem@davemloft.net> - 2017-02-10 20:00 +0100
| From | Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> |
|---|---|
| Date | 2017-02-09 15:20 +0100 |
| Subject | [PATCH] net: ethernet: ti: netcp_core: remove netif_trans_update |
| Message-ID | <t8XJL-7cN-17@gated-at.bofh.it> |
No need to update jiffies in txq->trans_start twice and only for tx 0,
it's supposed to be done in netdev_start_xmit() and per tx queue.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
Based on net-next/master
drivers/net/ethernet/ti/netcp_core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index ebab1473..7c7ae08 100644
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -1316,8 +1316,6 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev)
if (ret)
goto drop;
- netif_trans_update(ndev);
-
/* Check Tx pool count & stop subqueue if needed */
desc_count = knav_pool_count(netcp->tx_pool);
if (desc_count < netcp->tx_pause_threshold) {
--
2.7.4
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-02-10 20:00 +0100 |
| Subject | Re: [PATCH] net: ethernet: ti: netcp_core: remove netif_trans_update |
| Message-ID | <t9oAj-7fF-35@gated-at.bofh.it> |
| In reply to | #1577633 |
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> Date: Thu, 9 Feb 2017 16:17:40 +0200 > No need to update jiffies in txq->trans_start twice and only for tx 0, > it's supposed to be done in netdev_start_xmit() and per tx queue. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > --- > Based on net-next/master Applied, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web