Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1578562 > unrolled thread
| Started by | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| First post | 2017-02-10 16:50 +0100 |
| Last post | 2017-02-10 20:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] media: s5p_mfc print buf pointer in hex constistently Shuah Khan <shuahkh@osg.samsung.com> - 2017-02-10 16:50 +0100
Re: [PATCH v2] media: s5p_mfc print buf pointer in hex constistently Joe Perches <joe@perches.com> - 2017-02-10 20:00 +0100
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2017-02-10 16:50 +0100 |
| Subject | [PATCH v2] media: s5p_mfc print buf pointer in hex constistently |
| Message-ID | <t9lCp-5i1-3@gated-at.bofh.it> |
Fix s5p_mfc_set_dec_frame_buffer_v6() to print buffer pointer in hex to be
consistent with the rest of the messages in the routine.
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
Fixed commit log. No code changes. Thanks for the catch.
drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
index d6f207e..fc45980 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
@@ -497,7 +497,7 @@ static int s5p_mfc_set_dec_frame_buffer_v6(struct s5p_mfc_ctx *ctx)
}
}
- mfc_debug(2, "Buf1: %zu, buf_size1: %d (frames %d)\n",
+ mfc_debug(2, "Buf1: %zx, buf_size1: %d (frames %d)\n",
buf_addr1, buf_size1, ctx->total_dpb_count);
if (buf_size1 < 0) {
mfc_debug(2, "Not enough memory has been allocated.\n");
--
2.7.4
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-10 20:00 +0100 |
| Message-ID | <t9oAi-7fF-19@gated-at.bofh.it> |
| In reply to | #1578562 |
On Fri, 2017-02-10 at 08:40 -0700, Shuah Khan wrote:
> Fix s5p_mfc_set_dec_frame_buffer_v6() to print buffer pointer in hex to be
> consistent with the rest of the messages in the routine.
More curiously, why is buf_addr a size_t and not
a dma_addr_t?
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>
> Fixed commit log. No code changes. Thanks for the catch.
>
> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> index d6f207e..fc45980 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> @@ -497,7 +497,7 @@ static int s5p_mfc_set_dec_frame_buffer_v6(struct s5p_mfc_ctx *ctx)
> }
> }
>
> - mfc_debug(2, "Buf1: %zu, buf_size1: %d (frames %d)\n",
> + mfc_debug(2, "Buf1: %zx, buf_size1: %d (frames %d)\n",
> buf_addr1, buf_size1, ctx->total_dpb_count);
> if (buf_size1 < 0) {
> mfc_debug(2, "Not enough memory has been allocated.\n");
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web