Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1578318 > unrolled thread
| Started by | André Draszik <git@andred.net> |
|---|---|
| First post | 2017-02-10 10:10 +0100 |
| Last post | 2017-02-10 18:10 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] MIPS: ralink: fix mt7628 alternative functions names André Draszik <git@andred.net> - 2017-02-10 10:10 +0100
Re: [PATCH] MIPS: ralink: fix mt7628 alternative functions names John Crispin <john@phrozen.org> - 2017-02-10 10:20 +0100
Re: [PATCH] MIPS: ralink: fix mt7628 alternative functions names James Hogan <james.hogan@imgtec.com> - 2017-02-10 18:10 +0100
| From | André Draszik <git@andred.net> |
|---|---|
| Date | 2017-02-10 10:10 +0100 |
| Subject | [PATCH] MIPS: ralink: fix mt7628 alternative functions names |
| Message-ID | <t9fnk-1qo-21@gated-at.bofh.it> |
They're all referenced as utif in the datasheet, not util.
Fixes: 53263a1c6852 ("MIPS: ralink: add mt7628an support")
Fixes: 2b436a351803 ("MIPS: ralink: add MT7628 EPHY LEDs pinmux support")
Signed-off-by: André Draszik <git@andred.net>
---
arch/mips/ralink/mt7620.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
index 3c7c9bf57bf3..6f892c1f3ad7 100644
--- a/arch/mips/ralink/mt7620.c
+++ b/arch/mips/ralink/mt7620.c
@@ -176,7 +176,7 @@ static struct rt2880_pmx_func spi_cs1_grp_mt7628[] = {
static struct rt2880_pmx_func spis_grp_mt7628[] = {
FUNC("pwm_uart2", 3, 14, 4),
- FUNC("util", 2, 14, 4),
+ FUNC("utif", 2, 14, 4),
FUNC("gpio", 1, 14, 4),
FUNC("spis", 0, 14, 4),
};
@@ -190,28 +190,28 @@ static struct rt2880_pmx_func gpio_grp_mt7628[] = {
static struct rt2880_pmx_func p4led_kn_grp_mt7628[] = {
FUNC("jtag", 3, 30, 1),
- FUNC("util", 2, 30, 1),
+ FUNC("utif", 2, 30, 1),
FUNC("gpio", 1, 30, 1),
FUNC("p4led_kn", 0, 30, 1),
};
static struct rt2880_pmx_func p3led_kn_grp_mt7628[] = {
FUNC("jtag", 3, 31, 1),
- FUNC("util", 2, 31, 1),
+ FUNC("utif", 2, 31, 1),
FUNC("gpio", 1, 31, 1),
FUNC("p3led_kn", 0, 31, 1),
};
static struct rt2880_pmx_func p2led_kn_grp_mt7628[] = {
FUNC("jtag", 3, 32, 1),
- FUNC("util", 2, 32, 1),
+ FUNC("utif", 2, 32, 1),
FUNC("gpio", 1, 32, 1),
FUNC("p2led_kn", 0, 32, 1),
};
static struct rt2880_pmx_func p1led_kn_grp_mt7628[] = {
FUNC("jtag", 3, 33, 1),
- FUNC("util", 2, 33, 1),
+ FUNC("utif", 2, 33, 1),
FUNC("gpio", 1, 33, 1),
FUNC("p1led_kn", 0, 33, 1),
};
@@ -232,28 +232,28 @@ static struct rt2880_pmx_func wled_kn_grp_mt7628[] = {
static struct rt2880_pmx_func p4led_an_grp_mt7628[] = {
FUNC("jtag", 3, 39, 1),
- FUNC("util", 2, 39, 1),
+ FUNC("utif", 2, 39, 1),
FUNC("gpio", 1, 39, 1),
FUNC("p4led_an", 0, 39, 1),
};
static struct rt2880_pmx_func p3led_an_grp_mt7628[] = {
FUNC("jtag", 3, 40, 1),
- FUNC("util", 2, 40, 1),
+ FUNC("utif", 2, 40, 1),
FUNC("gpio", 1, 40, 1),
FUNC("p3led_an", 0, 40, 1),
};
static struct rt2880_pmx_func p2led_an_grp_mt7628[] = {
FUNC("jtag", 3, 41, 1),
- FUNC("util", 2, 41, 1),
+ FUNC("utif", 2, 41, 1),
FUNC("gpio", 1, 41, 1),
FUNC("p2led_an", 0, 41, 1),
};
static struct rt2880_pmx_func p1led_an_grp_mt7628[] = {
FUNC("jtag", 3, 42, 1),
- FUNC("util", 2, 42, 1),
+ FUNC("utif", 2, 42, 1),
FUNC("gpio", 1, 42, 1),
FUNC("p1led_an", 0, 42, 1),
};
--
2.11.0
[toc] | [next] | [standalone]
| From | John Crispin <john@phrozen.org> |
|---|---|
| Date | 2017-02-10 10:20 +0100 |
| Message-ID | <t9fwZ-1tL-11@gated-at.bofh.it> |
| In reply to | #1578318 |
On 10/02/2017 10:06, André Draszik wrote:
> They're all referenced as utif in the datasheet, not util.
>
> Fixes: 53263a1c6852 ("MIPS: ralink: add mt7628an support")
> Fixes: 2b436a351803 ("MIPS: ralink: add MT7628 EPHY LEDs pinmux support")
>
> Signed-off-by: André Draszik <git@andred.net>
I was under the impression that I had sent this patch already, maybe it
got lost somewhere along the line
Acked-by: John Crispin <john@phrozen.org>
> ---
> arch/mips/ralink/mt7620.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
> index 3c7c9bf57bf3..6f892c1f3ad7 100644
> --- a/arch/mips/ralink/mt7620.c
> +++ b/arch/mips/ralink/mt7620.c
> @@ -176,7 +176,7 @@ static struct rt2880_pmx_func spi_cs1_grp_mt7628[] = {
>
> static struct rt2880_pmx_func spis_grp_mt7628[] = {
> FUNC("pwm_uart2", 3, 14, 4),
> - FUNC("util", 2, 14, 4),
> + FUNC("utif", 2, 14, 4),
> FUNC("gpio", 1, 14, 4),
> FUNC("spis", 0, 14, 4),
> };
> @@ -190,28 +190,28 @@ static struct rt2880_pmx_func gpio_grp_mt7628[] = {
>
> static struct rt2880_pmx_func p4led_kn_grp_mt7628[] = {
> FUNC("jtag", 3, 30, 1),
> - FUNC("util", 2, 30, 1),
> + FUNC("utif", 2, 30, 1),
> FUNC("gpio", 1, 30, 1),
> FUNC("p4led_kn", 0, 30, 1),
> };
>
> static struct rt2880_pmx_func p3led_kn_grp_mt7628[] = {
> FUNC("jtag", 3, 31, 1),
> - FUNC("util", 2, 31, 1),
> + FUNC("utif", 2, 31, 1),
> FUNC("gpio", 1, 31, 1),
> FUNC("p3led_kn", 0, 31, 1),
> };
>
> static struct rt2880_pmx_func p2led_kn_grp_mt7628[] = {
> FUNC("jtag", 3, 32, 1),
> - FUNC("util", 2, 32, 1),
> + FUNC("utif", 2, 32, 1),
> FUNC("gpio", 1, 32, 1),
> FUNC("p2led_kn", 0, 32, 1),
> };
>
> static struct rt2880_pmx_func p1led_kn_grp_mt7628[] = {
> FUNC("jtag", 3, 33, 1),
> - FUNC("util", 2, 33, 1),
> + FUNC("utif", 2, 33, 1),
> FUNC("gpio", 1, 33, 1),
> FUNC("p1led_kn", 0, 33, 1),
> };
> @@ -232,28 +232,28 @@ static struct rt2880_pmx_func wled_kn_grp_mt7628[] = {
>
> static struct rt2880_pmx_func p4led_an_grp_mt7628[] = {
> FUNC("jtag", 3, 39, 1),
> - FUNC("util", 2, 39, 1),
> + FUNC("utif", 2, 39, 1),
> FUNC("gpio", 1, 39, 1),
> FUNC("p4led_an", 0, 39, 1),
> };
>
> static struct rt2880_pmx_func p3led_an_grp_mt7628[] = {
> FUNC("jtag", 3, 40, 1),
> - FUNC("util", 2, 40, 1),
> + FUNC("utif", 2, 40, 1),
> FUNC("gpio", 1, 40, 1),
> FUNC("p3led_an", 0, 40, 1),
> };
>
> static struct rt2880_pmx_func p2led_an_grp_mt7628[] = {
> FUNC("jtag", 3, 41, 1),
> - FUNC("util", 2, 41, 1),
> + FUNC("utif", 2, 41, 1),
> FUNC("gpio", 1, 41, 1),
> FUNC("p2led_an", 0, 41, 1),
> };
>
> static struct rt2880_pmx_func p1led_an_grp_mt7628[] = {
> FUNC("jtag", 3, 42, 1),
> - FUNC("util", 2, 42, 1),
> + FUNC("utif", 2, 42, 1),
> FUNC("gpio", 1, 42, 1),
> FUNC("p1led_an", 0, 42, 1),
> };
>
[toc] | [prev] | [next] | [standalone]
| From | James Hogan <james.hogan@imgtec.com> |
|---|---|
| Date | 2017-02-10 18:10 +0100 |
| Message-ID | <t9mRR-6is-27@gated-at.bofh.it> |
| In reply to | #1578325 |
[Multipart message — attachments visible in raw view] — view raw
On Fri, Feb 10, 2017 at 10:12:24AM +0100, John Crispin wrote:
>
>
> On 10/02/2017 10:06, André Draszik wrote:
> > They're all referenced as utif in the datasheet, not util.
> >
> > Fixes: 53263a1c6852 ("MIPS: ralink: add mt7628an support")
> > Fixes: 2b436a351803 ("MIPS: ralink: add MT7628 EPHY LEDs pinmux support")
> >
> > Signed-off-by: André Draszik <git@andred.net>
>
> I was under the impression that I had sent this patch already, maybe it
> got lost somewhere along the line
Yep:
https://patchwork.linux-mips.org/patch/14899/
Applied as commit 58181a117d353427127a2e7afc7cf1ab44759828
Though without Fixes or stable tag, so if that matters we'll have to
explicitly request backports.
Cheers
James
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web