Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1577659 > unrolled thread
| Started by | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| First post | 2017-02-09 15:50 +0100 |
| Last post | 2017-02-11 08:00 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-09 15:50 +0100
Re: [PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue Greg KH <gregkh@linuxfoundation.org> - 2017-02-10 15:10 +0100
Re: [PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue Greg KH <gregkh@linuxfoundation.org> - 2017-02-11 08:00 +0100
| From | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| Date | 2017-02-09 15:50 +0100 |
| Subject | [PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue |
| Message-ID | <t8YcO-7mZ-13@gated-at.bofh.it> |
Function definitions arguments should also have an identifier name as reported by checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> --- drivers/staging/vt6656/channel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/channel.h b/drivers/staging/vt6656/channel.h index fcea6995fe26..62f18a959098 100644 --- a/drivers/staging/vt6656/channel.h +++ b/drivers/staging/vt6656/channel.h @@ -28,6 +28,6 @@ #include "device.h" -void vnt_init_bands(struct vnt_private *); +void vnt_init_bands(struct vnt_private *priv); #endif /* _CHANNEL_H_ */ -- 2.11.0
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-10 15:10 +0100 |
| Subject | Re: [PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue |
| Message-ID | <t9k3E-4oZ-29@gated-at.bofh.it> |
| In reply to | #1577659 |
On Thu, Feb 09, 2017 at 08:17:56PM +0530, Arushi Singhal wrote: > Function definitions arguments should also have an identifier name as > reported by checkpatch.pl. > > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> > --- > drivers/staging/vt6656/channel.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Does not apply to my tree :(
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-11 08:00 +0100 |
| Subject | Re: [PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue |
| Message-ID | <t9zP4-5Np-7@gated-at.bofh.it> |
| In reply to | #1578483 |
On Sat, Feb 11, 2017 at 07:48:35AM +0530, Arushi Singhal wrote: > Hi > Sorry Greg but how this not applying to your mailing list. Your patch did not apply to my staging-next git tree. Probably because soemone else already did this same work before you did. Try rebasing your patch on my staging-next branch of staging.git on git.kernel.org and see for yourself. thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web