Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1577993 > unrolled thread
| Started by | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| First post | 2017-02-09 23:20 +0100 |
| Last post | 2017-02-10 08:20 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] media: fix s5p_mfc_set_dec_frame_buffer_v6() to print buf size in hex Shuah Khan <shuahkh@osg.samsung.com> - 2017-02-09 23:20 +0100
Re: [PATCH] media: fix s5p_mfc_set_dec_frame_buffer_v6() to print buf size in hex Nicolas Dufresne <nicolas@ndufresne.ca> - 2017-02-10 03:40 +0100
Re: [PATCH] media: fix s5p_mfc_set_dec_frame_buffer_v6() to print buf size in hex Andrzej Hajda <a.hajda@samsung.com> - 2017-02-10 08:20 +0100
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2017-02-09 23:20 +0100 |
| Subject | [PATCH] media: fix s5p_mfc_set_dec_frame_buffer_v6() to print buf size in hex |
| Message-ID | <t95ei-3ql-21@gated-at.bofh.it> |
Fix s5p_mfc_set_dec_frame_buffer_v6() to print buffer size in hex to be
consistent with the rest of the messages in the routine.
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
index d6f207e..fc45980 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
@@ -497,7 +497,7 @@ static int s5p_mfc_set_dec_frame_buffer_v6(struct s5p_mfc_ctx *ctx)
}
}
- mfc_debug(2, "Buf1: %zu, buf_size1: %d (frames %d)\n",
+ mfc_debug(2, "Buf1: %zx, buf_size1: %d (frames %d)\n",
buf_addr1, buf_size1, ctx->total_dpb_count);
if (buf_size1 < 0) {
mfc_debug(2, "Not enough memory has been allocated.\n");
--
2.7.4
[toc] | [next] | [standalone]
| From | Nicolas Dufresne <nicolas@ndufresne.ca> |
|---|---|
| Date | 2017-02-10 03:40 +0100 |
| Subject | Re: [PATCH] media: fix s5p_mfc_set_dec_frame_buffer_v6() to print buf size in hex |
| Message-ID | <t99hU-5Ry-13@gated-at.bofh.it> |
| In reply to | #1577993 |
[Multipart message — attachments visible in raw view] — view raw
Le jeudi 09 février 2017 à 15:10 -0700, Shuah Khan a écrit :
> Fix s5p_mfc_set_dec_frame_buffer_v6() to print buffer size in hex to
> be
> consistent with the rest of the messages in the routine.
Short and long descriptions are miss-leading. This patch will print the
buffer pointer as hex and keep the size as decimal. I think the patch
correctly improves consistency, the comment should match the code.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> index d6f207e..fc45980 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> @@ -497,7 +497,7 @@ static int s5p_mfc_set_dec_frame_buffer_v6(struct
> s5p_mfc_ctx *ctx)
> }
> }
>
> - mfc_debug(2, "Buf1: %zu, buf_size1: %d (frames %d)\n",
> + mfc_debug(2, "Buf1: %zx, buf_size1: %d (frames %d)\n",
> buf_addr1, buf_size1, ctx->total_dpb_count);
> if (buf_size1 < 0) {
> mfc_debug(2, "Not enough memory has been
> allocated.\n");
[toc] | [prev] | [next] | [standalone]
| From | Andrzej Hajda <a.hajda@samsung.com> |
|---|---|
| Date | 2017-02-10 08:20 +0100 |
| Subject | Re: [PATCH] media: fix s5p_mfc_set_dec_frame_buffer_v6() to print buf size in hex |
| Message-ID | <t9dES-jp-1@gated-at.bofh.it> |
| In reply to | #1577993 |
On 09.02.2017 23:10, Shuah Khan wrote:
> Fix s5p_mfc_set_dec_frame_buffer_v6() to print buffer size in hex to be
> consistent with the rest of the messages in the routine.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
As Nicolas said please fix the subject.
After this you can add my:
Acked-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> index d6f207e..fc45980 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> @@ -497,7 +497,7 @@ static int s5p_mfc_set_dec_frame_buffer_v6(struct s5p_mfc_ctx *ctx)
> }
> }
>
> - mfc_debug(2, "Buf1: %zu, buf_size1: %d (frames %d)\n",
> + mfc_debug(2, "Buf1: %zx, buf_size1: %d (frames %d)\n",
> buf_addr1, buf_size1, ctx->total_dpb_count);
> if (buf_size1 < 0) {
> mfc_debug(2, "Not enough memory has been allocated.\n");
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web