Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1579102 > unrolled thread

Re: [PATCH v5] fork: free vmapped stacks in cache when cpus are offline

Started byThomas Gleixner <tglx@linutronix.de>
First post2017-02-11 21:30 +0100
Last post2017-02-12 13:30 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v5] fork: free vmapped stacks in cache when cpus are  offline Thomas Gleixner <tglx@linutronix.de> - 2017-02-11 21:30 +0100
    Re: [PATCH v5] fork: free vmapped stacks in cache when cpus are offline Hoeun Ryu <hoeun.ryu@gmail.com> - 2017-02-12 02:50 +0100
      Re: [PATCH v5] fork: free vmapped stacks in cache when cpus are  offline Thomas Gleixner <tglx@linutronix.de> - 2017-02-12 13:30 +0100

#1579102 — Re: [PATCH v5] fork: free vmapped stacks in cache when cpus are offline

FromThomas Gleixner <tglx@linutronix.de>
Date2017-02-11 21:30 +0100
SubjectRe: [PATCH v5] fork: free vmapped stacks in cache when cpus are offline
Message-ID<t9MsW-5dv-17@gated-at.bofh.it>
On Sat, 11 Feb 2017, kbuild test robot wrote:

> Hi Hoeun,
> 
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.10-rc7 next-20170210]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Hoeun-Ryu/fork-free-vmapped-stacks-in-cache-when-cpus-are-offline/20170211-183401
> config: ia64-allmodconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 6.2.0
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=ia64 
> 
> All errors (new ones prefixed by >>):
> 
>    kernel/fork.c: In function 'fork_init':
> >> kernel/fork.c:483:2: error: implicit declaration of function 'vm_stack_cache_init' [-Werror=implicit-function-declaration]
>      vm_stack_cache_init();
>      ^~~~~~~~~~~~~~~~~~~

Right. This needs to move to a different place as that part is nested inside

#ifndef CONFIG_ARCH_THREAD_STACK_ALLOCATOR

That's an horrible ifdef maze in that file.

Thanks,

	tglx

[toc] | [next] | [standalone]


#1579146 — Re: [PATCH v5] fork: free vmapped stacks in cache when cpus are offline

FromHoeun Ryu <hoeun.ryu@gmail.com>
Date2017-02-12 02:50 +0100
SubjectRe: [PATCH v5] fork: free vmapped stacks in cache when cpus are offline
Message-ID<t9RsB-8i6-1@gated-at.bofh.it>
In reply to#1579102
> On Feb 12, 2017, at 5:19 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> 
>> On Sat, 11 Feb 2017, kbuild test robot wrote:
>> 
>> Hi Hoeun,
>> 
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on v4.10-rc7 next-20170210]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>> 
>> url:    https://github.com/0day-ci/linux/commits/Hoeun-Ryu/fork-free-vmapped-stacks-in-cache-when-cpus-are-offline/20170211-183401
>> config: ia64-allmodconfig (attached as .config)
>> compiler: ia64-linux-gcc (GCC) 6.2.0
>> reproduce:
>>        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>        chmod +x ~/bin/make.cross
>>        # save the attached .config to linux build tree
>>        make.cross ARCH=ia64 
>> 
>> All errors (new ones prefixed by >>):
>> 
>>   kernel/fork.c: In function 'fork_init':
>>>> kernel/fork.c:483:2: error: implicit declaration of function 'vm_stack_cache_init' [-Werror=implicit-function-declaration]
>>     vm_stack_cache_init();
>>     ^~~~~~~~~~~~~~~~~~~
> 
> Right. This needs to move to a different place as that part is nested inside
> 
> #ifndef CONFIG_ARCH_THREAD_STACK_ALLOCATOR
> 
> That's an horrible ifdef maze in that file.
> 

I think we should rollback to v4. Do you agree?

> Thanks,
> 
>    tglx

[toc] | [prev] | [next] | [standalone]


#1579208

FromThomas Gleixner <tglx@linutronix.de>
Date2017-02-12 13:30 +0100
Message-ID<ta1rY-6fk-5@gated-at.bofh.it>
In reply to#1579146
On Sun, 12 Feb 2017, Hoeun Ryu wrote:
> 
> > On Feb 12, 2017, at 5:19 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > 
> >> On Sat, 11 Feb 2017, kbuild test robot wrote:
> >> 
> >> Hi Hoeun,
> >> 
> >> [auto build test ERROR on linus/master]
> >> [also build test ERROR on v4.10-rc7 next-20170210]
> >> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> >> 
> >> url:    https://github.com/0day-ci/linux/commits/Hoeun-Ryu/fork-free-vmapped-stacks-in-cache-when-cpus-are-offline/20170211-183401
> >> config: ia64-allmodconfig (attached as .config)
> >> compiler: ia64-linux-gcc (GCC) 6.2.0
> >> reproduce:
> >>        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> >>        chmod +x ~/bin/make.cross
> >>        # save the attached .config to linux build tree
> >>        make.cross ARCH=ia64 
> >> 
> >> All errors (new ones prefixed by >>):
> >> 
> >>   kernel/fork.c: In function 'fork_init':
> >>>> kernel/fork.c:483:2: error: implicit declaration of function 'vm_stack_cache_init' [-Werror=implicit-function-declaration]
> >>     vm_stack_cache_init();
> >>     ^~~~~~~~~~~~~~~~~~~
> > 
> > Right. This needs to move to a different place as that part is nested inside
> > 
> > #ifndef CONFIG_ARCH_THREAD_STACK_ALLOCATOR
> > 
> > That's an horrible ifdef maze in that file.
> > 
> 
> I think we should rollback to v4. Do you agree?

Sigh. Yes.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web