Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577259 > unrolled thread

[PATCH 0/7] iio: isl29028: move out of staging

Started byBrian Masney <masneyb@onstation.org>
First post2017-02-09 03:00 +0100
Last post2017-02-11 11:00 +0100
Articles 7 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/7] iio: isl29028: move out of staging Brian Masney <masneyb@onstation.org> - 2017-02-09 03:00 +0100
    [PATCH 5/7] staging: iio: isl29028: add copyright Brian Masney <masneyb@onstation.org> - 2017-02-09 03:10 +0100
      Re: [PATCH 5/7] staging: iio: isl29028: add copyright Jonathan Cameron <jic23@kernel.org> - 2017-02-11 10:50 +0100
    [PATCH 6/7] iio: Documentation: add ABI documentation for in_proximity_sampling_frequency_available Brian Masney <masneyb@onstation.org> - 2017-02-09 03:40 +0100
      Re: [PATCH 6/7] iio: Documentation: add ABI documentation for  in_proximity_sampling_frequency_available Jonathan Cameron <jic23@kernel.org> - 2017-02-11 11:00 +0100
    [PATCH 7/7] staging: iio: isl29028: move out of staging Brian Masney <masneyb@onstation.org> - 2017-02-09 03:40 +0100
      Re: [PATCH 7/7] staging: iio: isl29028: move out of staging Jonathan Cameron <jic23@kernel.org> - 2017-02-11 11:00 +0100

#1577259 — [PATCH 0/7] iio: isl29028: move out of staging

FromBrian Masney <masneyb@onstation.org>
Date2017-02-09 03:00 +0100
Subject[PATCH 0/7] iio: isl29028: move out of staging
Message-ID<t8MbD-81G-3@gated-at.bofh.it>
This is my last series of staging cleanups for the ISL29028 driver.
Highlights of this patch series include some cleanups to the timing
code, a fix for runtime power management support, and documentation.

I mentioned in one of my earlier patch series that I was having issues
getting the proximity sensing portion of the sensor working. This
appears to be an issue with my sensor since I was able to get the
proximity sensor working intermittenly by tapping the chip. It is
likely an issue with the way that the chip was mounted on my breakout
board. I've also verified with a cell phone screen that the IR LED
turns on for two seconds when the proximity sensing feature is enabled.

Brian Masney (7):
  staging: iio: isl29028: change mdelay() to msleep()
  staging: iio: isl29028: fix incorrect sleep time when taking proximity
    reading
  staging: iio: isl29028: fix incorrect sampling frequency value
  staging: iio: isl29028: use the runtime power management for system
    sleep
  staging: iio: isl29028: add copyright
  iio: Documentation: add ABI documentation for
    in_proximity_sampling_frequency_available
  staging: iio: isl29028: move out of staging

 Documentation/ABI/testing/sysfs-bus-iio    |  1 +
 drivers/iio/light/Kconfig                  | 10 ++++++++
 drivers/iio/light/Makefile                 |  1 +
 drivers/{staging => }/iio/light/isl29028.c | 39 ++++++++++++++++++++----------
 drivers/staging/iio/light/Kconfig          | 10 --------
 drivers/staging/iio/light/Makefile         |  1 -
 6 files changed, 38 insertions(+), 24 deletions(-)
 rename drivers/{staging => }/iio/light/isl29028.c (95%)

-- 
2.9.3

[toc] | [next] | [standalone]

#1577262 — [PATCH 5/7] staging: iio: isl29028: add copyright

FromBrian Masney <masneyb@onstation.org>
Date2017-02-09 03:10 +0100
Subject[PATCH 5/7] staging: iio: isl29028: add copyright
Message-ID<t8Mlk-8kq-7@gated-at.bofh.it>
In reply to#1577259
Add Brian Masney's copyright to the header for the several rounds of
staging cleanups that has been done to this driver.

Signed-off-by: Brian Masney <masneyb@onstation.org>
---
 drivers/staging/iio/light/isl29028.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
index ddd604d..68b76b0 100644
--- a/drivers/staging/iio/light/isl29028.c
+++ b/drivers/staging/iio/light/isl29028.c
@@ -3,6 +3,7 @@
  * ISL29028 is Concurrent Ambient Light and Proximity Sensor
  *
  * Copyright (c) 2012, NVIDIA CORPORATION.  All rights reserved.
+ * Copyright (c) 2016-2017 Brian Masney <masneyb@onstation.org>
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms and conditions of the GNU General Public License,
-- 
2.9.3

[toc] | [prev] | [next] | [standalone]

#1578976 — Re: [PATCH 5/7] staging: iio: isl29028: add copyright

FromJonathan Cameron <jic23@kernel.org>
Date2017-02-11 10:50 +0100
SubjectRe: [PATCH 5/7] staging: iio: isl29028: add copyright
Message-ID<t9CtA-7ty-23@gated-at.bofh.it>
In reply to#1577262
On 09/02/17 01:54, Brian Masney wrote:
> Add Brian Masney's copyright to the header for the several rounds of
> staging cleanups that has been done to this driver.
> 
> Signed-off-by: Brian Masney <masneyb@onstation.org>
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders
to play with it.

Not that they'll do much with this one ;)

Thanks,

Jonathan
> ---
>  drivers/staging/iio/light/isl29028.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
> index ddd604d..68b76b0 100644
> --- a/drivers/staging/iio/light/isl29028.c
> +++ b/drivers/staging/iio/light/isl29028.c
> @@ -3,6 +3,7 @@
>   * ISL29028 is Concurrent Ambient Light and Proximity Sensor
>   *
>   * Copyright (c) 2012, NVIDIA CORPORATION.  All rights reserved.
> + * Copyright (c) 2016-2017 Brian Masney <masneyb@onstation.org>
>   *
>   * This program is free software; you can redistribute it and/or modify it
>   * under the terms and conditions of the GNU General Public License,
>

[toc] | [prev] | [next] | [standalone]

#1577272 — [PATCH 6/7] iio: Documentation: add ABI documentation for in_proximity_sampling_frequency_available

FromBrian Masney <masneyb@onstation.org>
Date2017-02-09 03:40 +0100
Subject[PATCH 6/7] iio: Documentation: add ABI documentation for in_proximity_sampling_frequency_available
Message-ID<t8MOl-8vl-1@gated-at.bofh.it>
In reply to#1577259
Add entry for the in_proximity_sampling_frequency_available sysfs
entry to the existing sampling_frequency_available ABI documentation.

Signed-off-by: Brian Masney <masneyb@onstation.org>
---
 Documentation/ABI/testing/sysfs-bus-iio | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
index 530809c..1ce4603 100644
--- a/Documentation/ABI/testing/sysfs-bus-iio
+++ b/Documentation/ABI/testing/sysfs-bus-iio
@@ -55,6 +55,7 @@ Description:
 		then it is to be found in the base device directory.
 
 What:		/sys/bus/iio/devices/iio:deviceX/sampling_frequency_available
+What:		/sys/bus/iio/devices/iio:deviceX/in_proximity_sampling_frequency_available
 What:		/sys/.../iio:deviceX/buffer/sampling_frequency_available
 What:		/sys/bus/iio/devices/triggerX/sampling_frequency_available
 KernelVersion:	2.6.35
-- 
2.9.3

[toc] | [prev] | [next] | [standalone]

#1578997 — Re: [PATCH 6/7] iio: Documentation: add ABI documentation for in_proximity_sampling_frequency_available

FromJonathan Cameron <jic23@kernel.org>
Date2017-02-11 11:00 +0100
SubjectRe: [PATCH 6/7] iio: Documentation: add ABI documentation for in_proximity_sampling_frequency_available
Message-ID<t9CDh-7xe-47@gated-at.bofh.it>
In reply to#1577272
On 09/02/17 01:54, Brian Masney wrote:
> Add entry for the in_proximity_sampling_frequency_available sysfs
> entry to the existing sampling_frequency_available ABI documentation.
> 
> Signed-off-by: Brian Masney <masneyb@onstation.org>
Applied.
> ---
>  Documentation/ABI/testing/sysfs-bus-iio | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index 530809c..1ce4603 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -55,6 +55,7 @@ Description:
>  		then it is to be found in the base device directory.
>  
>  What:		/sys/bus/iio/devices/iio:deviceX/sampling_frequency_available
> +What:		/sys/bus/iio/devices/iio:deviceX/in_proximity_sampling_frequency_available
>  What:		/sys/.../iio:deviceX/buffer/sampling_frequency_available
>  What:		/sys/bus/iio/devices/triggerX/sampling_frequency_available
>  KernelVersion:	2.6.35
>

[toc] | [prev] | [next] | [standalone]

#1577273 — [PATCH 7/7] staging: iio: isl29028: move out of staging

FromBrian Masney <masneyb@onstation.org>
Date2017-02-09 03:40 +0100
Subject[PATCH 7/7] staging: iio: isl29028: move out of staging
Message-ID<t8MOl-8vl-3@gated-at.bofh.it>
In reply to#1577259
Move ISL29028 ALS / Proximity Sensor out of staging and into mainline.

Signed-off-by: Brian Masney <masneyb@onstation.org>
---
 drivers/iio/light/Kconfig                  | 10 ++++++++++
 drivers/iio/light/Makefile                 |  1 +
 drivers/{staging => }/iio/light/isl29028.c |  0
 drivers/staging/iio/light/Kconfig          | 10 ----------
 drivers/staging/iio/light/Makefile         |  1 -
 5 files changed, 11 insertions(+), 11 deletions(-)
 rename drivers/{staging => }/iio/light/isl29028.c (100%)

diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
index 2afcbac..8b8c9e2 100644
--- a/drivers/iio/light/Kconfig
+++ b/drivers/iio/light/Kconfig
@@ -172,6 +172,16 @@ config SENSORS_ISL29018
 	 in lux, proximity infrared sensing and normal infrared sensing.
 	 Data from sensor is accessible via sysfs.
 
+config SENSORS_ISL29028
+	tristate "Intersil ISL29028 Concurrent Light and Proximity Sensor"
+	depends on I2C
+	select REGMAP_I2C
+	help
+	 Provides driver for the Intersil's ISL29028 device.
+	 This driver supports the sysfs interface to get the ALS, IR intensity,
+	 Proximity value via iio. The ISL29028 provides the concurrent sensing
+	 of ambient light and proximity.
+
 config ISL29125
 	tristate "Intersil ISL29125 digital color light sensor"
 	depends on I2C
diff --git a/drivers/iio/light/Makefile b/drivers/iio/light/Makefile
index edfd69b..2e730af 100644
--- a/drivers/iio/light/Makefile
+++ b/drivers/iio/light/Makefile
@@ -20,6 +20,7 @@ obj-$(CONFIG_GP2AP020A00F)	+= gp2ap020a00f.o
 obj-$(CONFIG_HID_SENSOR_ALS)	+= hid-sensor-als.o
 obj-$(CONFIG_HID_SENSOR_PROX)	+= hid-sensor-prox.o
 obj-$(CONFIG_SENSORS_ISL29018)	+= isl29018.o
+obj-$(CONFIG_SENSORS_ISL29028)	+= isl29028.o
 obj-$(CONFIG_ISL29125)		+= isl29125.o
 obj-$(CONFIG_JSA1212)		+= jsa1212.o
 obj-$(CONFIG_SENSORS_LM3533)	+= lm3533-als.o
diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/iio/light/isl29028.c
similarity index 100%
rename from drivers/staging/iio/light/isl29028.c
rename to drivers/iio/light/isl29028.c
diff --git a/drivers/staging/iio/light/Kconfig b/drivers/staging/iio/light/Kconfig
index 4fbf629..aacb0ae 100644
--- a/drivers/staging/iio/light/Kconfig
+++ b/drivers/staging/iio/light/Kconfig
@@ -3,16 +3,6 @@
 #
 menu "Light sensors"
 
-config SENSORS_ISL29028
-	tristate "Intersil ISL29028 Concurrent Light and Proximity Sensor"
-	depends on I2C
-	select REGMAP_I2C
-	help
-	 Provides driver for the Intersil's ISL29028 device.
-	 This driver supports the sysfs interface to get the ALS, IR intensity,
-	 Proximity value via iio. The ISL29028 provides the concurrent sensing
-	 of ambient light and proximity.
-
 config TSL2x7x
 	tristate "TAOS TSL/TMD2x71 and TSL/TMD2x72 Family of light and proximity sensors"
 	depends on I2C
diff --git a/drivers/staging/iio/light/Makefile b/drivers/staging/iio/light/Makefile
index f8693e9..10286c3 100644
--- a/drivers/staging/iio/light/Makefile
+++ b/drivers/staging/iio/light/Makefile
@@ -2,5 +2,4 @@
 # Makefile for industrial I/O Light sensors
 #
 
-obj-$(CONFIG_SENSORS_ISL29028)	+= isl29028.o
 obj-$(CONFIG_TSL2x7x)	+= tsl2x7x_core.o
-- 
2.9.3

[toc] | [prev] | [next] | [standalone]

#1578980 — Re: [PATCH 7/7] staging: iio: isl29028: move out of staging

FromJonathan Cameron <jic23@kernel.org>
Date2017-02-11 11:00 +0100
SubjectRe: [PATCH 7/7] staging: iio: isl29028: move out of staging
Message-ID<t9CDg-7xe-7@gated-at.bofh.it>
In reply to#1577273
On 09/02/17 01:54, Brian Masney wrote:
> Move ISL29028 ALS / Proximity Sensor out of staging and into mainline.
> 
> Signed-off-by: Brian Masney <masneyb@onstation.org>
I've taken another quick look at the driver and think this will be fine once
we have cleaned up that small question on the sampling frequencies.

Jonathan
> ---
>  drivers/iio/light/Kconfig                  | 10 ++++++++++
>  drivers/iio/light/Makefile                 |  1 +
>  drivers/{staging => }/iio/light/isl29028.c |  0
>  drivers/staging/iio/light/Kconfig          | 10 ----------
>  drivers/staging/iio/light/Makefile         |  1 -
>  5 files changed, 11 insertions(+), 11 deletions(-)
>  rename drivers/{staging => }/iio/light/isl29028.c (100%)
> 
> diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
> index 2afcbac..8b8c9e2 100644
> --- a/drivers/iio/light/Kconfig
> +++ b/drivers/iio/light/Kconfig
> @@ -172,6 +172,16 @@ config SENSORS_ISL29018
>  	 in lux, proximity infrared sensing and normal infrared sensing.
>  	 Data from sensor is accessible via sysfs.
>  
> +config SENSORS_ISL29028
> +	tristate "Intersil ISL29028 Concurrent Light and Proximity Sensor"
> +	depends on I2C
> +	select REGMAP_I2C
> +	help
> +	 Provides driver for the Intersil's ISL29028 device.
> +	 This driver supports the sysfs interface to get the ALS, IR intensity,
> +	 Proximity value via iio. The ISL29028 provides the concurrent sensing
> +	 of ambient light and proximity.
> +
>  config ISL29125
>  	tristate "Intersil ISL29125 digital color light sensor"
>  	depends on I2C
> diff --git a/drivers/iio/light/Makefile b/drivers/iio/light/Makefile
> index edfd69b..2e730af 100644
> --- a/drivers/iio/light/Makefile
> +++ b/drivers/iio/light/Makefile
> @@ -20,6 +20,7 @@ obj-$(CONFIG_GP2AP020A00F)	+= gp2ap020a00f.o
>  obj-$(CONFIG_HID_SENSOR_ALS)	+= hid-sensor-als.o
>  obj-$(CONFIG_HID_SENSOR_PROX)	+= hid-sensor-prox.o
>  obj-$(CONFIG_SENSORS_ISL29018)	+= isl29018.o
> +obj-$(CONFIG_SENSORS_ISL29028)	+= isl29028.o
>  obj-$(CONFIG_ISL29125)		+= isl29125.o
>  obj-$(CONFIG_JSA1212)		+= jsa1212.o
>  obj-$(CONFIG_SENSORS_LM3533)	+= lm3533-als.o
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/iio/light/isl29028.c
> similarity index 100%
> rename from drivers/staging/iio/light/isl29028.c
> rename to drivers/iio/light/isl29028.c
> diff --git a/drivers/staging/iio/light/Kconfig b/drivers/staging/iio/light/Kconfig
> index 4fbf629..aacb0ae 100644
> --- a/drivers/staging/iio/light/Kconfig
> +++ b/drivers/staging/iio/light/Kconfig
> @@ -3,16 +3,6 @@
>  #
>  menu "Light sensors"
>  
> -config SENSORS_ISL29028
> -	tristate "Intersil ISL29028 Concurrent Light and Proximity Sensor"
> -	depends on I2C
> -	select REGMAP_I2C
> -	help
> -	 Provides driver for the Intersil's ISL29028 device.
> -	 This driver supports the sysfs interface to get the ALS, IR intensity,
> -	 Proximity value via iio. The ISL29028 provides the concurrent sensing
> -	 of ambient light and proximity.
> -
>  config TSL2x7x
>  	tristate "TAOS TSL/TMD2x71 and TSL/TMD2x72 Family of light and proximity sensors"
>  	depends on I2C
> diff --git a/drivers/staging/iio/light/Makefile b/drivers/staging/iio/light/Makefile
> index f8693e9..10286c3 100644
> --- a/drivers/staging/iio/light/Makefile
> +++ b/drivers/staging/iio/light/Makefile
> @@ -2,5 +2,4 @@
>  # Makefile for industrial I/O Light sensors
>  #
>  
> -obj-$(CONFIG_SENSORS_ISL29028)	+= isl29028.o
>  obj-$(CONFIG_TSL2x7x)	+= tsl2x7x_core.o
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web