Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1578978 > unrolled thread
| Started by | Derek Robson <robsonde@gmail.com> |
|---|---|
| First post | 2017-02-11 11:00 +0100 |
| Last post | 2017-02-12 13:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 18/25] Staging: rtl8192u: ieee80211: rtl819x_HT.h - style fix Derek Robson <robsonde@gmail.com> - 2017-02-11 11:00 +0100
Re: [PATCH 18/25] Staging: rtl8192u: ieee80211: rtl819x_HT.h - style fix Greg KH <gregkh@linuxfoundation.org> - 2017-02-12 13:40 +0100
| From | Derek Robson <robsonde@gmail.com> |
|---|---|
| Date | 2017-02-11 11:00 +0100 |
| Subject | [PATCH 18/25] Staging: rtl8192u: ieee80211: rtl819x_HT.h - style fix |
| Message-ID | <t9CDg-7xe-5@gated-at.bofh.it> |
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson <robsonde@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 69 +++++++++++++------------
1 file changed, 35 insertions(+), 34 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
index c3aabbaac7ae..307ab45f528d 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
@@ -86,38 +86,38 @@ typedef enum _CHNLOP{
((_pHTInfo)->ChnlOp > CHNLOP_NONE) ? TRUE : FALSE
/*
-typedef union _HT_CAPABILITY{
- u16 ShortData;
- u8 CharData[2];
- struct
- {
- u16 AdvCoding:1;
- u16 ChlWidth:1;
- u16 MimoPwrSave:2;
- u16 GreenField:1;
- u16 ShortGI20Mhz:1;
- u16 ShortGI40Mhz:1;
- u16 STBC:1;
- u16 BeamForm:1;
- u16 DelayBA:1;
- u16 MaxAMSDUSize:1;
- u16 DssCCk:1;
- u16 PSMP:1;
- u16 Rsvd:3;
- }Field;
-}HT_CAPABILITY, *PHT_CAPABILITY;
-
-typedef union _HT_CAPABILITY_MACPARA{
- u8 ShortData;
- u8 CharData[1];
- struct
- {
- u8 MaxRxAMPDU:2;
- u8 MPDUDensity:2;
- u8 Rsvd:4;
- }Field;
-}HT_CAPABILITY_MACPARA, *PHT_CAPABILITY_MACPARA;
-*/
+ * typedef union _HT_CAPABILITY{
+ * u16 ShortData;
+ * u8 CharData[2];
+ * struct
+ * {
+ * u16 AdvCoding:1;
+ * u16 ChlWidth:1;
+ * u16 MimoPwrSave:2;
+ * u16 GreenField:1;
+ * u16 ShortGI20Mhz:1;
+ * u16 ShortGI40Mhz:1;
+ * u16 STBC:1;
+ * u16 BeamForm:1;
+ * u16 DelayBA:1;
+ * u16 MaxAMSDUSize:1;
+ * u16 DssCCk:1;
+ * u16 PSMP:1;
+ * u16 Rsvd:3;
+ * }Field;
+ * }HT_CAPABILITY, *PHT_CAPABILITY;
+ *
+ * typedef union _HT_CAPABILITY_MACPARA{
+ * u8 ShortData;
+ * u8 CharData[1];
+ * struct
+ * {
+ * u8 MaxRxAMPDU:2;
+ * u8 MPDUDensity:2;
+ * u8 Rsvd:4;
+ * }Field;
+ * }HT_CAPABILITY_MACPARA, *PHT_CAPABILITY_MACPARA;
+ */
typedef enum _HT_ACTION{
ACT_RECOMMAND_WIDTH = 0,
@@ -421,8 +421,9 @@ extern u8 MCS_FILTER_ALL[16];
extern u8 MCS_FILTER_1SS[16];
/* 2007/07/11 MH Modify the macro. Becaus STA may link with a N-AP. If we set
- STA in A/B/G mode and AP is still in N mode. The macro will be wrong. We have
- to add a macro to judge wireless mode. */
+ * STA in A/B/G mode and AP is still in N mode. The macro will be wrong. We have
+ * to add a macro to judge wireless mode.
+ */
#define PICK_RATE(_nLegacyRate, _nMcsRate) \
(_nMcsRate==0)?(_nLegacyRate&0x7f):(_nMcsRate)
/* 2007/07/12 MH We only define legacy and HT wireless mode now. */
--
2.11.1
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-12 13:40 +0100 |
| Subject | Re: [PATCH 18/25] Staging: rtl8192u: ieee80211: rtl819x_HT.h - style fix |
| Message-ID | <ta1BE-6ix-7@gated-at.bofh.it> |
| In reply to | #1578978 |
On Sat, Feb 11, 2017 at 10:57:28PM +1300, Derek Robson wrote:
> Fixed style of block comments
> Found using checkpatch
>
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 69 +++++++++++++------------
> 1 file changed, 35 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
> index c3aabbaac7ae..307ab45f528d 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
> @@ -86,38 +86,38 @@ typedef enum _CHNLOP{
> ((_pHTInfo)->ChnlOp > CHNLOP_NONE) ? TRUE : FALSE
>
> /*
> -typedef union _HT_CAPABILITY{
> - u16 ShortData;
> - u8 CharData[2];
> - struct
> - {
> - u16 AdvCoding:1;
> - u16 ChlWidth:1;
> - u16 MimoPwrSave:2;
> - u16 GreenField:1;
> - u16 ShortGI20Mhz:1;
> - u16 ShortGI40Mhz:1;
> - u16 STBC:1;
> - u16 BeamForm:1;
> - u16 DelayBA:1;
> - u16 MaxAMSDUSize:1;
> - u16 DssCCk:1;
> - u16 PSMP:1;
> - u16 Rsvd:3;
> - }Field;
> -}HT_CAPABILITY, *PHT_CAPABILITY;
> -
> -typedef union _HT_CAPABILITY_MACPARA{
> - u8 ShortData;
> - u8 CharData[1];
> - struct
> - {
> - u8 MaxRxAMPDU:2;
> - u8 MPDUDensity:2;
> - u8 Rsvd:4;
> - }Field;
> -}HT_CAPABILITY_MACPARA, *PHT_CAPABILITY_MACPARA;
> -*/
> + * typedef union _HT_CAPABILITY{
> + * u16 ShortData;
> + * u8 CharData[2];
> + * struct
> + * {
> + * u16 AdvCoding:1;
> + * u16 ChlWidth:1;
> + * u16 MimoPwrSave:2;
> + * u16 GreenField:1;
> + * u16 ShortGI20Mhz:1;
> + * u16 ShortGI40Mhz:1;
> + * u16 STBC:1;
> + * u16 BeamForm:1;
> + * u16 DelayBA:1;
> + * u16 MaxAMSDUSize:1;
> + * u16 DssCCk:1;
> + * u16 PSMP:1;
> + * u16 Rsvd:3;
> + * }Field;
> + * }HT_CAPABILITY, *PHT_CAPABILITY;
> + *
> + * typedef union _HT_CAPABILITY_MACPARA{
> + * u8 ShortData;
> + * u8 CharData[1];
> + * struct
> + * {
> + * u8 MaxRxAMPDU:2;
> + * u8 MPDUDensity:2;
> + * u8 Rsvd:4;
> + * }Field;
> + * }HT_CAPABILITY_MACPARA, *PHT_CAPABILITY_MACPARA;
> + */
>
> typedef enum _HT_ACTION{
> ACT_RECOMMAND_WIDTH = 0,
I'll take this, but shouldn't we just delete these structures that are
commented out? Same goes for other patches in this series.
thanks,
greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web