Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1576179 > unrolled thread

[PATCH v3] staging: bcm2835-audio: Remove the initialization of static pointers.

Back to article view | Back to linux.kernel

Contents

  [PATCH v3] staging: bcm2835-audio: Remove the initialization of static pointers. AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com> - 2017-02-08 00:50 +0100
    Re: [PATCH v3] staging: bcm2835-audio: Remove the initialization of  static pointers. Greg KH <gregkh@linuxfoundation.org> - 2017-02-09 13:50 +0100

#1576179 — [PATCH v3] staging: bcm2835-audio: Remove the initialization of static pointers.

In C a static pointer will be initialized to NULL.
The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
If an object that has static storage duration is not initialized
explicitly, then:
 __ if it has pointer type, it is initialized to a null pointer.

Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>

v2: -fix the line-wrapping of the changelog.
    -fix the ref. documentation: C99 standards release,
	and not the draft.
    -this patch is the Task 10 Eudyptula Challenge
	that only fix one code style problem.
v3: -fix the subject prefix: must be based on the previous submissions.
---
 drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
index a84d74d..265fe55 100644
--- a/drivers/staging/bcm2835-audio/bcm2835.c
+++ b/drivers/staging/bcm2835-audio/bcm2835.c
@@ -28,8 +28,8 @@
  * to debug if we run into issues
  */
 
-static struct snd_card *g_card = NULL;
-static struct bcm2835_chip *g_chip = NULL;
+static struct snd_card *g_card;
+static struct bcm2835_chip *g_chip;
 
 static int snd_bcm2835_free(struct bcm2835_chip *chip)
 {
-- 
2.7.4

[toc] | [next] | [standalone]

#1577541 — Re: [PATCH v3] staging: bcm2835-audio: Remove the initialization of static pointers.

On Wed, Feb 08, 2017 at 12:45:47AM +0100, AbdAllah-MEZITI wrote:
> In C a static pointer will be initialized to NULL.
> The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
> If an object that has static storage duration is not initialized
> explicitly, then:
>  __ if it has pointer type, it is initialized to a null pointer.
> 
> Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
> 
> v2: -fix the line-wrapping of the changelog.
>     -fix the ref. documentation: C99 standards release,
> 	and not the draft.
>     -this patch is the Task 10 Eudyptula Challenge
> 	that only fix one code style problem.
> v3: -fix the subject prefix: must be based on the previous submissions.
> ---
>  drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This patch does not apply to my tree at all, sorry.

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web