Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1576081 > unrolled thread

[PATCH-tip] debugobjects: Improve variable naming

Back to article view | Back to linux.kernel

Contents

  [PATCH-tip] debugobjects: Improve variable naming Waiman Long <longman@redhat.com> - 2017-02-07 22:50 +0100
    [tip:core/debugobjects] debugobjects: Improve variable naming tip-bot for Waiman Long <tipbot@zytor.com> - 2017-02-10 10:50 +0100

#1576081 — [PATCH-tip] debugobjects: Improve variable naming

As suggested by Ingo, the debug_objects_alloc counter is now renamed to
debug_objects_allocated with minor twist in comment and debug output.

Signed-off-by: Waiman Long <longman@redhat.com>
---
 lib/debugobjects.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 2a8ffca..17afb04 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -60,9 +60,9 @@ struct debug_bucket {
 static struct debug_obj_descr	*descr_test  __read_mostly;
 
 /*
- * Track numbers of kmem_cache_alloc and kmem_cache_free done.
+ * Track numbers of kmem_cache_alloc()/free() calls done.
  */
-static int			debug_objects_alloc;
+static int			debug_objects_allocated;
 static int			debug_objects_freed;
 
 static void free_obj_work(struct work_struct *work);
@@ -112,7 +112,7 @@ static void fill_pool(void)
 
 		raw_spin_lock_irqsave(&pool_lock, flags);
 		hlist_add_head(&new->node, &obj_pool);
-		debug_objects_alloc++;
+		debug_objects_allocated++;
 		obj_pool_free++;
 		raw_spin_unlock_irqrestore(&pool_lock, flags);
 	}
@@ -784,8 +784,8 @@ static int debug_stats_show(struct seq_file *m, void *v)
 	seq_printf(m, "pool_min_free :%d\n", obj_pool_min_free);
 	seq_printf(m, "pool_used     :%d\n", obj_pool_used);
 	seq_printf(m, "pool_max_used :%d\n", obj_pool_max_used);
-	seq_printf(m, "objects_alloc :%d\n", debug_objects_alloc);
-	seq_printf(m, "objects_freed :%d\n", debug_objects_freed);
+	seq_printf(m, "objs_allocated:%d\n", debug_objects_allocated);
+	seq_printf(m, "objs_freed    :%d\n", debug_objects_freed);
 	return 0;
 }
 
-- 
1.8.3.1

[toc] | [next] | [standalone]

#1578337 — [tip:core/debugobjects] debugobjects: Improve variable naming

Commit-ID:  0cad93c3453fc9d11692d3924ac3a520821bbf64
Gitweb:     http://git.kernel.org/tip/0cad93c3453fc9d11692d3924ac3a520821bbf64
Author:     Waiman Long <longman@redhat.com>
AuthorDate: Tue, 7 Feb 2017 16:40:30 -0500
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 10 Feb 2017 09:53:04 +0100

debugobjects: Improve variable naming

As suggested by Ingo, the debug_objects_alloc counter is now renamed to
debug_objects_allocated with minor twist in comment and debug output.

Signed-off-by: Waiman Long <longman@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1486503630-1501-1-git-send-email-longman@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 lib/debugobjects.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 5e1bf2f..8c28cbd 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -59,9 +59,9 @@ static int			debug_objects_pool_min_level __read_mostly
 static struct debug_obj_descr	*descr_test  __read_mostly;
 
 /*
- * Track numbers of kmem_cache_alloc and kmem_cache_free done.
+ * Track numbers of kmem_cache_alloc()/free() calls done.
  */
-static int			debug_objects_alloc;
+static int			debug_objects_allocated;
 static int			debug_objects_freed;
 
 static void free_obj_work(struct work_struct *work);
@@ -111,7 +111,7 @@ static void fill_pool(void)
 
 		raw_spin_lock_irqsave(&pool_lock, flags);
 		hlist_add_head(&new->node, &obj_pool);
-		debug_objects_alloc++;
+		debug_objects_allocated++;
 		obj_pool_free++;
 		raw_spin_unlock_irqrestore(&pool_lock, flags);
 	}
@@ -783,8 +783,8 @@ static int debug_stats_show(struct seq_file *m, void *v)
 	seq_printf(m, "pool_min_free :%d\n", obj_pool_min_free);
 	seq_printf(m, "pool_used     :%d\n", obj_pool_used);
 	seq_printf(m, "pool_max_used :%d\n", obj_pool_max_used);
-	seq_printf(m, "objects_alloc :%d\n", debug_objects_alloc);
-	seq_printf(m, "objects_freed :%d\n", debug_objects_freed);
+	seq_printf(m, "objs_allocated:%d\n", debug_objects_allocated);
+	seq_printf(m, "objs_freed    :%d\n", debug_objects_freed);
 	return 0;
 }
 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web