Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1573080 > unrolled thread
| Started by | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| First post | 2017-02-03 14:30 +0100 |
| Last post | 2017-02-07 13:30 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] serial: 8250_pci: Fix EXAR feature control register constants Jan Kiszka <jan.kiszka@siemens.com> - 2017-02-03 14:30 +0100
Re: [PATCH] serial: 8250_pci: Fix EXAR feature control register constants Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-07 13:00 +0100
Re: [PATCH] serial: 8250_pci: Fix EXAR feature control register constants Jan Kiszka <jan.kiszka@siemens.com> - 2017-02-07 13:10 +0100
Re: [PATCH] serial: 8250_pci: Fix EXAR feature control register constants Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-07 13:30 +0100
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-02-03 14:30 +0100 |
| Subject | [PATCH] serial: 8250_pci: Fix EXAR feature control register constants |
| Message-ID | <t6M65-25T-11@gated-at.bofh.it> |
According to the XR17V352 manual, bit 4 is IrDA control and bit 5 for 485. Fortunately, no driver used them so far. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- include/uapi/linux/serial_reg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/serial_reg.h b/include/uapi/linux/serial_reg.h index b4c0484..b1f60cb 100644 --- a/include/uapi/linux/serial_reg.h +++ b/include/uapi/linux/serial_reg.h @@ -366,8 +366,8 @@ #define UART_EXAR_DVID 0x8d /* Device identification */ #define UART_EXAR_FCTR 0x08 /* Feature Control Register */ -#define UART_FCTR_EXAR_IRDA 0x08 /* IrDa data encode select */ -#define UART_FCTR_EXAR_485 0x10 /* Auto 485 half duplex dir ctl */ +#define UART_FCTR_EXAR_IRDA 0x10 /* IrDa data encode select */ +#define UART_FCTR_EXAR_485 0x20 /* Auto 485 half duplex dir ctl */ #define UART_FCTR_EXAR_TRGA 0x00 /* FIFO trigger table A */ #define UART_FCTR_EXAR_TRGB 0x60 /* FIFO trigger table B */ #define UART_FCTR_EXAR_TRGC 0x80 /* FIFO trigger table C */
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-02-07 13:00 +0100 |
| Message-ID | <t8cBc-2ms-3@gated-at.bofh.it> |
| In reply to | #1573080 |
+Cc Sudip On Fri, Feb 3, 2017 at 3:22 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > According to the XR17V352 manual, bit 4 is IrDA control and bit 5 for > 485. Fortunately, no driver used them so far. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > include/uapi/linux/serial_reg.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/serial_reg.h b/include/uapi/linux/serial_reg.h > index b4c0484..b1f60cb 100644 > --- a/include/uapi/linux/serial_reg.h > +++ b/include/uapi/linux/serial_reg.h > @@ -366,8 +366,8 @@ > #define UART_EXAR_DVID 0x8d /* Device identification */ > > #define UART_EXAR_FCTR 0x08 /* Feature Control Register */ > -#define UART_FCTR_EXAR_IRDA 0x08 /* IrDa data encode select */ > -#define UART_FCTR_EXAR_485 0x10 /* Auto 485 half duplex dir ctl */ > +#define UART_FCTR_EXAR_IRDA 0x10 /* IrDa data encode select */ > +#define UART_FCTR_EXAR_485 0x20 /* Auto 485 half duplex dir ctl */ > #define UART_FCTR_EXAR_TRGA 0x00 /* FIFO trigger table A */ > #define UART_FCTR_EXAR_TRGB 0x60 /* FIFO trigger table B */ > #define UART_FCTR_EXAR_TRGC 0x80 /* FIFO trigger table C */ -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-02-07 13:10 +0100 |
| Subject | Re: [PATCH] serial: 8250_pci: Fix EXAR feature control register constants |
| Message-ID | <t8cKS-2F9-27@gated-at.bofh.it> |
| In reply to | #1575592 |
On 2017-02-07 12:55, Andy Shevchenko wrote: > +Cc Sudip > > On Fri, Feb 3, 2017 at 3:22 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >> According to the XR17V352 manual, bit 4 is IrDA control and bit 5 for >> 485. Fortunately, no driver used them so far. >> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> >> --- >> include/uapi/linux/serial_reg.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/uapi/linux/serial_reg.h b/include/uapi/linux/serial_reg.h >> index b4c0484..b1f60cb 100644 >> --- a/include/uapi/linux/serial_reg.h >> +++ b/include/uapi/linux/serial_reg.h >> @@ -366,8 +366,8 @@ >> #define UART_EXAR_DVID 0x8d /* Device identification */ >> >> #define UART_EXAR_FCTR 0x08 /* Feature Control Register */ >> -#define UART_FCTR_EXAR_IRDA 0x08 /* IrDa data encode select */ >> -#define UART_FCTR_EXAR_485 0x10 /* Auto 485 half duplex dir ctl */ >> +#define UART_FCTR_EXAR_IRDA 0x10 /* IrDa data encode select */ >> +#define UART_FCTR_EXAR_485 0x20 /* Auto 485 half duplex dir ctl */ >> #define UART_FCTR_EXAR_TRGA 0x00 /* FIFO trigger table A */ >> #define UART_FCTR_EXAR_TRGB 0x60 /* FIFO trigger table B */ >> #define UART_FCTR_EXAR_TRGC 0x80 /* FIFO trigger table C */ > > > BTW, I recalled that Greg preferred to remove these regs from uapi. Once I'm done with moving the fastcom exar code over to 8250_exar.c (currently compiling...), I'll also write a patch to move these defines in the same file. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-02-07 13:30 +0100 |
| Message-ID | <t8d4d-2MB-9@gated-at.bofh.it> |
| In reply to | #1575607 |
On Tue, Feb 7, 2017 at 2:01 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 2017-02-07 12:55, Andy Shevchenko wrote: >> +Cc Sudip > BTW, I recalled that Greg preferred to remove these regs from uapi. Once > I'm done with moving the fastcom exar code over to 8250_exar.c > (currently compiling...), I'll also write a patch to move these defines > in the same file. Sounds like a plan! Just Cc Sudip for your future patches. Thanks. -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web