Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571512 > unrolled thread

Re: [PATCH 1/1] asus-wireless: Fix identation

Started byJoão Paulo Rechi Vita <jprvita@gmail.com>
First post2017-02-01 13:30 +0100
Last post2017-02-07 11:30 +0100
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/1] asus-wireless: Fix identation João Paulo Rechi Vita <jprvita@gmail.com> - 2017-02-01 13:30 +0100
    [PATCH] asus-wireless: Fix identation "João Paulo Rechi Vita" <jprvita@gmail.com> - 2017-02-01 13:30 +0100
      Re: [PATCH] asus-wireless: Fix identation Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-04 16:10 +0100
        Re: [PATCH] asus-wireless: Fix identation Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-04 16:20 +0100
          [PATCHv3] platform/x86: asus-wireless: Fix identation "João Paulo Rechi Vita" <jprvita@gmail.com> - 2017-02-06 16:30 +0100
            Re: [PATCHv3] platform/x86: asus-wireless: Fix identation Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-07 11:30 +0100

#1571512 — Re: [PATCH 1/1] asus-wireless: Fix identation

FromJoão Paulo Rechi Vita <jprvita@gmail.com>
Date2017-02-01 13:30 +0100
SubjectRe: [PATCH 1/1] asus-wireless: Fix identation
Message-ID<t62cV-5Vf-19@gated-at.bofh.it>
On 27 January 2017 at 10:28, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Thu, Jan 26, 2017 at 4:25 PM, João Paulo Rechi Vita
> <jprvita@gmail.com> wrote:
>> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
>> ---
>>  drivers/platform/x86/asus-wireless.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
>> index 9f31bc1a47d0..c9b5ac152cf1 100644
>> --- a/drivers/platform/x86/asus-wireless.c
>> +++ b/drivers/platform/x86/asus-wireless.c
>> @@ -77,7 +77,7 @@ static void led_state_update(struct work_struct *work)
>>  }
>>
>>  static void led_state_set(struct led_classdev *led,
>> -                                 enum led_brightness value)
>> +                         enum led_brightness value)
>
> I would see benefit if it would be one line.
>

Yes, I fixed this in a hurry and missed it actually fits in one line.
Thanks for catching it! I'll reply with an updated patch.

--
João Paulo Rechi Vita
http://about.me/jprvita

[toc] | [next] | [standalone]

#1571519 — [PATCH] asus-wireless: Fix identation

From"João Paulo Rechi Vita" <jprvita@gmail.com>
Date2017-02-01 13:30 +0100
Subject[PATCH] asus-wireless: Fix identation
Message-ID<t62cW-5Vf-35@gated-at.bofh.it>
In reply to#1571512
Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
---
 drivers/platform/x86/asus-wireless.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
index 9f31bc1a47d0..a7ee18383146 100644
--- a/drivers/platform/x86/asus-wireless.c
+++ b/drivers/platform/x86/asus-wireless.c
@@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
 			     data->led_state);
 }
 
-static void led_state_set(struct led_classdev *led,
-				  enum led_brightness value)
+static void led_state_set(struct led_classdev *led, enum led_brightness value)
 {
 	struct asus_wireless_data *data;
 
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1573680 — Re: [PATCH] asus-wireless: Fix identation

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-02-04 16:10 +0100
SubjectRe: [PATCH] asus-wireless: Fix identation
Message-ID<t7a8q-2cc-17@gated-at.bofh.it>
In reply to#1571519
On Wed, Feb 1, 2017 at 2:27 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote:

Do not leave empty commit message. Describe your changes here in a few words.

For the drivers/platform/x86 use a pattern in subject

platform/x86: asus-wireless: ...

> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
> ---
>  drivers/platform/x86/asus-wireless.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
> index 9f31bc1a47d0..a7ee18383146 100644
> --- a/drivers/platform/x86/asus-wireless.c
> +++ b/drivers/platform/x86/asus-wireless.c
> @@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
>                              data->led_state);
>  }
>
> -static void led_state_set(struct led_classdev *led,
> -                                 enum led_brightness value)
> +static void led_state_set(struct led_classdev *led, enum led_brightness value)
>  {
>         struct asus_wireless_data *data;
>
> --
> 2.11.0
>



-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1573682 — Re: [PATCH] asus-wireless: Fix identation

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-02-04 16:20 +0100
SubjectRe: [PATCH] asus-wireless: Fix identation
Message-ID<t7ai5-2gx-7@gated-at.bofh.it>
In reply to#1573680
On Sat, Feb 4, 2017 at 5:08 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Feb 1, 2017 at 2:27 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote:
>
> Do not leave empty commit message. Describe your changes here in a few words.
>
> For the drivers/platform/x86 use a pattern in subject
>
> platform/x86: asus-wireless: ...

And one more, use versioning of your patches: PATCHv1, PATCHv2, ...

>
>> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
>> ---
>>  drivers/platform/x86/asus-wireless.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
>> index 9f31bc1a47d0..a7ee18383146 100644
>> --- a/drivers/platform/x86/asus-wireless.c
>> +++ b/drivers/platform/x86/asus-wireless.c
>> @@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
>>                              data->led_state);
>>  }
>>
>> -static void led_state_set(struct led_classdev *led,
>> -                                 enum led_brightness value)
>> +static void led_state_set(struct led_classdev *led, enum led_brightness value)
>>  {
>>         struct asus_wireless_data *data;
>>
>> --
>> 2.11.0
>>
>
>
>
> --
> With Best Regards,
> Andy Shevchenko



-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1574897 — [PATCHv3] platform/x86: asus-wireless: Fix identation

From"João Paulo Rechi Vita" <jprvita@gmail.com>
Date2017-02-06 16:30 +0100
Subject[PATCHv3] platform/x86: asus-wireless: Fix identation
Message-ID<t7ToS-6Gk-1@gated-at.bofh.it>
In reply to#1573682
Fix identation problem introduced when this driver was first merged into
the kernel.

Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
---
 drivers/platform/x86/asus-wireless.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
index 9f31bc1a47d0..a7ee18383146 100644
--- a/drivers/platform/x86/asus-wireless.c
+++ b/drivers/platform/x86/asus-wireless.c
@@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
 			     data->led_state);
 }
 
-static void led_state_set(struct led_classdev *led,
-				  enum led_brightness value)
+static void led_state_set(struct led_classdev *led, enum led_brightness value)
 {
 	struct asus_wireless_data *data;
 
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1575548 — Re: [PATCHv3] platform/x86: asus-wireless: Fix identation

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-02-07 11:30 +0100
SubjectRe: [PATCHv3] platform/x86: asus-wireless: Fix identation
Message-ID<t8bc6-1Av-13@gated-at.bofh.it>
In reply to#1574897
On Mon, Feb 6, 2017 at 5:20 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote:
> Fix identation problem introduced when this driver was first merged into
> the kernel.

Thanks, pushed to testing.

>
> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
> ---
>  drivers/platform/x86/asus-wireless.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
> index 9f31bc1a47d0..a7ee18383146 100644
> --- a/drivers/platform/x86/asus-wireless.c
> +++ b/drivers/platform/x86/asus-wireless.c
> @@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
>                              data->led_state);
>  }
>
> -static void led_state_set(struct led_classdev *led,
> -                                 enum led_brightness value)
> +static void led_state_set(struct led_classdev *led, enum led_brightness value)
>  {
>         struct asus_wireless_data *data;
>
> --
> 2.11.0
>



-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web