Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1574353 > unrolled thread

linux-next: build warning after merge of the tty tree

Back to article view | Back to linux.kernel

Contents

  linux-next: build warning after merge of the tty tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-02-06 05:20 +0100
    Re: linux-next: build warning after merge of the tty tree Greg KH <greg@kroah.com> - 2017-02-06 10:00 +0100
      Re: linux-next: build warning after merge of the tty tree Ulrich Hecht <ulrich.hecht+renesas@gmail.com> - 2017-02-06 18:10 +0100
        Re: linux-next: build warning after merge of the tty tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-02-06 23:40 +0100
          Re: linux-next: build warning after merge of the tty tree Greg KH <greg@kroah.com> - 2017-02-07 09:40 +0100
            Re: linux-next: build warning after merge of the tty tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-02-07 12:20 +0100

#1574353 — linux-next: build warning after merge of the tty tree

Hi Greg,

After merging the tty tree, today's linux-next build
(arm_multi_v7_defconfig) produced this warning:

drivers/tty/serial/sh-sci.c:977:12: warning: 'scif_set_rtrg' defined but not used [-Wunused-function]
 static int scif_set_rtrg(struct uart_port *port, int rx_trig)
            ^

Introduced by commit

  a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting")

Forgot to add a call to this new function?

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1574474

On Mon, Feb 06, 2017 at 03:16:38PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build
> (arm_multi_v7_defconfig) produced this warning:
> 
> drivers/tty/serial/sh-sci.c:977:12: warning: 'scif_set_rtrg' defined but not used [-Wunused-function]
>  static int scif_set_rtrg(struct uart_port *port, int rx_trig)
>             ^
> 
> Introduced by commit
> 
>   a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting")
> 
> Forgot to add a call to this new function?

I think this is fixed by a patch I just took into my tree, which isn't
in linux-next yet.  Right Ulrich?  Or is this still a warning with your
latest patch series?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1574997

On Mon, Feb 6, 2017 at 9:50 AM, Greg KH <greg@kroah.com> wrote:
> On Mon, Feb 06, 2017 at 03:16:38PM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> After merging the tty tree, today's linux-next build
>> (arm_multi_v7_defconfig) produced this warning:
>>
>> drivers/tty/serial/sh-sci.c:977:12: warning: 'scif_set_rtrg' defined but not used [-Wunused-function]
>>  static int scif_set_rtrg(struct uart_port *port, int rx_trig)
>>             ^
>>
>> Introduced by commit
>>
>>   a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting")
>>
>> Forgot to add a call to this new function?
>
> I think this is fixed by a patch I just took into my tree, which isn't
> in linux-next yet.  Right Ulrich?

That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci:
SCIFA/B RX FIFO software timeout".

CU
Uli

[toc] | [prev] | [next] | [standalone]

#1575214

Hi all,

On Mon, 6 Feb 2017 18:01:20 +0100 Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote:
>
> On Mon, Feb 6, 2017 at 9:50 AM, Greg KH <greg@kroah.com> wrote:
> >
> > I think this is fixed by a patch I just took into my tree, which isn't
> > in linux-next yet.  Right Ulrich?  
> 
> That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci:
> SCIFA/B RX FIFO software timeout".

I don't see that commit in any tree I have fetched.

-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [next] | [standalone]

#1575475

On Tue, Feb 07, 2017 at 09:37:09AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 6 Feb 2017 18:01:20 +0100 Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote:
> >
> > On Mon, Feb 6, 2017 at 9:50 AM, Greg KH <greg@kroah.com> wrote:
> > >
> > > I think this is fixed by a patch I just took into my tree, which isn't
> > > in linux-next yet.  Right Ulrich?  
> > 
> > That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci:
> > SCIFA/B RX FIFO software timeout".
> 
> I don't see that commit in any tree I have fetched.

That is correct, it's in my "testing" branch that I use to stage things
in before it gets sent to the branch that you pull from.

That branch is now merged with my -next branch, so you will see this
change the next time you sync.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1575568

Hi Greg,

On Tue, 7 Feb 2017 09:37:31 +0100 Greg KH <greg@kroah.com> wrote:
>
> On Tue, Feb 07, 2017 at 09:37:09AM +1100, Stephen Rothwell wrote:
> > 
> > I don't see that commit in any tree I have fetched.  
> 
> That is correct, it's in my "testing" branch that I use to stage things
> in before it gets sent to the branch that you pull from.

What an amusing idea ;-)

> That branch is now merged with my -next branch, so you will see this
> change the next time you sync.

Thanks.

-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web