Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1575864 > unrolled thread
| Started by | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| First post | 2017-02-07 17:50 +0100 |
| Last post | 2017-02-13 19:40 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-07 17:50 +0100
Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm Kevin Hilman <khilman@baylibre.com> - 2017-02-07 19:30 +0100
Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm Sekhar Nori <nsekhar@ti.com> - 2017-02-09 16:40 +0100
Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-09 17:50 +0100
Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm Kevin Hilman <khilman@baylibre.com> - 2017-02-13 19:40 +0100
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-02-07 17:50 +0100 |
| Subject | [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm |
| Message-ID | <t8h7P-5ki-1@gated-at.bofh.it> |
When we enable vpif capture on the da850-evm we hit a BUG_ON() because
the i2c adapter can't be found. The board file boot uses i2c adapter 1
but in the DT mode it's actually adapter 0. Drop the problematic lines.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
arch/arm/mach-davinci/pdata-quirks.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c
index 94948c1..09f62ac 100644
--- a/arch/arm/mach-davinci/pdata-quirks.c
+++ b/arch/arm/mach-davinci/pdata-quirks.c
@@ -116,10 +116,6 @@ static void __init da850_vpif_legacy_init(void)
if (of_machine_is_compatible("ti,da850-lcdk"))
da850_vpif_capture_config.subdev_count = 1;
- /* EVM (UI card) uses i2c adapter 1 (not default: zero) */
- if (of_machine_is_compatible("ti,da850-evm"))
- da850_vpif_capture_config.i2c_adapter_id = 1;
-
ret = da850_register_vpif_capture(&da850_vpif_capture_config);
if (ret)
pr_warn("%s: VPIF capture setup failed: %d\n",
--
2.9.3
[toc] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2017-02-07 19:30 +0100 |
| Message-ID | <t8iGB-6nr-7@gated-at.bofh.it> |
| In reply to | #1575864 |
Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
> When we enable vpif capture on the da850-evm we hit a BUG_ON() because
> the i2c adapter can't be found. The board file boot uses i2c adapter 1
> but in the DT mode it's actually adapter 0. Drop the problematic lines.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> arch/arm/mach-davinci/pdata-quirks.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c
> index 94948c1..09f62ac 100644
> --- a/arch/arm/mach-davinci/pdata-quirks.c
> +++ b/arch/arm/mach-davinci/pdata-quirks.c
> @@ -116,10 +116,6 @@ static void __init da850_vpif_legacy_init(void)
> if (of_machine_is_compatible("ti,da850-lcdk"))
> da850_vpif_capture_config.subdev_count = 1;
>
> - /* EVM (UI card) uses i2c adapter 1 (not default: zero) */
> - if (of_machine_is_compatible("ti,da850-evm"))
> - da850_vpif_capture_config.i2c_adapter_id = 1;
> -
oops, my bad.
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ret = da850_register_vpif_capture(&da850_vpif_capture_config);
> if (ret)
> pr_warn("%s: VPIF capture setup failed: %d\n",
[toc] | [prev] | [next] | [standalone]
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Date | 2017-02-09 16:40 +0100 |
| Message-ID | <t8YZd-7Tl-47@gated-at.bofh.it> |
| In reply to | #1575945 |
On Tuesday 07 February 2017 11:51 PM, Kevin Hilman wrote:
> Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
>
>> When we enable vpif capture on the da850-evm we hit a BUG_ON() because
>> the i2c adapter can't be found. The board file boot uses i2c adapter 1
>> but in the DT mode it's actually adapter 0. Drop the problematic lines.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> ---
>> arch/arm/mach-davinci/pdata-quirks.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c
>> index 94948c1..09f62ac 100644
>> --- a/arch/arm/mach-davinci/pdata-quirks.c
>> +++ b/arch/arm/mach-davinci/pdata-quirks.c
>> @@ -116,10 +116,6 @@ static void __init da850_vpif_legacy_init(void)
>> if (of_machine_is_compatible("ti,da850-lcdk"))
>> da850_vpif_capture_config.subdev_count = 1;
>>
>> - /* EVM (UI card) uses i2c adapter 1 (not default: zero) */
>> - if (of_machine_is_compatible("ti,da850-evm"))
>> - da850_vpif_capture_config.i2c_adapter_id = 1;
>> -
>
> oops, my bad.
>
> Acked-by: Kevin Hilman <khilman@baylibre.com>
The offending code is not in my master branch. Since its almost certain
that VPIF platform support is going to wait for v4.12, can you or Kevin
please update Kevin's original patches with these fixes rolled in?
Thanks,
Sekhar
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-02-09 17:50 +0100 |
| Message-ID | <t904X-5k-39@gated-at.bofh.it> |
| In reply to | #1577708 |
2017-02-09 16:23 GMT+01:00 Sekhar Nori <nsekhar@ti.com>:
> On Tuesday 07 February 2017 11:51 PM, Kevin Hilman wrote:
>> Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
>>
>>> When we enable vpif capture on the da850-evm we hit a BUG_ON() because
>>> the i2c adapter can't be found. The board file boot uses i2c adapter 1
>>> but in the DT mode it's actually adapter 0. Drop the problematic lines.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>> ---
>>> arch/arm/mach-davinci/pdata-quirks.c | 4 ----
>>> 1 file changed, 4 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c
>>> index 94948c1..09f62ac 100644
>>> --- a/arch/arm/mach-davinci/pdata-quirks.c
>>> +++ b/arch/arm/mach-davinci/pdata-quirks.c
>>> @@ -116,10 +116,6 @@ static void __init da850_vpif_legacy_init(void)
>>> if (of_machine_is_compatible("ti,da850-lcdk"))
>>> da850_vpif_capture_config.subdev_count = 1;
>>>
>>> - /* EVM (UI card) uses i2c adapter 1 (not default: zero) */
>>> - if (of_machine_is_compatible("ti,da850-evm"))
>>> - da850_vpif_capture_config.i2c_adapter_id = 1;
>>> -
>>
>> oops, my bad.
>>
>> Acked-by: Kevin Hilman <khilman@baylibre.com>
>
> The offending code is not in my master branch. Since its almost certain
> that VPIF platform support is going to wait for v4.12, can you or Kevin
> please update Kevin's original patches with these fixes rolled in?
>
> Thanks,
> Sekhar
>
Sure, I based my series on Kevin's integration branch for 4.10.
Thanks,
Bartosz
[toc] | [prev] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2017-02-13 19:40 +0100 |
| Message-ID | <tatHB-7nG-25@gated-at.bofh.it> |
| In reply to | #1577708 |
Sekhar Nori <nsekhar@ti.com> writes:
> On Tuesday 07 February 2017 11:51 PM, Kevin Hilman wrote:
>> Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
>>
>>> When we enable vpif capture on the da850-evm we hit a BUG_ON() because
>>> the i2c adapter can't be found. The board file boot uses i2c adapter 1
>>> but in the DT mode it's actually adapter 0. Drop the problematic lines.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>> ---
>>> arch/arm/mach-davinci/pdata-quirks.c | 4 ----
>>> 1 file changed, 4 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c
>>> index 94948c1..09f62ac 100644
>>> --- a/arch/arm/mach-davinci/pdata-quirks.c
>>> +++ b/arch/arm/mach-davinci/pdata-quirks.c
>>> @@ -116,10 +116,6 @@ static void __init da850_vpif_legacy_init(void)
>>> if (of_machine_is_compatible("ti,da850-lcdk"))
>>> da850_vpif_capture_config.subdev_count = 1;
>>>
>>> - /* EVM (UI card) uses i2c adapter 1 (not default: zero) */
>>> - if (of_machine_is_compatible("ti,da850-evm"))
>>> - da850_vpif_capture_config.i2c_adapter_id = 1;
>>> -
>>
>> oops, my bad.
>>
>> Acked-by: Kevin Hilman <khilman@baylibre.com>
>
> The offending code is not in my master branch. Since its almost certain
> that VPIF platform support is going to wait for v4.12, can you or Kevin
> please update Kevin's original patches with these fixes rolled in?
I'm folding this into the original patch.
Kevin
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web