Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1577546 > unrolled thread
| Started by | Arushi <arushisinghal19971997@gmail.com> |
|---|---|
| First post | 2017-02-09 14:00 +0100 |
| Last post | 2017-02-09 14:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue Arushi <arushisinghal19971997@gmail.com> - 2017-02-09 14:00 +0100
Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue Greg KH <gregkh@linuxfoundation.org> - 2017-02-09 14:10 +0100
| From | Arushi <arushisinghal19971997@gmail.com> |
|---|---|
| Date | 2017-02-09 14:00 +0100 |
| Subject | [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue |
| Message-ID | <t8Wul-6gZ-9@gated-at.bofh.it> |
Function definitions arguments should also have an identifier name as reported by checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> --- drivers/staging/vt6655/baseband.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h index 8a567c9155b4..c351e03f6ad2 100644 --- a/drivers/staging/vt6655/baseband.h +++ b/drivers/staging/vt6655/baseband.h @@ -75,13 +75,13 @@ void BBvSetShortSlotTime(struct vnt_private *); void BBvSetVGAGainOffset(struct vnt_private *, unsigned char byData); /* VT3253 Baseband */ -bool BBbVT3253Init(struct vnt_private *); -void BBvSoftwareReset(struct vnt_private *); -void BBvPowerSaveModeON(struct vnt_private *); -void BBvPowerSaveModeOFF(struct vnt_private *); -void BBvSetTxAntennaMode(struct vnt_private *, unsigned char byAntennaMode); -void BBvSetRxAntennaMode(struct vnt_private *, unsigned char byAntennaMode); -void BBvSetDeepSleep(struct vnt_private *, unsigned char byLocalID); -void BBvExitDeepSleep(struct vnt_private *, unsigned char byLocalID); +bool BBbVT3253Init(struct vnt_private *priv); +void BBvSoftwareReset(struct vnt_private *priv); +void BBvPowerSaveModeON(struct vnt_private *priv); +void BBvPowerSaveModeOFF(struct vnt_private *priv); +void BBvSetTxAntennaMode(struct vnt_private *priv, unsigned char byAntennaMode); +void BBvSetRxAntennaMode(struct vnt_private *priv, unsigned char byAntennaMode); +void BBvSetDeepSleep(struct vnt_private *priv, unsigned char byLocalID); +void BBvExitDeepSleep(struct vnt_private *priv, unsigned char byLocalID); #endif /* __BASEBAND_H__ */ -- 2.11.0
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-09 14:10 +0100 |
| Subject | Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue |
| Message-ID | <t8WE1-6zl-7@gated-at.bofh.it> |
| In reply to | #1577546 |
On Thu, Feb 09, 2017 at 06:25:20PM +0530, Arushi wrote: > Function definitions arguments should also have an identifier name as reported by checkpatch.pl. > > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> This name does not match up with your From: line :( Also, please wrap your changelog text at the correct width. thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web