Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577485 > unrolled thread

[PATCH] staging: greybus: es2.c: fix some coding style issues

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: greybus: es2.c: fix some coding style issues Gioh Kim <gi-oh.kim@profitbricks.com> - 2017-02-09 12:40 +0100
    Re: [PATCH] staging: greybus: es2.c: fix some coding style issues Greg KH <gregkh@linuxfoundation.org> - 2017-02-09 12:40 +0100

#1577485 — [PATCH] staging: greybus: es2.c: fix some coding style issues

Fix two coding style issues:
1. line over 80 characters
2. Octal permissions are preffered than symbolic ones

Signed-off-by: Gioh Kim <gi-oh.kim@profitbricks.com>
---
 drivers/staging/greybus/es2.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
index 93afd93..f7b24e0 100644
--- a/drivers/staging/greybus/es2.c
+++ b/drivers/staging/greybus/es2.c
@@ -1085,7 +1085,8 @@ static void apb_log_get(struct es2_ap_dev *es2, char *buf)
 		retval = usb_control_msg(es2->usb_dev,
 					usb_rcvctrlpipe(es2->usb_dev, 0),
 					GB_APB_REQUEST_LOG,
-					USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_INTERFACE,
+					USB_DIR_IN | USB_TYPE_VENDOR |
+					USB_RECIP_INTERFACE,
 					0x00, 0x00,
 					buf,
 					APB1_LOG_MSG_SIZE,
@@ -1151,7 +1152,7 @@ static void usb_log_enable(struct es2_ap_dev *es2)
 	if (IS_ERR(es2->apb_log_task))
 		return;
 	/* XXX We will need to rename this per APB */
-	es2->apb_log_dentry = debugfs_create_file("apb_log", S_IRUGO,
+	es2->apb_log_dentry = debugfs_create_file("apb_log", 0444,
 						gb_debugfs_get(), es2,
 						&apb_log_fops);
 }
@@ -1408,7 +1409,7 @@ static int ap_probe(struct usb_interface *interface,
 
 	/* XXX We will need to rename this per APB */
 	es2->apb_log_enable_dentry = debugfs_create_file("apb_log_enable",
-							(S_IWUSR | S_IRUGO),
+							0644,
 							gb_debugfs_get(), es2,
 							&apb_log_enable_fops);
 
-- 
2.5.0

[toc] | [next] | [standalone]

#1577489

On Thu, Feb 09, 2017 at 12:04:59PM +0100, Gioh Kim wrote:
> Fix two coding style issues:
> 1. line over 80 characters
> 2. Octal permissions are preffered than symbolic ones

I just said not to do this, why resend it?

Also, you forgot to include the correct people and mailing list on the
patch, please fix up.

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web