Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577442 > unrolled thread

Re: [V2] android: binder: use VM_ALLOC to get vm area

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [V2] android: binder: use VM_ALLOC to get vm area Ganesh Mahendran <opensource.ganesh@gmail.com> - 2017-02-09 11:00 +0100
    Re: [V2] android: binder: use VM_ALLOC to get vm area Greg KH <gregkh@linuxfoundation.org> - 2017-02-09 11:20 +0100
      Re: [V2] android: binder: use VM_ALLOC to get vm area Ganesh Mahendran <opensource.ganesh@gmail.com> - 2017-02-09 12:00 +0100
        Re: [V2] android: binder: use VM_ALLOC to get vm area Greg KH <gregkh@linuxfoundation.org> - 2017-02-09 12:30 +0100

#1577442 — Re: [V2] android: binder: use VM_ALLOC to get vm area

A gentle ping.

Thanks.

2016-11-15 21:18 GMT+08:00 Ganesh Mahendran <opensource.ganesh@gmail.com>:
> Hi, Greg
>
> 2016-11-15 18:18 GMT+08:00 Greg KH <gregkh@linuxfoundation.org>:
>> On Tue, Nov 15, 2016 at 05:55:39PM +0800, Ganesh Mahendran wrote:
>>> VM_IOREMAP is used to access hardware through a mechanism called
>>> I/O mapped memory. Android binder is a IPC machanism which will
>>> not access I/O memory.
>>>
>>> Also VM_IOREMAP has alignment requiement which may not needed in
>>> binder.
>>>     __get_vm_area_node()
>>>     {
>>>     ...
>>>         if (flags & VM_IOREMAP)
>>>             align = 1ul << clamp_t(int, fls_long(size),
>>>                PAGE_SHIFT, IOREMAP_MAX_ORDER);
>>>     ...
>>>     }
>>>
>>> This patch use VM_ALLOC to get vm area.
>>>
>>> Below is the throughput test result:
>>>
>>>   # ./binderThroughputTest -w 100
>>>   I run this command 10 times:
>>>                                before    after
>>>   average iterations per sec:  11199.9   11886.9
>>>
>>> No performance regression found throgh binder test.
>>>
>>> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
>>> ---
>>>  drivers/android/binder.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> What changed from v1?
>
> Sorry for missing the change information.
>
> In V2, I run the binder test. And there is no side effect with this
> patch.
>
>>
>> Always list that below the --- line.
>
> Thanks for reminder.
>
>>
>> thanks,
>>
>> greg k-h

[toc] | [next] | [standalone]

#1577449

On Thu, Feb 09, 2017 at 05:54:03PM +0800, Ganesh Mahendran wrote:
> A gentle ping.

I don't see a patch here that can be accepted, what are you asking for
a response from?

confused,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1577469

Hi, Greg:

2017-02-09 18:17 GMT+08:00 Greg KH <gregkh@linuxfoundation.org>:
> On Thu, Feb 09, 2017 at 05:54:03PM +0800, Ganesh Mahendran wrote:
>> A gentle ping.
>
> I don't see a patch here that can be accepted, what are you asking for
> a response from?

I sent a patch before:
https://patchwork.kernel.org/patch/9429257/

Please help to review.

Thanks.

>
> confused,
>
> greg k-h

[toc] | [prev] | [next] | [standalone]

#1577479

On Thu, Feb 09, 2017 at 06:30:02PM +0800, Ganesh Mahendran wrote:
> Hi, Greg:
> 
> 2017-02-09 18:17 GMT+08:00 Greg KH <gregkh@linuxfoundation.org>:
> > On Thu, Feb 09, 2017 at 05:54:03PM +0800, Ganesh Mahendran wrote:
> >> A gentle ping.
> >
> > I don't see a patch here that can be accepted, what are you asking for
> > a response from?
> 
> I sent a patch before:
> https://patchwork.kernel.org/patch/9429257/

I don't use patchwork, please respond to the patch you are referring to,
or resend it.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web