Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1577141 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-02-08 23:10 +0100 |
| Last post | 2017-02-09 23:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] [net-next] ARM: orion: remove unused wnr854t_switch_plat_data Arnd Bergmann <arnd@arndb.de> - 2017-02-08 23:10 +0100
Re: [PATCH] [net-next] ARM: orion: remove unused wnr854t_switch_plat_data Florian Fainelli <f.fainelli@gmail.com> - 2017-02-08 23:20 +0100
Re: [PATCH] [net-next] ARM: orion: remove unused wnr854t_switch_plat_data David Miller <davem@davemloft.net> - 2017-02-09 23:40 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-02-08 23:10 +0100 |
| Subject | [PATCH] [net-next] ARM: orion: remove unused wnr854t_switch_plat_data |
| Message-ID | <t8IB3-5ZY-13@gated-at.bofh.it> |
The other instances of this structure got removed along with the MDIO
device change, but this one was left behind and needs to be removed
as well:
arch/arm/mach-orion5x/wnr854t-setup.c:109:44: error: 'wnr854t_switch_plat_data' defined but not used [-Werror=unused-variable]
static struct dsa_platform_data __initdata wnr854t_switch_plat_data = {
Fixes: 575e93f7b5e6 ("ARM: orion: Register DSA switch as a MDIO device")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-orion5x/wnr854t-setup.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm/mach-orion5x/wnr854t-setup.c b/arch/arm/mach-orion5x/wnr854t-setup.c
index ac3376fc269f..d162d4c7f85d 100644
--- a/arch/arm/mach-orion5x/wnr854t-setup.c
+++ b/arch/arm/mach-orion5x/wnr854t-setup.c
@@ -106,11 +106,6 @@ static struct dsa_chip_data wnr854t_switch_chip_data = {
.port_names[7] = "lan2",
};
-static struct dsa_platform_data __initdata wnr854t_switch_plat_data = {
- .nr_chips = 1,
- .chip = &wnr854t_switch_chip_data,
-};
-
static void __init wnr854t_init(void)
{
/*
--
2.9.0
[toc] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2017-02-08 23:20 +0100 |
| Subject | Re: [PATCH] [net-next] ARM: orion: remove unused wnr854t_switch_plat_data |
| Message-ID | <t8IKK-63Z-3@gated-at.bofh.it> |
| In reply to | #1577141 |
On 02/08/2017 01:24 PM, Arnd Bergmann wrote:
> The other instances of this structure got removed along with the MDIO
> device change, but this one was left behind and needs to be removed
> as well:
>
> arch/arm/mach-orion5x/wnr854t-setup.c:109:44: error: 'wnr854t_switch_plat_data' defined but not used [-Werror=unused-variable]
> static struct dsa_platform_data __initdata wnr854t_switch_plat_data = {
>
> Fixes: 575e93f7b5e6 ("ARM: orion: Register DSA switch as a MDIO device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks Arnd!
--
Florian
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-02-09 23:40 +0100 |
| Subject | Re: [PATCH] [net-next] ARM: orion: remove unused wnr854t_switch_plat_data |
| Message-ID | <t95xD-3yO-15@gated-at.bofh.it> |
| In reply to | #1577141 |
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 8 Feb 2017 22:24:19 +0100
> The other instances of this structure got removed along with the MDIO
> device change, but this one was left behind and needs to be removed
> as well:
>
> arch/arm/mach-orion5x/wnr854t-setup.c:109:44: error: 'wnr854t_switch_plat_data' defined but not used [-Werror=unused-variable]
> static struct dsa_platform_data __initdata wnr854t_switch_plat_data = {
>
> Fixes: 575e93f7b5e6 ("ARM: orion: Register DSA switch as a MDIO device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web