Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1576667 > unrolled thread

[PATCH -next] reset: uniphier: fix non static symbol warnings

Started byWei Yongjun <weiyj.lk@gmail.com>
First post2017-02-08 17:00 +0100
Last post2017-02-08 17:40 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH -next] reset: uniphier: fix non static symbol warnings Wei Yongjun <weiyj.lk@gmail.com> - 2017-02-08 17:00 +0100
    Re: [PATCH -next] reset: uniphier: fix non static symbol warnings Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-02-08 17:20 +0100
      Re: [PATCH -next] reset: uniphier: fix non static symbol warnings Philipp Zabel <p.zabel@pengutronix.de> - 2017-02-08 17:40 +0100

#1576667 — [PATCH -next] reset: uniphier: fix non static symbol warnings

FromWei Yongjun <weiyj.lk@gmail.com>
Date2017-02-08 17:00 +0100
Subject[PATCH -next] reset: uniphier: fix non static symbol warnings
Message-ID<t8CP0-2b0-11@gated-at.bofh.it>
From: Wei Yongjun <weiyongjun1@huawei.com>

Fixes the following sparse warnings:

drivers/reset/reset-uniphier.c:68:34: warning:
 symbol 'uniphier_sld3_sys_reset_data' was not declared. Should it be static?
drivers/reset/reset-uniphier.c:73:34: warning:
 symbol 'uniphier_pro4_sys_reset_data' was not declared. Should it be static?
drivers/reset/reset-uniphier.c:81:34: warning:
 symbol 'uniphier_pro5_sys_reset_data' was not declared. Should it be static?
drivers/reset/reset-uniphier.c:89:34: warning:
 symbol 'uniphier_pxs2_sys_reset_data' was not declared. Should it be static?
drivers/reset/reset-uniphier.c:103:34: warning:
 symbol 'uniphier_ld11_sys_reset_data' was not declared. Should it be static?
drivers/reset/reset-uniphier.c:108:34: warning:
 symbol 'uniphier_ld20_sys_reset_data' was not declared. Should it be static?
drivers/reset/reset-uniphier.c:137:34: warning:
 symbol 'uniphier_sld3_mio_reset_data' was not declared. Should it be static?
drivers/reset/reset-uniphier.c:157:34: warning:
 symbol 'uniphier_pro5_sd_reset_data' was not declared. Should it be static?
drivers/reset/reset-uniphier.c:174:34: warning:
 symbol 'uniphier_ld4_peri_reset_data' was not declared. Should it be static?
drivers/reset/reset-uniphier.c:187:34: warning:
 symbol 'uniphier_pro4_peri_reset_data' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/reset/reset-uniphier.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
index 9c11be3..7af60bc 100644
--- a/drivers/reset/reset-uniphier.c
+++ b/drivers/reset/reset-uniphier.c
@@ -65,12 +65,12 @@ struct uniphier_reset_data {
 #define UNIPHIER_PRO4_SYS_RESET_USB3(id, ch)		\
 	UNIPHIER_RESETX((id), 0x2000 + 0x4 * (ch), 17)
 
-const struct uniphier_reset_data uniphier_sld3_sys_reset_data[] = {
+static const struct uniphier_reset_data uniphier_sld3_sys_reset_data[] = {
 	UNIPHIER_SLD3_SYS_RESET_STDMAC(8),	/* Ether, HSC, MIO */
 	UNIPHIER_RESET_END,
 };
 
-const struct uniphier_reset_data uniphier_pro4_sys_reset_data[] = {
+static const struct uniphier_reset_data uniphier_pro4_sys_reset_data[] = {
 	UNIPHIER_SLD3_SYS_RESET_STDMAC(8),	/* HSC, MIO, RLE */
 	UNIPHIER_PRO4_SYS_RESET_GIO(12),	/* Ether, SATA, USB3 */
 	UNIPHIER_PRO4_SYS_RESET_USB3(14, 0),
@@ -78,7 +78,7 @@ const struct uniphier_reset_data uniphier_pro4_sys_reset_data[] = {
 	UNIPHIER_RESET_END,
 };
 
-const struct uniphier_reset_data uniphier_pro5_sys_reset_data[] = {
+static const struct uniphier_reset_data uniphier_pro5_sys_reset_data[] = {
 	UNIPHIER_SLD3_SYS_RESET_STDMAC(8),	/* HSC */
 	UNIPHIER_PRO4_SYS_RESET_GIO(12),	/* PCIe, USB3 */
 	UNIPHIER_PRO4_SYS_RESET_USB3(14, 0),
@@ -86,7 +86,7 @@ const struct uniphier_reset_data uniphier_pro5_sys_reset_data[] = {
 	UNIPHIER_RESET_END,
 };
 
-const struct uniphier_reset_data uniphier_pxs2_sys_reset_data[] = {
+static const struct uniphier_reset_data uniphier_pxs2_sys_reset_data[] = {
 	UNIPHIER_SLD3_SYS_RESET_STDMAC(8),	/* HSC, RLE */
 	UNIPHIER_PRO4_SYS_RESET_USB3(14, 0),
 	UNIPHIER_PRO4_SYS_RESET_USB3(15, 1),
@@ -100,12 +100,12 @@ const struct uniphier_reset_data uniphier_pxs2_sys_reset_data[] = {
 	UNIPHIER_RESET_END,
 };
 
-const struct uniphier_reset_data uniphier_ld11_sys_reset_data[] = {
+static const struct uniphier_reset_data uniphier_ld11_sys_reset_data[] = {
 	UNIPHIER_LD11_SYS_RESET_STDMAC(8),	/* HSC, MIO */
 	UNIPHIER_RESET_END,
 };
 
-const struct uniphier_reset_data uniphier_ld20_sys_reset_data[] = {
+static const struct uniphier_reset_data uniphier_ld20_sys_reset_data[] = {
 	UNIPHIER_LD11_SYS_RESET_STDMAC(8),	/* HSC */
 	UNIPHIER_LD20_SYS_RESET_GIO(12),	/* PCIe, USB3 */
 	UNIPHIER_RESETX(16, 0x200c, 12),	/* USB30-PHY0 */
@@ -134,7 +134,7 @@ const struct uniphier_reset_data uniphier_ld20_sys_reset_data[] = {
 #define UNIPHIER_MIO_RESET_DMAC(id)			\
 	UNIPHIER_RESETX((id), 0x110, 17)
 
-const struct uniphier_reset_data uniphier_sld3_mio_reset_data[] = {
+static const struct uniphier_reset_data uniphier_sld3_mio_reset_data[] = {
 	UNIPHIER_MIO_RESET_SD(0, 0),
 	UNIPHIER_MIO_RESET_SD(1, 1),
 	UNIPHIER_MIO_RESET_SD(2, 2),
@@ -154,7 +154,7 @@ const struct uniphier_reset_data uniphier_sld3_mio_reset_data[] = {
 	UNIPHIER_RESET_END,
 };
 
-const struct uniphier_reset_data uniphier_pro5_sd_reset_data[] = {
+static const struct uniphier_reset_data uniphier_pro5_sd_reset_data[] = {
 	UNIPHIER_MIO_RESET_SD(0, 0),
 	UNIPHIER_MIO_RESET_SD(1, 1),
 	UNIPHIER_MIO_RESET_EMMC_HW_RESET(6, 1),
@@ -171,7 +171,7 @@ const struct uniphier_reset_data uniphier_pro5_sd_reset_data[] = {
 #define UNIPHIER_PERI_RESET_FI2C(id, ch)		\
 	UNIPHIER_RESETX((id), 0x114, 24 + (ch))
 
-const struct uniphier_reset_data uniphier_ld4_peri_reset_data[] = {
+static const struct uniphier_reset_data uniphier_ld4_peri_reset_data[] = {
 	UNIPHIER_PERI_RESET_UART(0, 0),
 	UNIPHIER_PERI_RESET_UART(1, 1),
 	UNIPHIER_PERI_RESET_UART(2, 2),
@@ -184,7 +184,7 @@ const struct uniphier_reset_data uniphier_ld4_peri_reset_data[] = {
 	UNIPHIER_RESET_END,
 };
 
-const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {
+static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {
 	UNIPHIER_PERI_RESET_UART(0, 0),
 	UNIPHIER_PERI_RESET_UART(1, 1),
 	UNIPHIER_PERI_RESET_UART(2, 2),

[toc] | [next] | [standalone]

#1576683

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2017-02-08 17:20 +0100
Message-ID<t8D8m-2x9-15@gated-at.bofh.it>
In reply to#1576667
2017-02-09 0:56 GMT+09:00 Wei Yongjun <weiyj.lk@gmail.com>:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warnings:
>
> drivers/reset/reset-uniphier.c:68:34: warning:
>  symbol 'uniphier_sld3_sys_reset_data' was not declared. Should it be static?
> drivers/reset/reset-uniphier.c:73:34: warning:
>  symbol 'uniphier_pro4_sys_reset_data' was not declared. Should it be static?
> drivers/reset/reset-uniphier.c:81:34: warning:
>  symbol 'uniphier_pro5_sys_reset_data' was not declared. Should it be static?
> drivers/reset/reset-uniphier.c:89:34: warning:
>  symbol 'uniphier_pxs2_sys_reset_data' was not declared. Should it be static?
> drivers/reset/reset-uniphier.c:103:34: warning:
>  symbol 'uniphier_ld11_sys_reset_data' was not declared. Should it be static?
> drivers/reset/reset-uniphier.c:108:34: warning:
>  symbol 'uniphier_ld20_sys_reset_data' was not declared. Should it be static?
> drivers/reset/reset-uniphier.c:137:34: warning:
>  symbol 'uniphier_sld3_mio_reset_data' was not declared. Should it be static?
> drivers/reset/reset-uniphier.c:157:34: warning:
>  symbol 'uniphier_pro5_sd_reset_data' was not declared. Should it be static?
> drivers/reset/reset-uniphier.c:174:34: warning:
>  symbol 'uniphier_ld4_peri_reset_data' was not declared. Should it be static?
> drivers/reset/reset-uniphier.c:187:34: warning:
>  symbol 'uniphier_pro4_peri_reset_data' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>



Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>


Thanks!



-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]

#1576694

FromPhilipp Zabel <p.zabel@pengutronix.de>
Date2017-02-08 17:40 +0100
Message-ID<t8DrI-2DS-13@gated-at.bofh.it>
In reply to#1576683
On Thu, 2017-02-09 at 01:04 +0900, Masahiro Yamada wrote:
> 2017-02-09 0:56 GMT+09:00 Wei Yongjun <weiyj.lk@gmail.com>:
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> >
> > Fixes the following sparse warnings:
> >
> > drivers/reset/reset-uniphier.c:68:34: warning:
> >  symbol 'uniphier_sld3_sys_reset_data' was not declared. Should it be static?
> > drivers/reset/reset-uniphier.c:73:34: warning:
> >  symbol 'uniphier_pro4_sys_reset_data' was not declared. Should it be static?
> > drivers/reset/reset-uniphier.c:81:34: warning:
> >  symbol 'uniphier_pro5_sys_reset_data' was not declared. Should it be static?
> > drivers/reset/reset-uniphier.c:89:34: warning:
> >  symbol 'uniphier_pxs2_sys_reset_data' was not declared. Should it be static?
> > drivers/reset/reset-uniphier.c:103:34: warning:
> >  symbol 'uniphier_ld11_sys_reset_data' was not declared. Should it be static?
> > drivers/reset/reset-uniphier.c:108:34: warning:
> >  symbol 'uniphier_ld20_sys_reset_data' was not declared. Should it be static?
> > drivers/reset/reset-uniphier.c:137:34: warning:
> >  symbol 'uniphier_sld3_mio_reset_data' was not declared. Should it be static?
> > drivers/reset/reset-uniphier.c:157:34: warning:
> >  symbol 'uniphier_pro5_sd_reset_data' was not declared. Should it be static?
> > drivers/reset/reset-uniphier.c:174:34: warning:
> >  symbol 'uniphier_ld4_peri_reset_data' was not declared. Should it be static?
> > drivers/reset/reset-uniphier.c:187:34: warning:
> >  symbol 'uniphier_pro4_peri_reset_data' was not declared. Should it be static?
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> 
> 
> 
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> 
> 
> Thanks!

Applied, thanks.

regards
Philipp

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web