Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575237 > unrolled thread

[PATCH] net: ethernet: ti: cpsw: remove netif_trans_update

Back to article view | Back to linux.kernel

Contents

  [PATCH] net: ethernet: ti: cpsw: remove netif_trans_update Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2017-02-07 00:00 +0100
    Re: [PATCH] net: ethernet: ti: cpsw: remove netif_trans_update David Miller <davem@davemloft.net> - 2017-02-07 19:50 +0100

#1575237 — [PATCH] net: ethernet: ti: cpsw: remove netif_trans_update

No need to update jiffies in txq->trans_start twice, it's supposed to be
done in netdev_start_xmit() and anyway is re-written. Also, no reason to
update trans time in case of an error.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
Based on net-next/master

 drivers/net/ethernet/ti/cpsw.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 35a95dc..4d1c0c3 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -1601,8 +1601,6 @@ static netdev_tx_t cpsw_ndo_start_xmit(struct sk_buff *skb,
 	struct cpdma_chan *txch;
 	int ret, q_idx;
 
-	netif_trans_update(ndev);
-
 	if (skb_padto(skb, CPSW_MIN_PACKET_SIZE)) {
 		cpsw_err(priv, tx_err, "packet pad failed\n");
 		ndev->stats.tx_dropped++;
-- 
2.7.4

[toc] | [next] | [standalone]

#1575951

From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Date: Tue,  7 Feb 2017 00:53:45 +0200

> No need to update jiffies in txq->trans_start twice, it's supposed to be
> done in netdev_start_xmit() and anyway is re-written. Also, no reason to
> update trans time in case of an error.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
> Based on net-next/master

Applied, thank you.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web