Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1573932 > unrolled thread

Re: [PATCH 1/6] genirq: allow assigning affinity to present but not online CPUs

Started byChristoph Hellwig <hch@lst.de>
First post2017-02-05 17:50 +0100
Last post2017-02-06 18:10 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 1/6] genirq: allow assigning affinity to present but         not online CPUs Christoph Hellwig <hch@lst.de> - 2017-02-05 17:50 +0100
    Re: [PATCH 1/6] genirq: allow assigning affinity to present but not  online CPUs Keith Busch <keith.busch@intel.com> - 2017-02-06 18:00 +0100
      Re: [PATCH 1/6] genirq: allow assigning affinity to present but         not online CPUs Christoph Hellwig <hch@lst.de> - 2017-02-06 18:10 +0100

#1573932 — Re: [PATCH 1/6] genirq: allow assigning affinity to present but not online CPUs

FromChristoph Hellwig <hch@lst.de>
Date2017-02-05 17:50 +0100
SubjectRe: [PATCH 1/6] genirq: allow assigning affinity to present but not online CPUs
Message-ID<t7yaK-1kO-9@gated-at.bofh.it>
Hi Joe,

On Fri, Feb 03, 2017 at 08:58:09PM -0500, Joe Korty wrote:
> IIRC, some years ago I ran across a customer system where
> the #cpus_present was twice as big as #cpus_possible.
> 
> Hyperthreading was turned off in the BIOS so it was not
> entirely out of line for the extra cpus to be declared
> present, even though none of them would ever be available
> for use.

This sounds like a system we should quirk around instead of optimizing
for it.  Unless I totally misunderstand the idea behind cpu_possible
and cpu_present.

[toc] | [next] | [standalone]


#1574991 — Re: [PATCH 1/6] genirq: allow assigning affinity to present but not online CPUs

FromKeith Busch <keith.busch@intel.com>
Date2017-02-06 18:00 +0100
SubjectRe: [PATCH 1/6] genirq: allow assigning affinity to present but not online CPUs
Message-ID<t7UNZ-7sP-25@gated-at.bofh.it>
In reply to#1573932
On Sun, Feb 05, 2017 at 05:40:23PM +0100, Christoph Hellwig wrote:
> Hi Joe,
> 
> On Fri, Feb 03, 2017 at 08:58:09PM -0500, Joe Korty wrote:
> > IIRC, some years ago I ran across a customer system where
> > the #cpus_present was twice as big as #cpus_possible.
> > 
> > Hyperthreading was turned off in the BIOS so it was not
> > entirely out of line for the extra cpus to be declared
> > present, even though none of them would ever be available
> > for use.
> 
> This sounds like a system we should quirk around instead of optimizing
> for it.  Unless I totally misunderstand the idea behind cpu_possible
> and cpu_present.

Can we use the online CPUs and create a new hot-cpu notifier to the nvme
driver to free/reallocate as needed? We were doing that before blk-mq. Now
blk-mq can change the number hardware contexts on a live queue, so we
can reintroduce that behavior to nvme and only allocate what we need.

[toc] | [prev] | [next] | [standalone]


#1575006

FromChristoph Hellwig <hch@lst.de>
Date2017-02-06 18:10 +0100
Message-ID<t7UXF-7LS-39@gated-at.bofh.it>
In reply to#1574991
On Mon, Feb 06, 2017 at 12:03:05PM -0500, Keith Busch wrote:
> Can we use the online CPUs and create a new hot-cpu notifier to the nvme
> driver to free/reallocate as needed? We were doing that before blk-mq. Now
> blk-mq can change the number hardware contexts on a live queue, so we
> can reintroduce that behavior to nvme and only allocate what we need.

That could be a next step, but given how badly I keep messing up core
IRQ bits we'll probably want to wait for two rewrites of those bits
from Thomas before moving on :)

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web