Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1573740 > unrolled thread

[PATCH] somedriver: remove the initialization of static pointers.

Back to article view | Back to linux.kernel

Contents

  [PATCH] somedriver: remove the initialization of static pointers. AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com> - 2017-02-04 20:50 +0100
    Re: [PATCH] somedriver: remove the initialization of static pointers. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-05 01:40 +0100
      Re: [PATCH] somedriver: remove the initialization of static  pointers. AbdAllah MEZITI <abdallah.meziti.pro@gmail.com> - 2017-02-05 08:20 +0100
        Re: [PATCH] somedriver: remove the initialization of static pointers. Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-02-06 18:40 +0100

#1573740 — [PATCH] somedriver: remove the initialization of static pointers.

In C a static pointer will be initialized to NULL (e.g: draft C99 standard $6.7.8):
"If an object that has static storage duration is not initialized
explicitly, then:
 __ if it has pointer type, it is initialized to a null pointer;"

Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
---
 drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
index a84d74d..265fe55 100644
--- a/drivers/staging/bcm2835-audio/bcm2835.c
+++ b/drivers/staging/bcm2835-audio/bcm2835.c
@@ -28,8 +28,8 @@
  * to debug if we run into issues
  */
 
-static struct snd_card *g_card = NULL;
-static struct bcm2835_chip *g_chip = NULL;
+static struct snd_card *g_card;
+static struct bcm2835_chip *g_chip;
 
 static int snd_bcm2835_free(struct bcm2835_chip *chip)
 {
-- 
2.7.4

[toc] | [next] | [standalone]

#1573787

On Sat, Feb 04, 2017 at 08:39:21PM +0100, AbdAllah-MEZITI wrote:
> In C a static pointer will be initialized to NULL (e.g: draft C99 standard $6.7.8):
> "If an object that has static storage duration is not initialized
> explicitly, then:
>  __ if it has pointer type, it is initialized to a null pointer;"
> 
> Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>

Your subject is very odd :(

And is that the correct spelling of your name that you use for legal
documents?  If not, please fix up when you resend this.

Also, fix the line-wrapping of your changelog, and the C99 standard is
not a "draft" anymore, it was released in 1999 :)

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1573825 — Re: [PATCH] somedriver: remove the initialization of static pointers.

On Sun, 5 Feb 2017 01:29:43 +0100
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Sat, Feb 04, 2017 at 08:39:21PM +0100, AbdAllah-MEZITI wrote:
> > In C a static pointer will be initialized to NULL (e.g: draft C99
> > standard $6.7.8): "If an object that has static storage duration is
> > not initialized explicitly, then:
> >  __ if it has pointer type, it is initialized to a null pointer;"
> > 
> > Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>  
> 
> Your subject is very odd :(
> 
> And is that the correct spelling of your name that you use for legal
> documents?  If not, please fix up when you resend this.
> 
> Also, fix the line-wrapping of your changelog, and the C99 standard is
> not a "draft" anymore, it was released in 1999 :)
> 
> thanks,
> 
> greg k-h


Do not worry, this is just an answer to the Task 10 of the Eudyptula Challenge.

yes, this is the correct spelling of my name that i use for legal documents.

OK.

AbdAllah MEZITI.

[toc] | [prev] | [next] | [standalone]

#1575022

On Sun, Feb 05, 2017 at 08:12:26AM +0100, AbdAllah MEZITI wrote:
> On Sun, 5 Feb 2017 01:29:43 +0100
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> > On Sat, Feb 04, 2017 at 08:39:21PM +0100, AbdAllah-MEZITI wrote:
> > > In C a static pointer will be initialized to NULL (e.g: draft C99
> > > standard $6.7.8): "If an object that has static storage duration is
> > > not initialized explicitly, then:
> > >  __ if it has pointer type, it is initialized to a null pointer;"
> > > 
> > > Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>  
> > 
> > Your subject is very odd :(
> > 
> > And is that the correct spelling of your name that you use for legal
> > documents?  If not, please fix up when you resend this.
> > 
> > Also, fix the line-wrapping of your changelog, and the C99 standard is
> > not a "draft" anymore, it was released in 1999 :)
> > 
> > thanks,
> > 
> > greg k-h
> 
> 
> Do not worry, this is just an answer to the Task 10 of the Eudyptula Challenge.

AbdAllah, 

Patches submitted as part of the Eudyptula Challenge are fixing real problems
and most of the time accepted for queueing.  As such the work you sumbit for it
is serious and should be as perfect as possible.

Happy times with the Challenge,
Mathieu

> 
> yes, this is the correct spelling of my name that i use for legal documents.
> 
> OK.
> 
> AbdAllah MEZITI.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web