Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1573457 > unrolled thread

Re: [PATCH] bus: arm-ccn: Fix module autoload

Started byJavier Martinez Canillas <javier@osg.samsung.com>
First post2017-02-03 22:40 +0100
Last post2017-02-09 16:10 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] bus: arm-ccn: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-03 22:40 +0100
    Re: [PATCH] bus: arm-ccn: Fix module autoload Pawel Moll <pawel.moll@arm.com> - 2017-02-06 14:10 +0100
      Re: [PATCH] bus: arm-ccn: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-09 16:10 +0100

#1573457 — Re: [PATCH] bus: arm-ccn: Fix module autoload

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2017-02-03 22:40 +0100
SubjectRe: [PATCH] bus: arm-ccn: Fix module autoload
Message-ID<t6TKi-7ml-7@gated-at.bofh.it>
Hello,

On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/bus/arm-ccn.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/bus/arm-ccn.ko | grep alias
> alias:          of:N*T*Carm,ccn-504C*
> alias:          of:N*T*Carm,ccn-504
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---

Any comments about this patch?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [next] | [standalone]


#1574667

FromPawel Moll <pawel.moll@arm.com>
Date2017-02-06 14:10 +0100
Message-ID<t7Rdo-5m6-29@gated-at.bofh.it>
In reply to#1573457
On Fri, 2017-02-03 at 18:31 -0300, Javier Martinez Canillas wrote:
> On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote:
> > 
> > If the driver is built as a module, autoload won't work because the module
> > alias information is not filled. So user-space can't match the registered
> > device with the corresponding module.
> > 
> > Export the module alias information using the MODULE_DEVICE_TABLE()
> > macro.
> > 
> > Before this patch:
> > 
> > $ modinfo drivers/bus/arm-ccn.ko | grep alias
> > $
> > 
> > After this patch:
> > 
> > $ modinfo drivers/bus/arm-ccn.ko | grep alias
> > alias:          of:N*T*Carm,ccn-504C*
> > alias:          of:N*T*Carm,ccn-504
> > 
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > ---
> Any comments about this patch?

Sorry, I clearly missed that in my mailbox at the beginning of the
year.

It all makes sense to me. I'll try to test it out soon and will make
sure to include it next time I send out CCN update.

Thanks!

Paweł

[toc] | [prev] | [next] | [standalone]


#1577665

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2017-02-09 16:10 +0100
Message-ID<t8Ywa-7IY-31@gated-at.bofh.it>
In reply to#1574667
Hello Pawel,

On 02/06/2017 10:05 AM, Pawel Moll wrote:
> On Fri, 2017-02-03 at 18:31 -0300, Javier Martinez Canillas wrote:
>> On 01/02/2017 10:02 AM, Javier Martinez Canillas wrote:
>>>
>>> If the driver is built as a module, autoload won't work because the module
>>> alias information is not filled. So user-space can't match the registered
>>> device with the corresponding module.
>>>
>>> Export the module alias information using the MODULE_DEVICE_TABLE()
>>> macro.
>>>
>>> Before this patch:
>>>
>>> $ modinfo drivers/bus/arm-ccn.ko | grep alias
>>> $
>>>
>>> After this patch:
>>>
>>> $ modinfo drivers/bus/arm-ccn.ko | grep alias
>>> alias:          of:N*T*Carm,ccn-504C*
>>> alias:          of:N*T*Carm,ccn-504
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>> ---
>> Any comments about this patch?
> 
> Sorry, I clearly missed that in my mailbox at the beginning of the
> year.
> 
> It all makes sense to me. I'll try to test it out soon and will make
> sure to include it next time I send out CCN update.
>

Ok, thanks a lot!
 
> Thanks!
> 
> Paweł
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web