Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1574624 > unrolled thread

[PATCH v3] staging: lustre: align else if statement to coding standard

Back to article view | Back to linux.kernel

Contents

  [PATCH v3] staging: lustre: align else if statement to coding  standard Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-02-06 13:30 +0100
    Re: [PATCH v3] staging: lustre: align else if statement to coding  standard Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-06 14:00 +0100
      Re: [PATCH v3] staging: lustre: align else if statement to coding  standard Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-02-06 14:00 +0100
        Re: [PATCH v3] staging: lustre: align else if statement to coding  standard Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-06 14:10 +0100
          Re: [PATCH v3] staging: lustre: align else if statement to coding  standard Joe Perches <joe@perches.com> - 2017-02-06 16:00 +0100

#1574624 — [PATCH v3] staging: lustre: align else if statement to coding standard

- move logical continuations at the end of line
- move else if statement to a single line
- Replace spaces with tabstop.

Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
---
 drivers/staging/wlan-ng/prism2mgmt.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
index 16fb2d3..5277f36 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -1307,10 +1307,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
 		    && (msg->prismheader.data == P80211ENUM_truth_true)) {
 			hw->sniffhdr = 0;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
-		} else
-		    if ((msg->wlanheader.status ==
-			 P80211ENUM_msgitem_status_data_ok)
-			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
+		} else if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) &&
+			   (msg->wlanheader.data == P80211ENUM_truth_true)) {
 			hw->sniffhdr = 1;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
 		} else {
-- 
2.1.4

[toc] | [next] | [standalone]

#1574648

On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote:
> - move logical continuations at the end of line
> - move else if statement to a single line
> - Replace spaces with tabstop.

That's a lot of different things, happening all at once.  Please break
this up into multiple patches, each one only doing one thing, and send a
patch series.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1574652

On Mon, Feb 06, 2017 at 01:50:02PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote:
> > - move logical continuations at the end of line
> > - move else if statement to a single line
> > - Replace spaces with tabstop.
> 
> That's a lot of different things, happening all at once.  Please break
> this up into multiple patches, each one only doing one thing, and send a
> patch series.
> 
> thanks,
> 
> greg k-h

Fixing two lines of code in three patches?

[toc] | [prev] | [next] | [standalone]

#1574660

On Mon, Feb 06, 2017 at 07:56:39AM -0500, Maksymilian Piechota wrote:
> On Mon, Feb 06, 2017 at 01:50:02PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote:
> > > - move logical continuations at the end of line
> > > - move else if statement to a single line
> > > - Replace spaces with tabstop.
> > 
> > That's a lot of different things, happening all at once.  Please break
> > this up into multiple patches, each one only doing one thing, and send a
> > patch series.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Fixing two lines of code in three patches?

Yes.

[toc] | [prev] | [next] | [standalone]

#1574868

On Mon, 2017-02-06 at 14:03 +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 06, 2017 at 07:56:39AM -0500, Maksymilian Piechota wrote:
> > On Mon, Feb 06, 2017 at 01:50:02PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote:
> > > > - move logical continuations at the end of line
> > > > - move else if statement to a single line
> > > > - Replace spaces with tabstop.
> > > 
> > > That's a lot of different things, happening all at once.  Please break
> > > this up into multiple patches, each one only doing one thing, and send a
> > > patch series.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > Fixing two lines of code in three patches?
> 
> Yes.

Greg is also sometimes completely crazy.

I think he's only doing this because you are a
relatively new patch submitter and he wants you
to go through some linux-kernel process hazing.

It'd be more efficient as a single patch and better
overall to avoid descriptions with multiple
characteristics that elicit Greg's somewhat OCD
reflexes.

If this commit log was merely described as "use a
normal kernel style" for the else if and nothing
else was mentioned, this would likely have been
accepted.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web