Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1572415 > unrolled thread

[PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i

Started byArnd Bergmann <arnd@arndb.de>
First post2017-02-02 15:40 +0100
Last post2017-02-06 23:50 +0100
Articles 4 — 4 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i Arnd Bergmann <arnd@arndb.de> - 2017-02-02 15:40 +0100
    Re: [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i Chen-Yu Tsai <wens@csie.org> - 2017-02-06 04:50 +0100
    Re: [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-06 12:00 +0100
    Re: [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i Stephen Boyd <sboyd@codeaurora.org> - 2017-02-06 23:50 +0100

#1572415 — [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i

FromArnd Bergmann <arnd@arndb.de>
Date2017-02-02 15:40 +0100
Subject[PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun5i
Message-ID<t6qIi-5eS-43@gated-at.bofh.it>
We get a link error when CCU_MULT is not set with the
newly added driver:

drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.17+0x4): undefined reference to `ccu_mult_ops'
drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.5+0x4): undefined reference to `ccu_mult_ops'

Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/clk/sunxi-ng/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
index 67659091860d..695bbf9ef428 100644
--- a/drivers/clk/sunxi-ng/Kconfig
+++ b/drivers/clk/sunxi-ng/Kconfig
@@ -67,6 +67,7 @@ config SUN50I_A64_CCU
 config SUN5I_CCU
 	bool "Support for the Allwinner sun5i family CCM"
 	select SUNXI_CCU_DIV
+	select SUNXI_CCU_MULT
 	select SUNXI_CCU_NK
 	select SUNXI_CCU_NKM
 	select SUNXI_CCU_NM
-- 
2.9.0

[toc] | [next] | [standalone]


#1574349

FromChen-Yu Tsai <wens@csie.org>
Date2017-02-06 04:50 +0100
Message-ID<t7Itr-7W3-1@gated-at.bofh.it>
In reply to#1572415
On Thu, Feb 2, 2017 at 10:33 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> We get a link error when CCU_MULT is not set with the
> newly added driver:
>
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.17+0x4): undefined reference to `ccu_mult_ops'
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.5+0x4): undefined reference to `ccu_mult_ops'
>
> Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Chen-Yu Tsai <wens@csie.org>

[toc] | [prev] | [next] | [standalone]


#1574553

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2017-02-06 12:00 +0100
Message-ID<t7PbA-3SX-3@gated-at.bofh.it>
In reply to#1572415

[Multipart message — attachments visible in raw view] — view raw

On Thu, Feb 02, 2017 at 03:33:57PM +0100, Arnd Bergmann wrote:
> We get a link error when CCU_MULT is not set with the
> newly added driver:
> 
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.17+0x4): undefined reference to `ccu_mult_ops'
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.5+0x4): undefined reference to `ccu_mult_ops'
> 
> Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Mike, Stephen, can you apply it directly?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]


#1575217

FromStephen Boyd <sboyd@codeaurora.org>
Date2017-02-06 23:50 +0100
Message-ID<t80gG-2FR-11@gated-at.bofh.it>
In reply to#1572415
On 02/02, Arnd Bergmann wrote:
> We get a link error when CCU_MULT is not set with the
> newly added driver:
> 
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.17+0x4): undefined reference to `ccu_mult_ops'
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.5+0x4): undefined reference to `ccu_mult_ops'
> 
> Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web