Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1571726 > unrolled thread
| Started by | Fabrice Gasnier <fabrice.gasnier@st.com> |
|---|---|
| First post | 2017-02-01 17:50 +0100 |
| Last post | 2017-02-08 13:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mfd: stm32-timers: fix driver removal Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-01 17:50 +0100
Re: [PATCH] mfd: stm32-timers: fix driver removal Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-02-06 11:10 +0100
Re: [PATCH] mfd: stm32-timers: fix driver removal Lee Jones <lee.jones@linaro.org> - 2017-02-08 13:30 +0100
| From | Fabrice Gasnier <fabrice.gasnier@st.com> |
|---|---|
| Date | 2017-02-01 17:50 +0100 |
| Subject | [PATCH] mfd: stm32-timers: fix driver removal |
| Message-ID | <t66gy-8kU-23@gated-at.bofh.it> |
Add missing of_platform_depopulate() upon driver removal.
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
drivers/mfd/stm32-timers.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c
index 41bd901..192cbb6 100644
--- a/drivers/mfd/stm32-timers.c
+++ b/drivers/mfd/stm32-timers.c
@@ -61,6 +61,13 @@ static int stm32_timers_probe(struct platform_device *pdev)
return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
}
+static int stm32_timers_remove(struct platform_device *pdev)
+{
+ of_platform_depopulate(&pdev->dev);
+
+ return 0;
+}
+
static const struct of_device_id stm32_timers_of_match[] = {
{ .compatible = "st,stm32-timers", },
{ /* end node */ },
@@ -69,6 +76,7 @@ static int stm32_timers_probe(struct platform_device *pdev)
static struct platform_driver stm32_timers_driver = {
.probe = stm32_timers_probe,
+ .remove = stm32_timers_remove,
.driver = {
.name = "stm32-timers",
.of_match_table = stm32_timers_of_match,
--
1.9.1
[toc] | [next] | [standalone]
| From | Benjamin Gaignard <benjamin.gaignard@linaro.org> |
|---|---|
| Date | 2017-02-06 11:10 +0100 |
| Message-ID | <t7Opc-3AB-11@gated-at.bofh.it> |
| In reply to | #1571726 |
2017-02-01 17:41 GMT+01:00 Fabrice Gasnier <fabrice.gasnier@st.com>:
> Add missing of_platform_depopulate() upon driver removal.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> drivers/mfd/stm32-timers.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c
> index 41bd901..192cbb6 100644
> --- a/drivers/mfd/stm32-timers.c
> +++ b/drivers/mfd/stm32-timers.c
> @@ -61,6 +61,13 @@ static int stm32_timers_probe(struct platform_device *pdev)
> return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
> }
>
> +static int stm32_timers_remove(struct platform_device *pdev)
> +{
> + of_platform_depopulate(&pdev->dev);
> +
> + return 0;
> +}
> +
> static const struct of_device_id stm32_timers_of_match[] = {
> { .compatible = "st,stm32-timers", },
> { /* end node */ },
> @@ -69,6 +76,7 @@ static int stm32_timers_probe(struct platform_device *pdev)
>
> static struct platform_driver stm32_timers_driver = {
> .probe = stm32_timers_probe,
> + .remove = stm32_timers_remove,
> .driver = {
> .name = "stm32-timers",
> .of_match_table = stm32_timers_of_match,
> --
> 1.9.1
>
Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-02-08 13:30 +0100 |
| Message-ID | <t8zxM-h3-41@gated-at.bofh.it> |
| In reply to | #1571726 |
On Wed, 01 Feb 2017, Fabrice Gasnier wrote:
> Add missing of_platform_depopulate() upon driver removal.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> drivers/mfd/stm32-timers.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Applied, thanks.
> diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c
> index 41bd901..192cbb6 100644
> --- a/drivers/mfd/stm32-timers.c
> +++ b/drivers/mfd/stm32-timers.c
> @@ -61,6 +61,13 @@ static int stm32_timers_probe(struct platform_device *pdev)
> return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
> }
>
> +static int stm32_timers_remove(struct platform_device *pdev)
> +{
> + of_platform_depopulate(&pdev->dev);
> +
> + return 0;
> +}
> +
> static const struct of_device_id stm32_timers_of_match[] = {
> { .compatible = "st,stm32-timers", },
> { /* end node */ },
> @@ -69,6 +76,7 @@ static int stm32_timers_probe(struct platform_device *pdev)
>
> static struct platform_driver stm32_timers_driver = {
> .probe = stm32_timers_probe,
> + .remove = stm32_timers_remove,
> .driver = {
> .name = "stm32-timers",
> .of_match_table = stm32_timers_of_match,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web