Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1574444 > unrolled thread

Re: [PATCH 3.10 000/319] 3.10.105-stable review

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 3.10 000/319] 3.10.105-stable review Willy Tarreau <w@1wt.eu> - 2017-02-06 09:20 +0100
    Re: [PATCH 3.10 000/319] 3.10.105-stable review Guenter Roeck <linux@roeck-us.net> - 2017-02-06 15:50 +0100
      Re: [PATCH 3.10 000/319] 3.10.105-stable review Willy Tarreau <w@1wt.eu> - 2017-02-06 16:20 +0100
      Re: [PATCH 3.10 000/319] 3.10.105-stable review Willy Tarreau <w@1wt.eu> - 2017-02-06 23:50 +0100
        Re: [PATCH 3.10 000/319] 3.10.105-stable review Guenter Roeck <linux@roeck-us.net> - 2017-02-07 00:50 +0100
        Re: [PATCH 3.10 000/319] 3.10.105-stable review Guenter Roeck <linux@roeck-us.net> - 2017-02-07 06:00 +0100
          Re: [PATCH 3.10 000/319] 3.10.105-stable review Willy Tarreau <w@1wt.eu> - 2017-02-07 07:50 +0100

#1574444 — Re: [PATCH 3.10 000/319] 3.10.105-stable review

On Sun, Feb 05, 2017 at 08:09:04PM +0100, Willy Tarreau wrote:
> This is the start of the stable review cycle for the 3.10.105 release.
> 
> NOTE! This series is quite large as I've caught up with many pending fixes
> that were submitted for -stable long ago and that I had been holding on
> since 3.10.103 due to limited time. Most fixes address stability issues
> in crypto, net, usb, scsi, kvm, random info leaks, and risks of oopses
> in various subsystems. My pending queue is now empty.
> 
> It builds fine here on i586 and x86_64 for allmodconfig and on armv7 with
> mvebu_defconfig.
> 
> All patches will be posted as a response to this one. If anyone has any
> issue with these being applied, please let me know. If anyone thinks some
> important patches are missing and should be added prior to the release,
> please report them quickly with their respective mainline commit IDs.
> 
> Responses should be made by Fri Feb 10 10:00:00 CET 2017.
> Anything received after that time might be too late. If someone
> wants a bit more time for a deeper review, please let me know.
> 
> The whole patch series can be found in one patch at :
>    https://kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.10.105-rc1.gz

An updated patch was pushed here :

  https://kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.10.105-rc2.gz

It drops the following patches which broke some architectures :

  arch: Introduce smp_load_acquire(), smp_store_release()
  kernel: Provide READ_ONCE and ASSIGN_ONCE
  kernel: Change ASSIGN_ONCE(val, x) to WRITE_ONCE(x, val)
  kernel: make READ_ONCE() valid on const arguments
  locking: Remove atomicy checks from {READ,WRITE}_ONCE
  compiler: Allow 1- and 2-byte smp_load_acquire() and smp_store_release()
  ipc: remove use of seq_printf return value
  ipc/sem.c: fix complex_count vs. simple op race

It reverts this one as an alternative :

  ipc/sem.c: optimize sem_lock()

And it drops this one as not needed (thanks to Bart Van Assche):

  IB/srpt: Simplify srpt_handle_tsk_mgmt()

The deadline for the review remains unchanged.

Thanks!
Willy

[toc] | [next] | [standalone]

#1574851

On 02/06/2017 12:13 AM, Willy Tarreau wrote:
> On Sun, Feb 05, 2017 at 08:09:04PM +0100, Willy Tarreau wrote:
>> This is the start of the stable review cycle for the 3.10.105 release.
>>
>> NOTE! This series is quite large as I've caught up with many pending fixes
>> that were submitted for -stable long ago and that I had been holding on
>> since 3.10.103 due to limited time. Most fixes address stability issues
>> in crypto, net, usb, scsi, kvm, random info leaks, and risks of oopses
>> in various subsystems. My pending queue is now empty.
>>
>> It builds fine here on i586 and x86_64 for allmodconfig and on armv7 with
>> mvebu_defconfig.
>>
>> All patches will be posted as a response to this one. If anyone has any
>> issue with these being applied, please let me know. If anyone thinks some
>> important patches are missing and should be added prior to the release,
>> please report them quickly with their respective mainline commit IDs.
>>
>> Responses should be made by Fri Feb 10 10:00:00 CET 2017.
>> Anything received after that time might be too late. If someone
>> wants a bit more time for a deeper review, please let me know.
>>
>> The whole patch series can be found in one patch at :
>>    https://kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.10.105-rc1.gz
>
> An updated patch was pushed here :
>
>   https://kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.10.105-rc2.gz
>

Better, but unfortunately there is now a different build error.

Build results:
	total: 124 pass: 122 fail: 2
Failed builds:
	x86_64:allyesconfig
	x86_64:allmodconfig

Qemu test results:
	total: 83 pass: 83 fail: 0

Build error:

drivers/block/xen-blkback/common.h: In function 'blkif_get_x86_32_req':
drivers/block/xen-blkback/common.h:272:2: error: implicit declaration of function 'READ_ONCE'

Guenter

[toc] | [prev] | [next] | [standalone]

#1574889

On Mon, Feb 06, 2017 at 06:46:39AM -0800, Guenter Roeck wrote:
> On 02/06/2017 12:13 AM, Willy Tarreau wrote:
> > On Sun, Feb 05, 2017 at 08:09:04PM +0100, Willy Tarreau wrote:
> > > This is the start of the stable review cycle for the 3.10.105 release.
> > > 
> > > NOTE! This series is quite large as I've caught up with many pending fixes
> > > that were submitted for -stable long ago and that I had been holding on
> > > since 3.10.103 due to limited time. Most fixes address stability issues
> > > in crypto, net, usb, scsi, kvm, random info leaks, and risks of oopses
> > > in various subsystems. My pending queue is now empty.
> > > 
> > > It builds fine here on i586 and x86_64 for allmodconfig and on armv7 with
> > > mvebu_defconfig.
> > > 
> > > All patches will be posted as a response to this one. If anyone has any
> > > issue with these being applied, please let me know. If anyone thinks some
> > > important patches are missing and should be added prior to the release,
> > > please report them quickly with their respective mainline commit IDs.
> > > 
> > > Responses should be made by Fri Feb 10 10:00:00 CET 2017.
> > > Anything received after that time might be too late. If someone
> > > wants a bit more time for a deeper review, please let me know.
> > > 
> > > The whole patch series can be found in one patch at :
> > >    https://kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.10.105-rc1.gz
> > 
> > An updated patch was pushed here :
> > 
> >   https://kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.10.105-rc2.gz
> > 
> 
> Better, but unfortunately there is now a different build error.
> 
> Build results:
> 	total: 124 pass: 122 fail: 2
> Failed builds:
> 	x86_64:allyesconfig
> 	x86_64:allmodconfig
> 
> Qemu test results:
> 	total: 83 pass: 83 fail: 0
> 
> Build error:
> 
> drivers/block/xen-blkback/common.h: In function 'blkif_get_x86_32_req':
> drivers/block/xen-blkback/common.h:272:2: error: implicit declaration of function 'READ_ONCE'

Thank you, I didn't realize that one of the Xen patches was depending
on it. It will make things a bit more complicated but it's easier for
me to debug an architecture I can more easily test ;-)

Willy

[toc] | [prev] | [next] | [standalone]

#1575222

On Mon, Feb 06, 2017 at 06:46:39AM -0800, Guenter Roeck wrote:
> > An updated patch was pushed here :
> > 
> >   https://kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.10.105-rc2.gz
> > 
> 
> Better, but unfortunately there is now a different build error.
> 
> Build results:
> 	total: 124 pass: 122 fail: 2
> Failed builds:
> 	x86_64:allyesconfig
> 	x86_64:allmodconfig
> 
> Qemu test results:
> 	total: 83 pass: 83 fail: 0
> 
> Build error:
> 
> drivers/block/xen-blkback/common.h: In function 'blkif_get_x86_32_req':
> drivers/block/xen-blkback/common.h:272:2: error: implicit declaration of function 'READ_ONCE'

So I could easily reproduce it on allmodconfig here and fix it, by
replacing this READ_ONCE with ACCESS_ONCE. You don't need to build again
Guenter, your report already helped me a lot.

Thanks!
Willy

[toc] | [prev] | [next] | [standalone]

#1575254

On Mon, Feb 06, 2017 at 11:48:03PM +0100, Willy Tarreau wrote:
> On Mon, Feb 06, 2017 at 06:46:39AM -0800, Guenter Roeck wrote:
> > > An updated patch was pushed here :
> > > 
> > >   https://kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.10.105-rc2.gz
> > > 
> > 
> > Better, but unfortunately there is now a different build error.
> > 
> > Build results:
> > 	total: 124 pass: 122 fail: 2
> > Failed builds:
> > 	x86_64:allyesconfig
> > 	x86_64:allmodconfig
> > 
> > Qemu test results:
> > 	total: 83 pass: 83 fail: 0
> > 
> > Build error:
> > 
> > drivers/block/xen-blkback/common.h: In function 'blkif_get_x86_32_req':
> > drivers/block/xen-blkback/common.h:272:2: error: implicit declaration of function 'READ_ONCE'
> 
> So I could easily reproduce it on allmodconfig here and fix it, by
> replacing this READ_ONCE with ACCESS_ONCE. You don't need to build again
> Guenter, your report already helped me a lot.
> 
The system will start a build automatically after a change shows up
in your repository. Nothing I need to do other than pay for servers
and electricity :-).

I just checked - the next build of 3.10 is scheduled to start in about
an hour.

Cheers
Guenter

[toc] | [prev] | [next] | [standalone]

#1575383

On 02/06/2017 02:48 PM, Willy Tarreau wrote:
> On Mon, Feb 06, 2017 at 06:46:39AM -0800, Guenter Roeck wrote:
>>> An updated patch was pushed here :
>>>
>>>   https://kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.10.105-rc2.gz
>>>
>>
>> Better, but unfortunately there is now a different build error.
>>
>> Build results:
>> 	total: 124 pass: 122 fail: 2
>> Failed builds:
>> 	x86_64:allyesconfig
>> 	x86_64:allmodconfig
>>
>> Qemu test results:
>> 	total: 83 pass: 83 fail: 0
>>
>> Build error:
>>
>> drivers/block/xen-blkback/common.h: In function 'blkif_get_x86_32_req':
>> drivers/block/xen-blkback/common.h:272:2: error: implicit declaration of function 'READ_ONCE'
>
> So I could easily reproduce it on allmodconfig here and fix it, by
> replacing this READ_ONCE with ACCESS_ONCE. You don't need to build again
> Guenter, your report already helped me a lot.
>

This time everything builds fine.

Build results:
	total: 124 pass: 124 fail: 0
Qemu test results:
	total: 83 pass: 83 fail: 0

Guenter

[toc] | [prev] | [next] | [standalone]

#1575414

On Mon, Feb 06, 2017 at 08:56:25PM -0800, Guenter Roeck wrote:
> On 02/06/2017 02:48 PM, Willy Tarreau wrote:
> > On Mon, Feb 06, 2017 at 06:46:39AM -0800, Guenter Roeck wrote:
> > > > An updated patch was pushed here :
> > > > 
> > > >   https://kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.10.105-rc2.gz
> > > > 
> > > 
> > > Better, but unfortunately there is now a different build error.
> > > 
> > > Build results:
> > > 	total: 124 pass: 122 fail: 2
> > > Failed builds:
> > > 	x86_64:allyesconfig
> > > 	x86_64:allmodconfig
> > > 
> > > Qemu test results:
> > > 	total: 83 pass: 83 fail: 0
> > > 
> > > Build error:
> > > 
> > > drivers/block/xen-blkback/common.h: In function 'blkif_get_x86_32_req':
> > > drivers/block/xen-blkback/common.h:272:2: error: implicit declaration of function 'READ_ONCE'
> > 
> > So I could easily reproduce it on allmodconfig here and fix it, by
> > replacing this READ_ONCE with ACCESS_ONCE. You don't need to build again
> > Guenter, your report already helped me a lot.
> > 
> 
> This time everything builds fine.
> 
> Build results:
> 	total: 124 pass: 124 fail: 0
> Qemu test results:
> 	total: 83 pass: 83 fail: 0

Pretty cool, thanks!
Willy

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web