Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1574356 > unrolled thread
| Started by | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| First post | 2017-02-06 05:30 +0100 |
| Last post | 2017-02-06 21:40 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
linux-next: build failure after merge of the tty tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-02-06 05:30 +0100
Re: linux-next: build failure after merge of the tty tree Greg KH <greg@kroah.com> - 2017-02-06 10:00 +0100
Re: linux-next: build failure after merge of the tty tree Rob Herring <robh@kernel.org> - 2017-02-06 15:20 +0100
Re: linux-next: build failure after merge of the tty tree Greg KH <greg@kroah.com> - 2017-02-06 16:20 +0100
Re: linux-next: build failure after merge of the tty tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-02-06 21:40 +0100
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2017-02-06 05:30 +0100 |
| Subject | linux-next: build failure after merge of the tty tree |
| Message-ID | <t7J6a-8py-5@gated-at.bofh.it> |
Hi Greg,
After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined!
ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
Caused by commit
cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
I have used the tty tree from next-20170203 for today.
--
Cheers,
Stephen Rothwell
[toc] | [next] | [standalone]
| From | Greg KH <greg@kroah.com> |
|---|---|
| Date | 2017-02-06 10:00 +0100 |
| Message-ID | <t7Njs-2A1-7@gated-at.bofh.it> |
| In reply to | #1574356 |
On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
>
> Caused by commit
>
> cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
>
> I have used the tty tree from next-20170203 for today.
Ugh, how has this been passing the 0-day bot builds succesfully?
Rob, any ideas?
thanks,
greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-02-06 15:20 +0100 |
| Message-ID | <t7Sj7-61m-1@gated-at.bofh.it> |
| In reply to | #1574462 |
On Mon, Feb 6, 2017 at 2:51 AM, Greg KH <greg@kroah.com> wrote:
> On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>>
>> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined!
>> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
>>
>> Caused by commit
>>
>> cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
>>
>> I have used the tty tree from next-20170203 for today.
>
> Ugh, how has this been passing the 0-day bot builds succesfully?
>
> Rob, any ideas?
It didn't, but we happened to already have a fix queued up for 4.11.
The fix is in your usb-next branch:
commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7
Author: Stephen Boyd <stephen.boyd@linaro.org>
Date: Wed Dec 28 14:56:48 2016 -0800
of: device: Export of_device_{get_modalias, uvent_modalias} to modules
The ULPI bus can be built as a module, and it will soon be
calling these functions when it supports probing devices from DT.
Export them so they can be used by the ULPI module.
Acked-by: Rob Herring <robh@kernel.org>
Cc: <devicetree@vger.kernel.org>
Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Rob
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <greg@kroah.com> |
|---|---|
| Date | 2017-02-06 16:20 +0100 |
| Message-ID | <t7Tfc-6CJ-21@gated-at.bofh.it> |
| In reply to | #1574810 |
On Mon, Feb 06, 2017 at 08:09:16AM -0600, Rob Herring wrote:
> On Mon, Feb 6, 2017 at 2:51 AM, Greg KH <greg@kroah.com> wrote:
> > On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote:
> >> Hi Greg,
> >>
> >> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> >> failed like this:
> >>
> >> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> >> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> >>
> >> Caused by commit
> >>
> >> cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
> >>
> >> I have used the tty tree from next-20170203 for today.
> >
> > Ugh, how has this been passing the 0-day bot builds succesfully?
> >
> > Rob, any ideas?
>
> It didn't, but we happened to already have a fix queued up for 4.11.
> The fix is in your usb-next branch:
>
> commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7
> Author: Stephen Boyd <stephen.boyd@linaro.org>
> Date: Wed Dec 28 14:56:48 2016 -0800
>
> of: device: Export of_device_{get_modalias, uvent_modalias} to modules
>
> The ULPI bus can be built as a module, and it will soon be
> calling these functions when it supports probing devices from DT.
> Export them so they can be used by the ULPI module.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Cc: <devicetree@vger.kernel.org>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
Ah, so the if this is pulled into linux-next at the same time, then
there's no build error.
Stephen, do you need/want me to cherry-pick this into the tty branch, or
is it ok as-is?
thanks,
greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2017-02-06 21:40 +0100 |
| Message-ID | <t7YeS-1pE-23@gated-at.bofh.it> |
| In reply to | #1574883 |
Hi Greg,
On Mon, 6 Feb 2017 16:18:22 +0100 Greg KH <greg@kroah.com> wrote:
>
> On Mon, Feb 06, 2017 at 08:09:16AM -0600, Rob Herring wrote:
> >
> > It didn't, but we happened to already have a fix queued up for 4.11.
> > The fix is in your usb-next branch:
> >
> > commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7
> > Author: Stephen Boyd <stephen.boyd@linaro.org>
> > Date: Wed Dec 28 14:56:48 2016 -0800
> >
> > of: device: Export of_device_{get_modalias, uvent_modalias} to modules
> >
> > The ULPI bus can be built as a module, and it will soon be
> > calling these functions when it supports probing devices from DT.
> > Export them so they can be used by the ULPI module.
> >
> > Acked-by: Rob Herring <robh@kernel.org>
> > Cc: <devicetree@vger.kernel.org>
> > Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> > Signed-off-by: Peter Chen <peter.chen@nxp.com>
>
> Ah, so the if this is pulled into linux-next at the same time, then
> there's no build error.
>
> Stephen, do you need/want me to cherry-pick this into the tty branch, or
> is it ok as-is?
I will change things so that I merge the usb tree before the tty tree.
Please remember to tell Linus that they need to be merged in that order.
--
Cheers,
Stephen Rothwell
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web