Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1573571 > unrolled thread
| Started by | Derek Robson <robsonde@gmail.com> |
|---|---|
| First post | 2017-02-04 02:50 +0100 |
| Last post | 2017-02-04 12:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: iio: resolver: ad2s1210.c - style fix Derek Robson <robsonde@gmail.com> - 2017-02-04 02:50 +0100
Re: [PATCH] Staging: iio: resolver: ad2s1210.c - style fix Jonathan Cameron <jic23@kernel.org> - 2017-02-04 12:50 +0100
| From | Derek Robson <robsonde@gmail.com> |
|---|---|
| Date | 2017-02-04 02:50 +0100 |
| Subject | [PATCH] Staging: iio: resolver: ad2s1210.c - style fix |
| Message-ID | <t6XEd-1GS-1@gated-at.bofh.it> |
Changed symbolic permissions to octal permissions. Found using checkpatch Signed-off-by: Derek Robson <robsonde@gmail.com> --- drivers/staging/iio/resolver/ad2s1210.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index 6b992634f009..90b57c03609c 100644 --- a/drivers/staging/iio/resolver/ad2s1210.c +++ b/drivers/staging/iio/resolver/ad2s1210.c @@ -531,36 +531,36 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, return ret; } -static IIO_DEVICE_ATTR(fclkin, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(fclkin, 0644, ad2s1210_show_fclkin, ad2s1210_store_fclkin, 0); -static IIO_DEVICE_ATTR(fexcit, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(fexcit, 0644, ad2s1210_show_fexcit, ad2s1210_store_fexcit, 0); -static IIO_DEVICE_ATTR(control, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(control, 0644, ad2s1210_show_control, ad2s1210_store_control, 0); -static IIO_DEVICE_ATTR(bits, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(bits, 0644, ad2s1210_show_resolution, ad2s1210_store_resolution, 0); -static IIO_DEVICE_ATTR(fault, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(fault, 0644, ad2s1210_show_fault, ad2s1210_clear_fault, 0); -static IIO_DEVICE_ATTR(los_thrd, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(los_thrd, 0644, ad2s1210_show_reg, ad2s1210_store_reg, AD2S1210_REG_LOS_THRD); -static IIO_DEVICE_ATTR(dos_ovr_thrd, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(dos_ovr_thrd, 0644, ad2s1210_show_reg, ad2s1210_store_reg, AD2S1210_REG_DOS_OVR_THRD); -static IIO_DEVICE_ATTR(dos_mis_thrd, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(dos_mis_thrd, 0644, ad2s1210_show_reg, ad2s1210_store_reg, AD2S1210_REG_DOS_MIS_THRD); -static IIO_DEVICE_ATTR(dos_rst_max_thrd, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(dos_rst_max_thrd, 0644, ad2s1210_show_reg, ad2s1210_store_reg, AD2S1210_REG_DOS_RST_MAX_THRD); -static IIO_DEVICE_ATTR(dos_rst_min_thrd, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(dos_rst_min_thrd, 0644, ad2s1210_show_reg, ad2s1210_store_reg, AD2S1210_REG_DOS_RST_MIN_THRD); -static IIO_DEVICE_ATTR(lot_high_thrd, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(lot_high_thrd, 0644, ad2s1210_show_reg, ad2s1210_store_reg, AD2S1210_REG_LOT_HIGH_THRD); -static IIO_DEVICE_ATTR(lot_low_thrd, S_IRUGO | S_IWUSR, +static IIO_DEVICE_ATTR(lot_low_thrd, 0644, ad2s1210_show_reg, ad2s1210_store_reg, AD2S1210_REG_LOT_LOW_THRD); -- 2.11.1
[toc] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-02-04 12:50 +0100 |
| Message-ID | <t770R-8ii-3@gated-at.bofh.it> |
| In reply to | #1573571 |
On 04/02/17 01:45, Derek Robson wrote: > Changed symbolic permissions to octal permissions. > Found using checkpatch > > Signed-off-by: Derek Robson <robsonde@gmail.com> Applied. Thanks, Jonathan > --- > drivers/staging/iio/resolver/ad2s1210.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c > index 6b992634f009..90b57c03609c 100644 > --- a/drivers/staging/iio/resolver/ad2s1210.c > +++ b/drivers/staging/iio/resolver/ad2s1210.c > @@ -531,36 +531,36 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, > return ret; > } > > -static IIO_DEVICE_ATTR(fclkin, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(fclkin, 0644, > ad2s1210_show_fclkin, ad2s1210_store_fclkin, 0); > -static IIO_DEVICE_ATTR(fexcit, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(fexcit, 0644, > ad2s1210_show_fexcit, ad2s1210_store_fexcit, 0); > -static IIO_DEVICE_ATTR(control, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(control, 0644, > ad2s1210_show_control, ad2s1210_store_control, 0); > -static IIO_DEVICE_ATTR(bits, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(bits, 0644, > ad2s1210_show_resolution, ad2s1210_store_resolution, 0); > -static IIO_DEVICE_ATTR(fault, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(fault, 0644, > ad2s1210_show_fault, ad2s1210_clear_fault, 0); > > -static IIO_DEVICE_ATTR(los_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(los_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_LOS_THRD); > -static IIO_DEVICE_ATTR(dos_ovr_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(dos_ovr_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_DOS_OVR_THRD); > -static IIO_DEVICE_ATTR(dos_mis_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(dos_mis_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_DOS_MIS_THRD); > -static IIO_DEVICE_ATTR(dos_rst_max_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(dos_rst_max_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_DOS_RST_MAX_THRD); > -static IIO_DEVICE_ATTR(dos_rst_min_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(dos_rst_min_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_DOS_RST_MIN_THRD); > -static IIO_DEVICE_ATTR(lot_high_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(lot_high_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_LOT_HIGH_THRD); > -static IIO_DEVICE_ATTR(lot_low_thrd, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(lot_low_thrd, 0644, > ad2s1210_show_reg, ad2s1210_store_reg, > AD2S1210_REG_LOT_LOW_THRD); > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web