Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1572226 > unrolled thread
| Started by | Neil Armstrong <narmstrong@baylibre.com> |
|---|---|
| First post | 2017-02-02 10:50 +0100 |
| Last post | 2017-02-02 13:10 +0100 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] drm: meson: Fixup driver and module name Neil Armstrong <narmstrong@baylibre.com> - 2017-02-02 10:50 +0100
[PATCH 2/2] drm: meson: rename driver name to meson-drm Neil Armstrong <narmstrong@baylibre.com> - 2017-02-02 10:50 +0100
Re: [PATCH 2/2] drm: meson: rename driver name to meson-drm Daniel Vetter <daniel@ffwll.ch> - 2017-02-02 11:50 +0100
Re: [PATCH 2/2] drm: meson: rename driver name to meson-drm Neil Armstrong <narmstrong@baylibre.com> - 2017-02-02 12:00 +0100
Re: [PATCH 2/2] drm: meson: rename driver name to meson-drm Daniel Vetter <daniel@ffwll.ch> - 2017-02-02 13:10 +0100
| From | Neil Armstrong <narmstrong@baylibre.com> |
|---|---|
| Date | 2017-02-02 10:50 +0100 |
| Subject | [PATCH 0/2] drm: meson: Fixup driver and module name |
| Message-ID | <t6mbD-26H-3@gated-at.bofh.it> |
This patchset is a simple fixup to rename the confusion possible module and driver name "meson" to a more explicit "meson-drm" name. Neil Armstrong (2): drm: meson: rename module name to meson-drm drm: meson: rename driver name to meson-drm drivers/gpu/drm/meson/Makefile | 6 +++--- drivers/gpu/drm/meson/meson_drv.c | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) -- 1.9.1
[toc] | [next] | [standalone]
| From | Neil Armstrong <narmstrong@baylibre.com> |
|---|---|
| Date | 2017-02-02 10:50 +0100 |
| Subject | [PATCH 2/2] drm: meson: rename driver name to meson-drm |
| Message-ID | <t6mbD-26H-19@gated-at.bofh.it> |
| In reply to | #1572226 |
The platform driver name is currently "meson" which can lead to some
confusion, this patch renames it to "meson-drm" and removes the owner
attribute.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/gpu/drm/meson/meson_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
index ff1f601..380bde7 100644
--- a/drivers/gpu/drm/meson/meson_drv.c
+++ b/drivers/gpu/drm/meson/meson_drv.c
@@ -329,8 +329,7 @@ static int meson_drv_remove(struct platform_device *pdev)
.probe = meson_drv_probe,
.remove = meson_drv_remove,
.driver = {
- .owner = THIS_MODULE,
- .name = DRIVER_NAME,
+ .name = "meson-drm",
.of_match_table = dt_match,
},
};
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Daniel Vetter <daniel@ffwll.ch> |
|---|---|
| Date | 2017-02-02 11:50 +0100 |
| Subject | Re: [PATCH 2/2] drm: meson: rename driver name to meson-drm |
| Message-ID | <t6n7I-2Kl-15@gated-at.bofh.it> |
| In reply to | #1572228 |
On Thu, Feb 02, 2017 at 10:47:44AM +0100, Neil Armstrong wrote:
> The platform driver name is currently "meson" which can lead to some
> confusion, this patch renames it to "meson-drm" and removes the owner
> attribute.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/gpu/drm/meson/meson_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> index ff1f601..380bde7 100644
> --- a/drivers/gpu/drm/meson/meson_drv.c
> +++ b/drivers/gpu/drm/meson/meson_drv.c
> @@ -329,8 +329,7 @@ static int meson_drv_remove(struct platform_device *pdev)
> .probe = meson_drv_probe,
> .remove = meson_drv_remove,
> .driver = {
> - .owner = THIS_MODULE,
I don't get why you remove this, generally that will lead to trouble of
being able to unload code that's still in use ...
Otherwise ack.
Now, do you want to get this landed as part of the small drivers in
drm-mis experiment?
-Daniel
> - .name = DRIVER_NAME,
> + .name = "meson-drm",
> .of_match_table = dt_match,
> },
> };
> --
> 1.9.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
[toc] | [prev] | [next] | [standalone]
| From | Neil Armstrong <narmstrong@baylibre.com> |
|---|---|
| Date | 2017-02-02 12:00 +0100 |
| Subject | Re: [PATCH 2/2] drm: meson: rename driver name to meson-drm |
| Message-ID | <t6nhn-2Sm-5@gated-at.bofh.it> |
| In reply to | #1572270 |
On 02/02/2017 11:45 AM, Daniel Vetter wrote:
> On Thu, Feb 02, 2017 at 10:47:44AM +0100, Neil Armstrong wrote:
>> The platform driver name is currently "meson" which can lead to some
>> confusion, this patch renames it to "meson-drm" and removes the owner
>> attribute.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> drivers/gpu/drm/meson/meson_drv.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
>> index ff1f601..380bde7 100644
>> --- a/drivers/gpu/drm/meson/meson_drv.c
>> +++ b/drivers/gpu/drm/meson/meson_drv.c
>> @@ -329,8 +329,7 @@ static int meson_drv_remove(struct platform_device *pdev)
>> .probe = meson_drv_probe,
>> .remove = meson_drv_remove,
>> .driver = {
>> - .owner = THIS_MODULE,
Hi Daniel,
> I don't get why you remove this, generally that will lead to trouble of
> being able to unload code that's still in use ...
Indeed, but since a (long ?) time, the owner field is now populated by the
platform_driver_register() core code.
>
> Otherwise ack.
>
> Now, do you want to get this landed as part of the small drivers in
> drm-mis experiment?
I have a PR ready, but it can go through this experiment, yes.
> -Daniel
>
>> - .name = DRIVER_NAME,
>> + .name = "meson-drm",
>> .of_match_table = dt_match,
>> },
>> };
>> --
Thanks,
Neil
[toc] | [prev] | [next] | [standalone]
| From | Daniel Vetter <daniel@ffwll.ch> |
|---|---|
| Date | 2017-02-02 13:10 +0100 |
| Subject | Re: [PATCH 2/2] drm: meson: rename driver name to meson-drm |
| Message-ID | <t6on8-3Ln-19@gated-at.bofh.it> |
| In reply to | #1572273 |
On Thu, Feb 02, 2017 at 11:50:59AM +0100, Neil Armstrong wrote:
> On 02/02/2017 11:45 AM, Daniel Vetter wrote:
> > On Thu, Feb 02, 2017 at 10:47:44AM +0100, Neil Armstrong wrote:
> >> The platform driver name is currently "meson" which can lead to some
> >> confusion, this patch renames it to "meson-drm" and removes the owner
> >> attribute.
> >>
> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >> ---
> >> drivers/gpu/drm/meson/meson_drv.c | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> >> index ff1f601..380bde7 100644
> >> --- a/drivers/gpu/drm/meson/meson_drv.c
> >> +++ b/drivers/gpu/drm/meson/meson_drv.c
> >> @@ -329,8 +329,7 @@ static int meson_drv_remove(struct platform_device *pdev)
> >> .probe = meson_drv_probe,
> >> .remove = meson_drv_remove,
> >> .driver = {
> >> - .owner = THIS_MODULE,
>
> Hi Daniel,
>
> > I don't get why you remove this, generally that will lead to trouble of
> > being able to unload code that's still in use ...
>
> Indeed, but since a (long ?) time, the owner field is now populated by the
> platform_driver_register() core code.
>
> >
> > Otherwise ack.
> >
> > Now, do you want to get this landed as part of the small drivers in
> > drm-mis experiment?
>
> I have a PR ready, but it can go through this experiment, yes.
If you want to give it a spin, you need:
- fdo account https://www.freedesktop.org/wiki/AccountRequests/
- drm-misc group access
- dim set up for drm-misc, see
https://01.org/linuxgraphics/gfx-docs/maintainer-tools/dim.html and
https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html
For questions it's best to pipe up #dri-devel.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web