Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1572325 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-02-02 13:30 +0100 |
| Last post | 2017-02-06 15:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] CIFS: use correct format string for size_t Arnd Bergmann <arnd@arndb.de> - 2017-02-02 13:30 +0100
Re: [PATCH] CIFS: use correct format string for size_t Pavel Shilovsky <piastryyy@gmail.com> - 2017-02-02 19:10 +0100
Re: [PATCH] CIFS: use correct format string for size_t Sachin Prabhu <sprabhu@redhat.com> - 2017-02-06 15:00 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-02-02 13:30 +0100 |
| Subject | [PATCH] CIFS: use correct format string for size_t |
| Message-ID | <t6oGu-3Tn-23@gated-at.bofh.it> |
This warning is harmless as size_t is always as wide as 'unsigned long':
fs/cifs/smb2ops.c:2008:245: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned int}' [-Werror=format=]
Using %zu however is the correct format string that we don't get a warning for.
Fixes: c9d651a5a2fe ("CIFS: Decrypt and process small encrypted packets")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/cifs/smb2ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index 0764c32754b0..ac6e10adf000 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -2005,7 +2005,7 @@ handle_read_data(struct TCP_Server_Info *server, struct mid_q_entry *mid,
rdata->iov[0].iov_len = 4;
rdata->iov[1].iov_base = buf + 4;
rdata->iov[1].iov_len = server->vals->read_rsp_size - 4;
- cifs_dbg(FYI, "0: iov_base=%p iov_len=%lu\n",
+ cifs_dbg(FYI, "0: iov_base=%p iov_len=%zu\n",
rdata->iov[0].iov_base, server->vals->read_rsp_size);
length = rdata->copy_into_pages(server, rdata, &iter);
--
2.9.0
[toc] | [next] | [standalone]
| From | Pavel Shilovsky <piastryyy@gmail.com> |
|---|---|
| Date | 2017-02-02 19:10 +0100 |
| Message-ID | <t6tZx-7qr-61@gated-at.bofh.it> |
| In reply to | #1572325 |
2017-02-02 4:21 GMT-08:00 Arnd Bergmann <arnd@arndb.de>:
> This warning is harmless as size_t is always as wide as 'unsigned long':
>
> fs/cifs/smb2ops.c:2008:245: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned int}' [-Werror=format=]
>
> Using %zu however is the correct format string that we don't get a warning for.
>
> Fixes: c9d651a5a2fe ("CIFS: Decrypt and process small encrypted packets")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> fs/cifs/smb2ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 0764c32754b0..ac6e10adf000 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -2005,7 +2005,7 @@ handle_read_data(struct TCP_Server_Info *server, struct mid_q_entry *mid,
> rdata->iov[0].iov_len = 4;
> rdata->iov[1].iov_base = buf + 4;
> rdata->iov[1].iov_len = server->vals->read_rsp_size - 4;
> - cifs_dbg(FYI, "0: iov_base=%p iov_len=%lu\n",
> + cifs_dbg(FYI, "0: iov_base=%p iov_len=%zu\n",
> rdata->iov[0].iov_base, server->vals->read_rsp_size);
>
> length = rdata->copy_into_pages(server, rdata, &iter);
> --
> 2.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
This issue have been already fixed in the Steve's for-next branch. Thanks.
--
Best regards,
Pavel Shilovsky
[toc] | [prev] | [next] | [standalone]
| From | Sachin Prabhu <sprabhu@redhat.com> |
|---|---|
| Date | 2017-02-06 15:00 +0100 |
| Message-ID | <t7RZN-5F5-53@gated-at.bofh.it> |
| In reply to | #1572325 |
On Thu, 2017-02-02 at 13:21 +0100, Arnd Bergmann wrote:
> This warning is harmless as size_t is always as wide as 'unsigned
> long':
>
> fs/cifs/smb2ops.c:2008:245: error: format '%lu' expects argument of
> type 'long unsigned int', but argument 5 has type 'size_t {aka
> unsigned int}' [-Werror=format=]
>
> Using %zu however is the correct format string that we don't get a
> warning for.
>
> Fixes: c9d651a5a2fe ("CIFS: Decrypt and process small encrypted
> packets")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Sachin Prabhu <sprabhu@redhat.com>
> ---
> fs/cifs/smb2ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 0764c32754b0..ac6e10adf000 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -2005,7 +2005,7 @@ handle_read_data(struct TCP_Server_Info
> *server, struct mid_q_entry *mid,
> rdata->iov[0].iov_len = 4;
> rdata->iov[1].iov_base = buf + 4;
> rdata->iov[1].iov_len = server->vals->read_rsp_size - 4;
> - cifs_dbg(FYI, "0: iov_base=%p iov_len=%lu\n",
> + cifs_dbg(FYI, "0: iov_base=%p iov_len=%zu\n",
> rdata->iov[0].iov_base, server->vals-
> >read_rsp_size);
>
> length = rdata->copy_into_pages(server, rdata, &iter);
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web