Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1572036 > unrolled thread

[PATCH] x86, mpx: re-add MPX to selftests Makefile

Back to article view | Back to linux.kernel

Contents

  [PATCH] x86, mpx: re-add MPX to selftests Makefile Dave Hansen <dave.hansen@linux.intel.com> - 2017-02-02 00:00 +0100
    Re: [PATCH] x86, mpx: re-add MPX to selftests Makefile Ingo Molnar <mingo@kernel.org> - 2017-02-02 08:20 +0100
    [tip:x86/mm] x86/mpx: Re-add MPX to selftests Makefile tip-bot for Dave Hansen <tipbot@zytor.com> - 2017-02-02 08:20 +0100

#1572036 — [PATCH] x86, mpx: re-add MPX to selftests Makefile

From: Dave Hansen <dave.hansen@linux.intel.com>

Ingo pointed out that the MPX tests were no longer in the selftests
Makefile.  It appears that I shot myself in the foot on this one
and accidentally removed them when I added the pkeys tests, probably
from bungling a merge conflict.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Fixes: 5f23f6d082a9 ("x86/pkeys: Add self-tests")
Cc: x86@kernel.org
---

 b/tools/testing/selftests/x86/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN tools/testing/selftests/x86/Makefile~mpx-re-add-selftests tools/testing/selftests/x86/Makefile
--- a/tools/testing/selftests/x86/Makefile~mpx-re-add-selftests	2017-02-01 14:50:26.836302147 -0800
+++ b/tools/testing/selftests/x86/Makefile	2017-02-01 14:50:26.839302281 -0800
@@ -5,7 +5,7 @@ include ../lib.mk
 .PHONY: all all_32 all_64 warn_32bit_failure clean
 
 TARGETS_C_BOTHBITS := single_step_syscall sysret_ss_attrs syscall_nt ptrace_syscall test_mremap_vdso \
-			check_initial_reg_state sigreturn ldt_gdt iopl \
+			check_initial_reg_state sigreturn ldt_gdt iopl mpx-mini-test \
 			protection_keys test_vdso
 TARGETS_C_32BIT_ONLY := entry_from_vm86 syscall_arg_fault test_syscall_vdso unwind_vdso \
 			test_FCMOV test_FCOMI test_FISTTP \
_

[toc] | [next] | [standalone]

#1572165

* Dave Hansen <dave.hansen@linux.intel.com> wrote:

> 
> From: Dave Hansen <dave.hansen@linux.intel.com>
> 
> Ingo pointed out that the MPX tests were no longer in the selftests
> Makefile.  It appears that I shot myself in the foot on this one
> and accidentally removed them when I added the pkeys tests, probably
> from bungling a merge conflict.

Note, we still have these ugly warnings when building the pkeys testcase with GCC 
5.4.0:

gcc -m32 -o protection_keys_32 -O2 -g -std=gnu99 -pthread -Wall  protection_keys.c -lrt -ldl -lm
protection_keys.c: In function ‘setup_hugetlbfs’:
protection_keys.c:816:6: warning: unused variable ‘i’ [-Wunused-variable]
  int i;
      ^
protection_keys.c:815:6: warning: unused variable ‘validated_nr_pages’ [-Wunused-variable]
  int validated_nr_pages;
      ^
protection_keys.c: In function ‘test_pkey_syscalls_bad_args’:
protection_keys.c:1136:6: warning: unused variable ‘bad_flag’ [-Wunused-variable]
  int bad_flag = (PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE) + 1;
      ^
protection_keys.c: In function ‘test_pkey_alloc_exhaust’:
protection_keys.c:1153:16: warning: unused variable ‘init_val’ [-Wunused-variable]
  unsigned long init_val;
                ^
protection_keys.c:1152:16: warning: unused variable ‘flags’ [-Wunused-variable]
  unsigned long flags;
                ^
In file included from protection_keys.c:45:0:
pkey-helpers.h: In function ‘sigsafe_printf’:
pkey-helpers.h:41:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
   write(1, dprint_in_signal_buffer, len);
   ^
protection_keys.c: In function ‘dumpit’:
protection_keys.c:407:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
   write(1, buf, nr_read);
   ^
protection_keys.c: In function ‘pkey_disable_set’:
protection_keys.c:68:5: warning: ‘orig_pkru’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (!(condition)) {   \
     ^
protection_keys.c:465:6: note: ‘orig_pkru’ was declared here
  u32 orig_pkru;
      ^

Thanks,

	Ingo

[toc] | [prev] | [next] | [standalone]

#1572168 — [tip:x86/mm] x86/mpx: Re-add MPX to selftests Makefile

Commit-ID:  e64d5fbe56259c94df504af8ce804cfc6a022adb
Gitweb:     http://git.kernel.org/tip/e64d5fbe56259c94df504af8ce804cfc6a022adb
Author:     Dave Hansen <dave.hansen@linux.intel.com>
AuthorDate: Wed, 1 Feb 2017 14:56:29 -0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 2 Feb 2017 08:09:18 +0100

x86/mpx: Re-add MPX to selftests Makefile

Ingo pointed out that the MPX tests were no longer in the selftests
Makefile.  It appears that I shot myself in the foot on this one
and accidentally removed them when I added the pkeys tests, probably
from bungling a merge conflict.

Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 5f23f6d082a9 ("x86/pkeys: Add self-tests")
Link: http://lkml.kernel.org/r/20170201225629.C3070852@viggo.jf.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 tools/testing/selftests/x86/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index 8c1cb42..fefd950 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -5,7 +5,7 @@ include ../lib.mk
 .PHONY: all all_32 all_64 warn_32bit_failure clean
 
 TARGETS_C_BOTHBITS := single_step_syscall sysret_ss_attrs syscall_nt ptrace_syscall test_mremap_vdso \
-			check_initial_reg_state sigreturn ldt_gdt iopl \
+			check_initial_reg_state sigreturn ldt_gdt iopl mpx-mini-test \
 			protection_keys test_vdso
 TARGETS_C_32BIT_ONLY := entry_from_vm86 syscall_arg_fault test_syscall_vdso unwind_vdso \
 			test_FCMOV test_FCOMI test_FISTTP \

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web