Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1573168 > unrolled thread

[PATCH 1/2] DTS: dra7: Replace obsolete "operating-points" property with "operating-points-v2"

Started byLukasz Majewski <lukma@denx.de>
First post2017-02-03 16:30 +0100
Last post2017-02-06 04:50 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 1/2] DTS: dra7: Replace obsolete "operating-points" property with "operating-points-v2" Lukasz Majewski <lukma@denx.de> - 2017-02-03 16:30 +0100
    Re: [PATCH 1/2] DTS: dra7: Replace obsolete "operating-points"  property with "operating-points-v2" Dave Gerlach <d-gerlach@ti.com> - 2017-02-03 18:00 +0100
    Re: [PATCH 1/2] DTS: dra7: Replace obsolete "operating-points"  property with "operating-points-v2" Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-06 04:50 +0100

#1573168 — [PATCH 1/2] DTS: dra7: Replace obsolete "operating-points" property with "operating-points-v2"

FromLukasz Majewski <lukma@denx.de>
Date2017-02-03 16:30 +0100
Subject[PATCH 1/2] DTS: dra7: Replace obsolete "operating-points" property with "operating-points-v2"
Message-ID<t6NYe-3fD-23@gated-at.bofh.it>
The "operating-points" property have been replaced with
"operating-points-v2". Only entries with the same frequencies have
been added, so no reqression should be introduced.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 arch/arm/boot/dts/dra7.dtsi | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 3c228f9..a860a56 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -80,11 +80,7 @@
 			compatible = "arm,cortex-a15";
 			reg = <0>;
 
-			operating-points = <
-				/* kHz    uV */
-				1000000	1060000
-				1176000	1160000
-				>;
+			operating-points-v2 = <&cpu0_opp_table>;
 
 			clocks = <&dpll_mpu_ck>;
 			clock-names = "cpu";
@@ -98,6 +94,22 @@
 		};
 	};
 
+	cpu0_opp_table: opp_table0 {
+		compatible = "operating-points-v2";
+		opp-shared;
+
+		opp_nom@1000000000 {
+			opp-hz = /bits/ 64 <1000000000>;
+			opp-microvolt = <1060000 850000 1150000>;
+			opp-suspend;
+		};
+
+		opp_od@1176000000 {
+			opp-hz = /bits/ 64 <1176000000>;
+			opp-microvolt = <1160000 885000 1160000>;
+		};
+	};
+
 	/*
 	 * The soc node represents the soc top level view. It is used for IPs
 	 * that are not memory mapped in the MPU view or for the MPU itself.
-- 
2.1.4

[toc] | [next] | [standalone]


#1573272 — Re: [PATCH 1/2] DTS: dra7: Replace obsolete "operating-points" property with "operating-points-v2"

FromDave Gerlach <d-gerlach@ti.com>
Date2017-02-03 18:00 +0100
SubjectRe: [PATCH 1/2] DTS: dra7: Replace obsolete "operating-points" property with "operating-points-v2"
Message-ID<t6Pnk-4ec-23@gated-at.bofh.it>
In reply to#1573168
Hi,
On 02/03/2017 09:24 AM, Lukasz Majewski wrote:
> The "operating-points" property have been replaced with
> "operating-points-v2". Only entries with the same frequencies have
> been added, so no reqression should be introduced.
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>  arch/arm/boot/dts/dra7.dtsi | 22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 3c228f9..a860a56 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -80,11 +80,7 @@
>  			compatible = "arm,cortex-a15";
>  			reg = <0>;
>
> -			operating-points = <
> -				/* kHz    uV */
> -				1000000	1060000
> -				1176000	1160000
> -				>;
> +			operating-points-v2 = <&cpu0_opp_table>;
>
>  			clocks = <&dpll_mpu_ck>;
>  			clock-names = "cpu";
> @@ -98,6 +94,22 @@
>  		};
>  	};
>
> +	cpu0_opp_table: opp_table0 {
> +		compatible = "operating-points-v2";
> +		opp-shared;
> +
> +		opp_nom@1000000000 {
> +			opp-hz = /bits/ 64 <1000000000>;
> +			opp-microvolt = <1060000 850000 1150000>;
> +			opp-suspend;
> +		};
> +
> +		opp_od@1176000000 {
> +			opp-hz = /bits/ 64 <1176000000>;
> +			opp-microvolt = <1160000 885000 1160000>;
> +		};
> +	};
> +

This is being done here already [1] as these OPPs have specific requirements 
depending on the SoC in use. I have sent proper operating-points-v2 tables here 
[2] already, they won't be ready to merge until after the driver at [1] is merged.

Regards,
Dave

[1] http://www.spinics.net/lists/devicetree/msg158967.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-May/430209.html

>  	/*
>  	 * The soc node represents the soc top level view. It is used for IPs
>  	 * that are not memory mapped in the MPU view or for the MPU itself.
>

[toc] | [prev] | [next] | [standalone]


#1574348 — Re: [PATCH 1/2] DTS: dra7: Replace obsolete "operating-points" property with "operating-points-v2"

FromViresh Kumar <viresh.kumar@linaro.org>
Date2017-02-06 04:50 +0100
SubjectRe: [PATCH 1/2] DTS: dra7: Replace obsolete "operating-points" property with "operating-points-v2"
Message-ID<t7Itr-7W3-3@gated-at.bofh.it>
In reply to#1573168
On 03-02-17, 16:24, Lukasz Majewski wrote:
> The "operating-points" property have been replaced with
> "operating-points-v2". Only entries with the same frequencies have
> been added, so no reqression should be introduced.

Don't use "obsolete" word here. Its not obsolete and both bindings
will be supported.

-- 
viresh

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web