Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1571965 > unrolled thread

[PATCH] fscrypt: properly declare on-stack completion

Started byRichard Weinberger <richard@nod.at>
First post2017-02-01 21:40 +0100
Last post2017-02-07 05:30 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] fscrypt: properly declare on-stack completion Richard Weinberger <richard@nod.at> - 2017-02-01 21:40 +0100
    Re: [PATCH] fscrypt: properly declare on-stack completion Richard Weinberger <richard@nod.at> - 2017-02-01 21:40 +0100
    Re: [PATCH] fscrypt: properly declare on-stack completion Theodore Ts'o <tytso@mit.edu> - 2017-02-07 05:30 +0100

#1571965 — [PATCH] fscrypt: properly declare on-stack completion

FromRichard Weinberger <richard@nod.at>
Date2017-02-01 21:40 +0100
Subject[PATCH] fscrypt: properly declare on-stack completion
Message-ID<t69R7-2iN-9@gated-at.bofh.it>
When a completion is declared on-stack we have to use
COMPLETION_INITIALIZER_ONSTACK().

Fixes: 0b81d07790726 ("fs crypto: move per-file encryption from f2fs
tree to fs/crypto")
Signed-off-by: Richard Weinberger <richard@nod.at>

---
 fs/crypto/fscrypt_private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/crypto/fscrypt_private.h b/fs/crypto/fscrypt_private.h
index aeab032d7d35..a0494a164f97 100644
--- a/fs/crypto/fscrypt_private.h
+++ b/fs/crypto/fscrypt_private.h
@@ -81,7 +81,7 @@ struct fscrypt_completion_result {
 
 #define DECLARE_FS_COMPLETION_RESULT(ecr) \
 	struct fscrypt_completion_result ecr = { \
-		COMPLETION_INITIALIZER((ecr).completion), 0 }
+		COMPLETION_INITIALIZER_ONSTACK((ecr).completion), 0 }
 
 
 /* crypto.c */
-- 
2.10.2

[toc] | [next] | [standalone]


#1571966

FromRichard Weinberger <richard@nod.at>
Date2017-02-01 21:40 +0100
Message-ID<t69R8-2iN-13@gated-at.bofh.it>
In reply to#1571965
Am 01.02.2017 um 21:32 schrieb Richard Weinberger:
> When a completion is declared on-stack we have to use
> COMPLETION_INITIALIZER_ONSTACK().
> 
> Fixes: 0b81d07790726 ("fs crypto: move per-file encryption from f2fs
> tree to fs/crypto")
> Signed-off-by: Richard Weinberger <richard@nod.at>
> 
> ---
>  fs/crypto/fscrypt_private.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/crypto/fscrypt_private.h b/fs/crypto/fscrypt_private.h
> index aeab032d7d35..a0494a164f97 100644
> --- a/fs/crypto/fscrypt_private.h
> +++ b/fs/crypto/fscrypt_private.h
> @@ -81,7 +81,7 @@ struct fscrypt_completion_result {
>  
>  #define DECLARE_FS_COMPLETION_RESULT(ecr) \
>  	struct fscrypt_completion_result ecr = { \
> -		COMPLETION_INITIALIZER((ecr).completion), 0 }
> +		COMPLETION_INITIALIZER_ONSTACK((ecr).completion), 0 }
>  
>  
>  /* crypto.c */
> 

Replying with Ted's corrected mail address... ;-\

Thanks,
//richard

[toc] | [prev] | [next] | [standalone]


#1575376

FromTheodore Ts'o <tytso@mit.edu>
Date2017-02-07 05:30 +0100
Message-ID<t85zH-6gC-3@gated-at.bofh.it>
In reply to#1571965
On Wed, Feb 01, 2017 at 09:32:09PM +0100, Richard Weinberger wrote:
> When a completion is declared on-stack we have to use
> COMPLETION_INITIALIZER_ONSTACK().
> 
> Fixes: 0b81d07790726 ("fs crypto: move per-file encryption from f2fs
> tree to fs/crypto")
> Signed-off-by: Richard Weinberger <richard@nod.at>

Thanks, applied.

					- Ted

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web